* [PATCH] regulator: axp20x: Fix AXP806 dcdcb copy/paste bug
@ 2019-02-14 15:47 Rask Ingemann Lambertsen
2019-02-18 3:31 ` Chen-Yu Tsai
0 siblings, 1 reply; 2+ messages in thread
From: Rask Ingemann Lambertsen @ 2019-02-14 15:47 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Chen-Yu Tsai, linux-kernel
Cc: Olliver Schinagl, linux-arm-kernel
An obvious copy/paste bug was introduced with the conversion to sybolic
register masks. The result is contradictory output like this:
vcc-dram: Bringing 1100000uV into 1450000-1450000uV
vcc-dram: 1450 <--> 1550 mV at 1050 mV
This patch fixes it:
vcc-dram: 1450 <--> 1550 mV at 1500 mV
Fixes: db4a555f7c4c ("regulator: axp20x: use defines for masks")
Signed-off-by: Rask Ingemann Lambertsen <rask@formelder.dk>
---
drivers/regulator/axp20x-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
index 1b51d557ab55..f03cae440f7f 100644
--- a/drivers/regulator/axp20x-regulator.c
+++ b/drivers/regulator/axp20x-regulator.c
@@ -791,7 +791,7 @@ static const struct regulator_desc axp806_regulators[] = {
AXP806_DCDCA_V_CTRL, AXP806_DCDCA_V_CTRL_MASK,
AXP806_PWR_OUT_CTRL1, AXP806_PWR_OUT_DCDCA_MASK),
AXP_DESC(AXP806, DCDCB, "dcdcb", "vinb", 1000, 2550, 50,
- AXP806_DCDCB_V_CTRL, AXP806_DCDCB_V_CTRL,
+ AXP806_DCDCB_V_CTRL, AXP806_DCDCB_V_CTRL_MASK,
AXP806_PWR_OUT_CTRL1, AXP806_PWR_OUT_DCDCB_MASK),
AXP_DESC_RANGES(AXP806, DCDCC, "dcdcc", "vinc",
axp806_dcdca_ranges, AXP806_DCDCA_NUM_VOLTAGES,
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: axp20x: Fix AXP806 dcdcb copy/paste bug
2019-02-14 15:47 [PATCH] regulator: axp20x: Fix AXP806 dcdcb copy/paste bug Rask Ingemann Lambertsen
@ 2019-02-18 3:31 ` Chen-Yu Tsai
0 siblings, 0 replies; 2+ messages in thread
From: Chen-Yu Tsai @ 2019-02-18 3:31 UTC (permalink / raw)
To: Rask Ingemann Lambertsen
Cc: Liam Girdwood, Mark Brown, linux-kernel, Olliver Schinagl,
linux-arm-kernel
On Fri, Feb 15, 2019 at 5:24 AM Rask Ingemann Lambertsen
<rask@formelder.dk> wrote:
>
> An obvious copy/paste bug was introduced with the conversion to sybolic
> register masks. The result is contradictory output like this:
>
> vcc-dram: Bringing 1100000uV into 1450000-1450000uV
> vcc-dram: 1450 <--> 1550 mV at 1050 mV
>
> This patch fixes it:
>
> vcc-dram: 1450 <--> 1550 mV at 1500 mV
>
> Fixes: db4a555f7c4c ("regulator: axp20x: use defines for masks")
> Signed-off-by: Rask Ingemann Lambertsen <rask@formelder.dk>
Acked-by: Chen-Yu Tsai <wens@csie.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-18 3:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-14 15:47 [PATCH] regulator: axp20x: Fix AXP806 dcdcb copy/paste bug Rask Ingemann Lambertsen
2019-02-18 3:31 ` Chen-Yu Tsai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).