* [PATCH] firmware: Convert to using %pOF instead of full_name
@ 2017-07-18 21:43 Rob Herring
2017-07-21 16:03 ` Sudeep Holla
2017-08-16 15:20 ` Arnd Bergmann
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2017-07-18 21:43 UTC (permalink / raw)
To: arm
Cc: linux-kernel, devicetree, Sudeep Holla, Mark Rutland,
Lorenzo Pieralisi, linux-arm-kernel
Now that we have a custom printf format specifier, convert users of
full_name to use %pOF instead. This is preparation to remove storing
of the full path string for each node.
Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/firmware/arm_scpi.c | 2 +-
drivers/firmware/psci.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c
index 8043e51de897..59190c374696 100644
--- a/drivers/firmware/arm_scpi.c
+++ b/drivers/firmware/arm_scpi.c
@@ -965,7 +965,7 @@ static int scpi_probe(struct platform_device *pdev)
count = of_count_phandle_with_args(np, "mboxes", "#mbox-cells");
if (count < 0) {
- dev_err(dev, "no mboxes property in '%s'\n", np->full_name);
+ dev_err(dev, "no mboxes property in '%pOF'\n", np);
return -ENODEV;
}
diff --git a/drivers/firmware/psci.c b/drivers/firmware/psci.c
index 493a56a4cfc4..d687ca3d5049 100644
--- a/drivers/firmware/psci.c
+++ b/drivers/firmware/psci.c
@@ -280,8 +280,8 @@ static int psci_dt_cpu_init_idle(struct device_node *cpu_node, int cpu)
"arm,psci-suspend-param",
&state);
if (ret) {
- pr_warn(" * %s missing arm,psci-suspend-param property\n",
- state_node->full_name);
+ pr_warn(" * %pOF missing arm,psci-suspend-param property\n",
+ state_node);
of_node_put(state_node);
goto free_mem;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] firmware: Convert to using %pOF instead of full_name
2017-07-18 21:43 [PATCH] firmware: Convert to using %pOF instead of full_name Rob Herring
@ 2017-07-21 16:03 ` Sudeep Holla
2017-08-16 15:20 ` Arnd Bergmann
1 sibling, 0 replies; 3+ messages in thread
From: Sudeep Holla @ 2017-07-21 16:03 UTC (permalink / raw)
To: Rob Herring, arm
Cc: Sudeep Holla, linux-kernel, devicetree, Mark Rutland,
Lorenzo Pieralisi, linux-arm-kernel
On 18/07/17 22:43, Rob Herring wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> drivers/firmware/arm_scpi.c | 2 +-
> drivers/firmware/psci.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c
> index 8043e51de897..59190c374696 100644
> --- a/drivers/firmware/arm_scpi.c
> +++ b/drivers/firmware/arm_scpi.c
> @@ -965,7 +965,7 @@ static int scpi_probe(struct platform_device *pdev)
>
> count = of_count_phandle_with_args(np, "mboxes", "#mbox-cells");
> if (count < 0) {
> - dev_err(dev, "no mboxes property in '%s'\n", np->full_name);
> + dev_err(dev, "no mboxes property in '%pOF'\n", np);
> return -ENODEV;
> }
>
(For the SCPI part)
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
I assume you will ask ARM-SoC guys to pick this up. Let us know if you
think otherwise.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] firmware: Convert to using %pOF instead of full_name
2017-07-18 21:43 [PATCH] firmware: Convert to using %pOF instead of full_name Rob Herring
2017-07-21 16:03 ` Sudeep Holla
@ 2017-08-16 15:20 ` Arnd Bergmann
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-08-16 15:20 UTC (permalink / raw)
To: Rob Herring
Cc: arm-soc, Linux Kernel Mailing List, devicetree, Sudeep Holla,
Mark Rutland, Lorenzo Pieralisi, Linux ARM
On Tue, Jul 18, 2017 at 11:43 PM, Rob Herring <robh@kernel.org> wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
Applied to next/drivers with Sudeep's ack, thanks.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-16 15:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-18 21:43 [PATCH] firmware: Convert to using %pOF instead of full_name Rob Herring
2017-07-21 16:03 ` Sudeep Holla
2017-08-16 15:20 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).