* [PATCH v5 0/2] Fixing check patch styling issues
@ 2023-05-09 16:52 Raghu Halharvi
2023-05-09 16:52 ` [PATCH v5 1/2] cxl/mbox: Remove redundant dev_err() after failed mem alloc Raghu Halharvi
2023-05-09 16:52 ` [PATCH v5 2/2] cxl/region: Remove else after return statement Raghu Halharvi
0 siblings, 2 replies; 5+ messages in thread
From: Raghu Halharvi @ 2023-05-09 16:52 UTC (permalink / raw)
To: linux-cxl, Alison Schofield, raghuhack78, ira.weiny, bwidawsk,
dan.j.williams, vishal.l.verma
Cc: linux-kernel
v5 changes:
- Updated the missing reviewed tag in "cxl/mbox: Remove redundant
dev_err() after failed mem alloc" patch (Dave Jiang)
v4 changes:
- Updated the respective patches with reviewers tags for respective
patches(Dave Jiang)
v3 changes:
- Update the cover letter and commit message with full author
name(Fabio/Alison)
- Correct the "typo error" in commit message(Fabio)
v2 changes:
Thanks Alison, Ira for your comments, modified the v1 patches as
suggested.
Dropped the patch containing tab changes in port.c
v1 cover letter:
The following patches are cleanup or fixing the styling issues found
using checkpatch
In cxl/core/mbox.c, in case of null check failure, returning errno or
-ENOMEM in this case is good enough, removing the redundant dev_err
message.
In cxl/core/region.c, the else is not required after the return
statement, cleaned it up.
Verified the build and sanity by booting the guest VM using the freshly
built components.
Raghu Halharvi (2):
cxl/mbox: Remove redundant dev_err() after failed mem alloc
cxl/region: Remove else after return statement
drivers/cxl/core/mbox.c | 4 +---
drivers/cxl/core/region.c | 8 ++++----
2 files changed, 5 insertions(+), 7 deletions(-)
--
2.39.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v5 1/2] cxl/mbox: Remove redundant dev_err() after failed mem alloc
2023-05-09 16:52 [PATCH v5 0/2] Fixing check patch styling issues Raghu Halharvi
@ 2023-05-09 16:52 ` Raghu Halharvi
2023-05-10 22:01 ` Ira Weiny
2023-05-09 16:52 ` [PATCH v5 2/2] cxl/region: Remove else after return statement Raghu Halharvi
1 sibling, 1 reply; 5+ messages in thread
From: Raghu Halharvi @ 2023-05-09 16:52 UTC (permalink / raw)
To: linux-cxl, Alison Schofield, raghuhack78, ira.weiny, bwidawsk,
dan.j.williams, vishal.l.verma
Cc: linux-kernel, Dave Jiang
Issue found with checkpatch
A return of errno should be good enough if the memory allocation fails,
the error message here is redundant as per the coding style, removing it.
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Raghu Halharvi <raghuhack78@gmail.com>
---
drivers/cxl/core/mbox.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
index f2addb457172..11ea145b4b1f 100644
--- a/drivers/cxl/core/mbox.c
+++ b/drivers/cxl/core/mbox.c
@@ -1112,10 +1112,8 @@ struct cxl_dev_state *cxl_dev_state_create(struct device *dev)
struct cxl_dev_state *cxlds;
cxlds = devm_kzalloc(dev, sizeof(*cxlds), GFP_KERNEL);
- if (!cxlds) {
- dev_err(dev, "No memory available\n");
+ if (!cxlds)
return ERR_PTR(-ENOMEM);
- }
mutex_init(&cxlds->mbox_mutex);
mutex_init(&cxlds->event.log_lock);
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v5 2/2] cxl/region: Remove else after return statement
2023-05-09 16:52 [PATCH v5 0/2] Fixing check patch styling issues Raghu Halharvi
2023-05-09 16:52 ` [PATCH v5 1/2] cxl/mbox: Remove redundant dev_err() after failed mem alloc Raghu Halharvi
@ 2023-05-09 16:52 ` Raghu Halharvi
2023-05-10 22:02 ` Ira Weiny
1 sibling, 1 reply; 5+ messages in thread
From: Raghu Halharvi @ 2023-05-09 16:52 UTC (permalink / raw)
To: linux-cxl, Alison Schofield, raghuhack78, ira.weiny, bwidawsk,
dan.j.williams, vishal.l.verma
Cc: linux-kernel, Dave Jiang
Issue found with checkpatch
The else section here is redundant after return statement, removing it.
Sanity and correctness is not affected due to this fix.
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
Signed-off-by: Raghu Halharvi <raghuhack78@gmail.com>
---
drivers/cxl/core/region.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
index f29028148806..a46d6ad9ef0a 100644
--- a/drivers/cxl/core/region.c
+++ b/drivers/cxl/core/region.c
@@ -2666,11 +2666,11 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr)
"Bypassing cpu_cache_invalidate_memregion() for testing!\n");
clear_bit(CXL_REGION_F_INCOHERENT, &cxlr->flags);
return 0;
- } else {
- dev_err(&cxlr->dev,
- "Failed to synchronize CPU cache state\n");
- return -ENXIO;
}
+
+ dev_err(&cxlr->dev,
+ "Failed to synchronize CPU cache state\n");
+ return -ENXIO;
}
cpu_cache_invalidate_memregion(IORES_DESC_CXL);
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v5 1/2] cxl/mbox: Remove redundant dev_err() after failed mem alloc
2023-05-09 16:52 ` [PATCH v5 1/2] cxl/mbox: Remove redundant dev_err() after failed mem alloc Raghu Halharvi
@ 2023-05-10 22:01 ` Ira Weiny
0 siblings, 0 replies; 5+ messages in thread
From: Ira Weiny @ 2023-05-10 22:01 UTC (permalink / raw)
To: Raghu Halharvi, linux-cxl, Alison Schofield, ira.weiny, bwidawsk,
dan.j.williams, vishal.l.verma
Cc: linux-kernel, Dave Jiang
Raghu Halharvi wrote:
> Issue found with checkpatch
>
> A return of errno should be good enough if the memory allocation fails,
> the error message here is redundant as per the coding style, removing it.
>
> Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> Signed-off-by: Raghu Halharvi <raghuhack78@gmail.com>
> ---
> drivers/cxl/core/mbox.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index f2addb457172..11ea145b4b1f 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -1112,10 +1112,8 @@ struct cxl_dev_state *cxl_dev_state_create(struct device *dev)
> struct cxl_dev_state *cxlds;
>
> cxlds = devm_kzalloc(dev, sizeof(*cxlds), GFP_KERNEL);
> - if (!cxlds) {
> - dev_err(dev, "No memory available\n");
> + if (!cxlds)
> return ERR_PTR(-ENOMEM);
> - }
>
> mutex_init(&cxlds->mbox_mutex);
> mutex_init(&cxlds->event.log_lock);
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v5 2/2] cxl/region: Remove else after return statement
2023-05-09 16:52 ` [PATCH v5 2/2] cxl/region: Remove else after return statement Raghu Halharvi
@ 2023-05-10 22:02 ` Ira Weiny
0 siblings, 0 replies; 5+ messages in thread
From: Ira Weiny @ 2023-05-10 22:02 UTC (permalink / raw)
To: Raghu Halharvi, linux-cxl, Alison Schofield, ira.weiny, bwidawsk,
dan.j.williams, vishal.l.verma
Cc: linux-kernel, Dave Jiang
Raghu Halharvi wrote:
> Issue found with checkpatch
>
> The else section here is redundant after return statement, removing it.
> Sanity and correctness is not affected due to this fix.
>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> Signed-off-by: Raghu Halharvi <raghuhack78@gmail.com>
> ---
> drivers/cxl/core/region.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> index f29028148806..a46d6ad9ef0a 100644
> --- a/drivers/cxl/core/region.c
> +++ b/drivers/cxl/core/region.c
> @@ -2666,11 +2666,11 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr)
> "Bypassing cpu_cache_invalidate_memregion() for testing!\n");
> clear_bit(CXL_REGION_F_INCOHERENT, &cxlr->flags);
> return 0;
> - } else {
> - dev_err(&cxlr->dev,
> - "Failed to synchronize CPU cache state\n");
> - return -ENXIO;
> }
> +
> + dev_err(&cxlr->dev,
> + "Failed to synchronize CPU cache state\n");
> + return -ENXIO;
> }
>
> cpu_cache_invalidate_memregion(IORES_DESC_CXL);
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-10 22:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-09 16:52 [PATCH v5 0/2] Fixing check patch styling issues Raghu Halharvi
2023-05-09 16:52 ` [PATCH v5 1/2] cxl/mbox: Remove redundant dev_err() after failed mem alloc Raghu Halharvi
2023-05-10 22:01 ` Ira Weiny
2023-05-09 16:52 ` [PATCH v5 2/2] cxl/region: Remove else after return statement Raghu Halharvi
2023-05-10 22:02 ` Ira Weiny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).