* [PATCH] media: stm32: dcmi: replace "%p" with "%pK"
@ 2018-07-06 13:03 Benjamin Gaignard
2018-07-06 13:51 ` Hans Verkuil
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Gaignard @ 2018-07-06 13:03 UTC (permalink / raw)
To: mchehab, mcoquelin.stm32, alexandre.torgue, hans.verkuil, hugues.fruchet
Cc: linux-media, linux-arm-kernel, linux-kernel, Benjamin Gaignard
The format specifier "%p" can leak kernel addresses.
Use "%pK" instead.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
drivers/media/platform/stm32/stm32-dcmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
index 2e1933d872ee..fe90672cf16f 100644
--- a/drivers/media/platform/stm32/stm32-dcmi.c
+++ b/drivers/media/platform/stm32/stm32-dcmi.c
@@ -1753,7 +1753,7 @@ static int dcmi_probe(struct platform_device *pdev)
ret = clk_prepare(mclk);
if (ret) {
- dev_err(&pdev->dev, "Unable to prepare mclk %p\n", mclk);
+ dev_err(&pdev->dev, "Unable to prepare mclk %pK\n", mclk);
goto err_dma_release;
}
--
2.15.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: stm32: dcmi: replace "%p" with "%pK"
2018-07-06 13:03 [PATCH] media: stm32: dcmi: replace "%p" with "%pK" Benjamin Gaignard
@ 2018-07-06 13:51 ` Hans Verkuil
0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2018-07-06 13:51 UTC (permalink / raw)
To: Benjamin Gaignard, mchehab, mcoquelin.stm32, alexandre.torgue,
hans.verkuil, hugues.fruchet
Cc: linux-media, linux-arm-kernel, linux-kernel, Benjamin Gaignard
On 06/07/18 15:03, Benjamin Gaignard wrote:
> The format specifier "%p" can leak kernel addresses.
> Use "%pK" instead.
This patch no longer applies. AFAICT it is obsolete after some code reorg.
Regards,
Hans
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
> drivers/media/platform/stm32/stm32-dcmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
> index 2e1933d872ee..fe90672cf16f 100644
> --- a/drivers/media/platform/stm32/stm32-dcmi.c
> +++ b/drivers/media/platform/stm32/stm32-dcmi.c
> @@ -1753,7 +1753,7 @@ static int dcmi_probe(struct platform_device *pdev)
>
> ret = clk_prepare(mclk);
> if (ret) {
> - dev_err(&pdev->dev, "Unable to prepare mclk %p\n", mclk);
> + dev_err(&pdev->dev, "Unable to prepare mclk %pK\n", mclk);
> goto err_dma_release;
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-06 13:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-06 13:03 [PATCH] media: stm32: dcmi: replace "%p" with "%pK" Benjamin Gaignard
2018-07-06 13:51 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).