* [PATCH 1/2] drivers/irqchip: Fixup csky,mpintc compile error with CPU_CK610
@ 2021-02-03 13:48 guoren
2021-02-03 13:48 ` [PATCH 2/2] drivers/clocksource: " guoren
2021-02-03 15:44 ` [PATCH 1/2] drivers/irqchip: " Marc Zyngier
0 siblings, 2 replies; 4+ messages in thread
From: guoren @ 2021-02-03 13:48 UTC (permalink / raw)
To: guoren; +Cc: linux-kernel, linux-csky, Guo Ren, Marc Zyngier
From: Guo Ren <guoren@linux.alibaba.com>
The irq-csky-mpintc.c only could support CPU_CK860 and it will
compile error with CPU_CK610.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Cc: Marc Zyngier <maz@kernel.org>
---
drivers/irqchip/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index b147f22a78f4..9be2dd5c6380 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -433,7 +433,7 @@ config QCOM_PDC
config CSKY_MPINTC
bool "C-SKY Multi Processor Interrupt Controller"
- depends on CSKY
+ depends on CSKY && CPU_CK860
help
Say yes here to enable C-SKY SMP interrupt controller driver used
for C-SKY SMP system.
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] drivers/clocksource: Fixup csky,mpintc compile error with CPU_CK610
2021-02-03 13:48 [PATCH 1/2] drivers/irqchip: Fixup csky,mpintc compile error with CPU_CK610 guoren
@ 2021-02-03 13:48 ` guoren
2021-02-03 15:44 ` [PATCH 1/2] drivers/irqchip: " Marc Zyngier
1 sibling, 0 replies; 4+ messages in thread
From: guoren @ 2021-02-03 13:48 UTC (permalink / raw)
To: guoren; +Cc: linux-kernel, linux-csky, Guo Ren, Daniel Lezcano, Thomas Gleixner
From: Guo Ren <guoren@linux.alibaba.com>
The timer-mp-csky.c only could support CPU_CK860 and it will
compile error with CPU_CK610.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
---
drivers/clocksource/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 14c7c4712478..f773ecacb5f9 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -663,7 +663,7 @@ config CLINT_TIMER
config CSKY_MP_TIMER
bool "SMP Timer for the C-SKY platform" if COMPILE_TEST
- depends on CSKY
+ depends on CSKY && CPU_CK860
select TIMER_OF
help
Say yes here to enable C-SKY SMP timer driver used for C-SKY SMP
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] drivers/irqchip: Fixup csky,mpintc compile error with CPU_CK610
2021-02-03 13:48 [PATCH 1/2] drivers/irqchip: Fixup csky,mpintc compile error with CPU_CK610 guoren
2021-02-03 13:48 ` [PATCH 2/2] drivers/clocksource: " guoren
@ 2021-02-03 15:44 ` Marc Zyngier
2021-02-04 4:32 ` Guo Ren
1 sibling, 1 reply; 4+ messages in thread
From: Marc Zyngier @ 2021-02-03 15:44 UTC (permalink / raw)
To: guoren; +Cc: linux-kernel, linux-csky, Guo Ren
On 2021-02-03 13:48, guoren@kernel.org wrote:
> From: Guo Ren <guoren@linux.alibaba.com>
>
> The irq-csky-mpintc.c only could support CPU_CK860 and it will
> compile error with CPU_CK610.
>
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> Cc: Marc Zyngier <maz@kernel.org>
> ---
> drivers/irqchip/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index b147f22a78f4..9be2dd5c6380 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -433,7 +433,7 @@ config QCOM_PDC
>
> config CSKY_MPINTC
> bool "C-SKY Multi Processor Interrupt Controller"
> - depends on CSKY
> + depends on CSKY && CPU_CK860
> help
> Say yes here to enable C-SKY SMP interrupt controller driver used
> for C-SKY SMP system.
I'm not convinced this is the right fix.
You already select CSKY_MPINTC only when CPU_CK860 is selected,
so preventing the user from selecting it should simply be a matter
of dropping the string after bool.
Thanks,
M.
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 94920a51c628..2e7b562bbaac 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -432,7 +432,7 @@ config QCOM_PDC
IRQs for Qualcomm Technologies Inc (QTI) mobile chips.
config CSKY_MPINTC
- bool "C-SKY Multi Processor Interrupt Controller"
+ bool
depends on CSKY
help
Say yes here to enable C-SKY SMP interrupt controller driver used
--
Jazz is not dead. It just smells funny...
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] drivers/irqchip: Fixup csky,mpintc compile error with CPU_CK610
2021-02-03 15:44 ` [PATCH 1/2] drivers/irqchip: " Marc Zyngier
@ 2021-02-04 4:32 ` Guo Ren
0 siblings, 0 replies; 4+ messages in thread
From: Guo Ren @ 2021-02-04 4:32 UTC (permalink / raw)
To: Marc Zyngier; +Cc: Linux Kernel Mailing List, linux-csky, Guo Ren
Thx Marc,
On Wed, Feb 3, 2021 at 11:44 PM Marc Zyngier <maz@kernel.org> wrote:
>
> On 2021-02-03 13:48, guoren@kernel.org wrote:
> > From: Guo Ren <guoren@linux.alibaba.com>
> >
> > The irq-csky-mpintc.c only could support CPU_CK860 and it will
> > compile error with CPU_CK610.
> >
> > Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> > Cc: Marc Zyngier <maz@kernel.org>
> > ---
> > drivers/irqchip/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> > index b147f22a78f4..9be2dd5c6380 100644
> > --- a/drivers/irqchip/Kconfig
> > +++ b/drivers/irqchip/Kconfig
> > @@ -433,7 +433,7 @@ config QCOM_PDC
> >
> > config CSKY_MPINTC
> > bool "C-SKY Multi Processor Interrupt Controller"
> > - depends on CSKY
> > + depends on CSKY && CPU_CK860
> > help
> > Say yes here to enable C-SKY SMP interrupt controller driver used
> > for C-SKY SMP system.
>
> I'm not convinced this is the right fix.
>
> You already select CSKY_MPINTC only when CPU_CK860 is selected,
> so preventing the user from selecting it should simply be a matter
> of dropping the string after bool.
Yes, you are right. I will change it into arch/csky.
--
Best Regards
Guo Ren
ML: https://lore.kernel.org/linux-csky/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-04 4:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03 13:48 [PATCH 1/2] drivers/irqchip: Fixup csky,mpintc compile error with CPU_CK610 guoren
2021-02-03 13:48 ` [PATCH 2/2] drivers/clocksource: " guoren
2021-02-03 15:44 ` [PATCH 1/2] drivers/irqchip: " Marc Zyngier
2021-02-04 4:32 ` Guo Ren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).