* [PATCH 0/7] staging: media: zoran: Eliminate camelcase
@ 2021-04-03 18:08 Zhansaya Bagdauletkyzy
2021-04-03 18:08 ` [PATCH 1/7] staging: media: zoran: Rename 'HEnd' to 'h_end' Zhansaya Bagdauletkyzy
` (8 more replies)
0 siblings, 9 replies; 10+ messages in thread
From: Zhansaya Bagdauletkyzy @ 2021-04-03 18:08 UTC (permalink / raw)
To: clabbe, mchehab, gregkh
Cc: linux-media, linux-staging, linux-kernel, outreachy-kernel
This patchset fixes 'avoid camelcase' warning by converting local variables to lowercase and separating words using '_'.
Renaming of each variable is implemented in separate patches.
Zhansaya Bagdauletkyzy (7):
Rename 'HEnd' to 'h_end'
Rename 'VEnd' to 'v_end'
Rename 'DispMode' to 'disp_mode'
Rename 'VidWinWid' to 'vid_win_wid'
Rename 'VidWinHt' to 'vid_win_ht'
Rename 'We' to 'we'
Rename 'He' to 'he'
drivers/staging/media/zoran/zoran_device.c | 48 +++++++++++-----------
1 file changed, 24 insertions(+), 24 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/7] staging: media: zoran: Rename 'HEnd' to 'h_end'
2021-04-03 18:08 [PATCH 0/7] staging: media: zoran: Eliminate camelcase Zhansaya Bagdauletkyzy
@ 2021-04-03 18:08 ` Zhansaya Bagdauletkyzy
2021-04-03 18:09 ` [PATCH 2/7] staging: media: zoran: Rename 'VEnd' to 'v_end' Zhansaya Bagdauletkyzy
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Zhansaya Bagdauletkyzy @ 2021-04-03 18:08 UTC (permalink / raw)
To: clabbe, mchehab, gregkh
Cc: linux-media, linux-staging, linux-kernel, outreachy-kernel
Rename variable 'HEnd' to 'h_end' to eliminate camelcase
Reported by checkpatch.pl.
Signed-off-by: Zhansaya Bagdauletkyzy <zhansayabagdaulet@gmail.com>
---
drivers/staging/media/zoran/zoran_device.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_device.c b/drivers/staging/media/zoran/zoran_device.c
index e569a1341d01..415b3cf4826e 100644
--- a/drivers/staging/media/zoran/zoran_device.c
+++ b/drivers/staging/media/zoran/zoran_device.c
@@ -291,7 +291,7 @@ static void zr36057_set_vfe(struct zoran *zr, int video_width, int video_height,
const struct zoran_format *format)
{
const struct tvnorm *tvn;
- unsigned int h_start, HEnd, v_start, VEnd;
+ unsigned int h_start, h_end, v_start, VEnd;
unsigned int DispMode;
unsigned int VidWinWid, VidWinHt;
unsigned int hcrop1, hcrop2, vcrop1, vcrop2;
@@ -331,11 +331,11 @@ static void zr36057_set_vfe(struct zoran *zr, int video_width, int video_height,
* However, the DC10 has '0' as h_start, but does need |1, so we
* use a dirty check...
*/
- HEnd = h_start + tvn->wa - 1;
+ h_end = h_start + tvn->wa - 1;
h_start += hcrop1;
- HEnd -= hcrop2;
+ h_end -= hcrop2;
reg = ((h_start & ZR36057_VFEHCR_HMASK) << ZR36057_VFEHCR_H_START)
- | ((HEnd & ZR36057_VFEHCR_HMASK) << ZR36057_VFEHCR_H_END);
+ | ((h_end & ZR36057_VFEHCR_HMASK) << ZR36057_VFEHCR_H_END);
if (zr->card.vfe_pol.hsync_pol)
reg |= ZR36057_VFEHCR_HS_POL;
btwrite(reg, ZR36057_VFEHCR);
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/7] staging: media: zoran: Rename 'VEnd' to 'v_end'
2021-04-03 18:08 [PATCH 0/7] staging: media: zoran: Eliminate camelcase Zhansaya Bagdauletkyzy
2021-04-03 18:08 ` [PATCH 1/7] staging: media: zoran: Rename 'HEnd' to 'h_end' Zhansaya Bagdauletkyzy
@ 2021-04-03 18:09 ` Zhansaya Bagdauletkyzy
2021-04-03 18:09 ` [PATCH 3/7] staging: media: zoran: Rename 'DispMode' to 'disp_mode' Zhansaya Bagdauletkyzy
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Zhansaya Bagdauletkyzy @ 2021-04-03 18:09 UTC (permalink / raw)
To: clabbe, mchehab, gregkh
Cc: linux-media, linux-staging, linux-kernel, outreachy-kernel
Rename variable 'VEnd' to 'v_end' to eliminate camelcase.
Reported by checkpatch.pl.
Signed-off-by: Zhansaya Bagdauletkyzy <zhansayabagdaulet@gmail.com>
---
drivers/staging/media/zoran/zoran_device.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_device.c b/drivers/staging/media/zoran/zoran_device.c
index 415b3cf4826e..6764b51fc595 100644
--- a/drivers/staging/media/zoran/zoran_device.c
+++ b/drivers/staging/media/zoran/zoran_device.c
@@ -291,7 +291,7 @@ static void zr36057_set_vfe(struct zoran *zr, int video_width, int video_height,
const struct zoran_format *format)
{
const struct tvnorm *tvn;
- unsigned int h_start, h_end, v_start, VEnd;
+ unsigned int h_start, h_end, v_start, v_end;
unsigned int DispMode;
unsigned int VidWinWid, VidWinHt;
unsigned int hcrop1, hcrop2, vcrop1, vcrop2;
@@ -349,11 +349,11 @@ static void zr36057_set_vfe(struct zoran *zr, int video_width, int video_height,
vcrop1 = (tvn->ha / 2 - He) / 2;
vcrop2 = tvn->ha / 2 - He - vcrop1;
v_start = tvn->v_start;
- VEnd = v_start + tvn->ha / 2; // - 1; FIXME SnapShot times out with -1 in 768*576 on the DC10 - LP
+ v_end = v_start + tvn->ha / 2; // - 1; FIXME SnapShot times out with -1 in 768*576 on the DC10 - LP
v_start += vcrop1;
- VEnd -= vcrop2;
+ v_end -= vcrop2;
reg = ((v_start & ZR36057_VFEVCR_VMASK) << ZR36057_VFEVCR_V_START)
- | ((VEnd & ZR36057_VFEVCR_VMASK) << ZR36057_VFEVCR_V_END);
+ | ((v_end & ZR36057_VFEVCR_VMASK) << ZR36057_VFEVCR_V_END);
if (zr->card.vfe_pol.vsync_pol)
reg |= ZR36057_VFEVCR_VS_POL;
btwrite(reg, ZR36057_VFEVCR);
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/7] staging: media: zoran: Rename 'DispMode' to 'disp_mode'
2021-04-03 18:08 [PATCH 0/7] staging: media: zoran: Eliminate camelcase Zhansaya Bagdauletkyzy
2021-04-03 18:08 ` [PATCH 1/7] staging: media: zoran: Rename 'HEnd' to 'h_end' Zhansaya Bagdauletkyzy
2021-04-03 18:09 ` [PATCH 2/7] staging: media: zoran: Rename 'VEnd' to 'v_end' Zhansaya Bagdauletkyzy
@ 2021-04-03 18:09 ` Zhansaya Bagdauletkyzy
2021-04-03 18:09 ` [PATCH 4/7] staging: media: zoran: Rename 'VidWinWid' to 'vid_win_wid' Zhansaya Bagdauletkyzy
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Zhansaya Bagdauletkyzy @ 2021-04-03 18:09 UTC (permalink / raw)
To: clabbe, mchehab, gregkh
Cc: linux-media, linux-staging, linux-kernel, outreachy-kernel
Rename variable 'DispMode' to 'disp_mode' to eliminate camelcase.
Reported by checkpatch.pl.
Signed-off-by: Zhansaya Bagdauletkyzy <zhansayabagdaulet@gmail.com>
---
drivers/staging/media/zoran/zoran_device.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_device.c b/drivers/staging/media/zoran/zoran_device.c
index 6764b51fc595..8891f11f6276 100644
--- a/drivers/staging/media/zoran/zoran_device.c
+++ b/drivers/staging/media/zoran/zoran_device.c
@@ -292,7 +292,7 @@ static void zr36057_set_vfe(struct zoran *zr, int video_width, int video_height,
{
const struct tvnorm *tvn;
unsigned int h_start, h_end, v_start, v_end;
- unsigned int DispMode;
+ unsigned int disp_mode;
unsigned int VidWinWid, VidWinHt;
unsigned int hcrop1, hcrop2, vcrop1, vcrop2;
unsigned int wa, We, ha, He;
@@ -341,8 +341,8 @@ static void zr36057_set_vfe(struct zoran *zr, int video_width, int video_height,
btwrite(reg, ZR36057_VFEHCR);
/* Vertical */
- DispMode = !(video_height > BUZ_MAX_HEIGHT / 2);
- VidWinHt = DispMode ? video_height : video_height / 2;
+ disp_mode = !(video_height > BUZ_MAX_HEIGHT / 2);
+ VidWinHt = disp_mode ? video_height : video_height / 2;
Y = DIV_ROUND_UP(VidWinHt * 64 * 2, tvn->ha);
He = (VidWinHt * 64) / Y;
ver_dcm = 64 - Y;
@@ -362,7 +362,7 @@ static void zr36057_set_vfe(struct zoran *zr, int video_width, int video_height,
reg = 0;
reg |= (hor_dcm << ZR36057_VFESPFR_HOR_DCM);
reg |= (ver_dcm << ZR36057_VFESPFR_VER_DCM);
- reg |= (DispMode << ZR36057_VFESPFR_DISP_MODE);
+ reg |= (disp_mode << ZR36057_VFESPFR_DISP_MODE);
/* RJ: I don't know, why the following has to be the opposite
* of the corresponding ZR36060 setting, but only this way
* we get the correct colors when uncompressing to the screen */
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 4/7] staging: media: zoran: Rename 'VidWinWid' to 'vid_win_wid'
2021-04-03 18:08 [PATCH 0/7] staging: media: zoran: Eliminate camelcase Zhansaya Bagdauletkyzy
` (2 preceding siblings ...)
2021-04-03 18:09 ` [PATCH 3/7] staging: media: zoran: Rename 'DispMode' to 'disp_mode' Zhansaya Bagdauletkyzy
@ 2021-04-03 18:09 ` Zhansaya Bagdauletkyzy
2021-04-03 18:09 ` [PATCH 5/7] staging: media: zoran: Rename 'VidWinHt' to 'vid_win_ht' Zhansaya Bagdauletkyzy
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Zhansaya Bagdauletkyzy @ 2021-04-03 18:09 UTC (permalink / raw)
To: clabbe, mchehab, gregkh
Cc: linux-media, linux-staging, linux-kernel, outreachy-kernel
Rename variable 'VidWinWid' to 'vid_win_wid' to eliminate camelcase.
Reported by checkpatch.pl.
Signed-off-by: Zhansaya Bagdauletkyzy <zhansayabagdaulet@gmail.com>
---
drivers/staging/media/zoran/zoran_device.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_device.c b/drivers/staging/media/zoran/zoran_device.c
index 8891f11f6276..f0344f4a4727 100644
--- a/drivers/staging/media/zoran/zoran_device.c
+++ b/drivers/staging/media/zoran/zoran_device.c
@@ -293,7 +293,7 @@ static void zr36057_set_vfe(struct zoran *zr, int video_width, int video_height,
const struct tvnorm *tvn;
unsigned int h_start, h_end, v_start, v_end;
unsigned int disp_mode;
- unsigned int VidWinWid, VidWinHt;
+ unsigned int vid_win_wid, VidWinHt;
unsigned int hcrop1, hcrop2, vcrop1, vcrop2;
unsigned int wa, We, ha, He;
unsigned int X, Y, hor_dcm, ver_dcm;
@@ -316,9 +316,9 @@ static void zr36057_set_vfe(struct zoran *zr, int video_width, int video_height,
/**** zr36057 ****/
/* horizontal */
- VidWinWid = video_width;
- X = DIV_ROUND_UP(VidWinWid * 64, tvn->wa);
- We = (VidWinWid * 64) / X;
+ vid_win_wid = video_width;
+ X = DIV_ROUND_UP(vid_win_wid * 64, tvn->wa);
+ We = (vid_win_wid * 64) / X;
hor_dcm = 64 - X;
hcrop1 = 2 * ((tvn->wa - We) / 4);
hcrop2 = tvn->wa - We - hcrop1;
@@ -384,7 +384,7 @@ static void zr36057_set_vfe(struct zoran *zr, int video_width, int video_height,
/* display configuration */
reg = (16 << ZR36057_VDCR_MIN_PIX)
| (VidWinHt << ZR36057_VDCR_VID_WIN_HT)
- | (VidWinWid << ZR36057_VDCR_VID_WIN_WID);
+ | (vid_win_wid << ZR36057_VDCR_VID_WIN_WID);
if (pci_pci_problems & PCIPCI_TRITON)
// || zr->revision < 1) // Revision 1 has also Triton support
reg &= ~ZR36057_VDCR_TRITON;
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 5/7] staging: media: zoran: Rename 'VidWinHt' to 'vid_win_ht'
2021-04-03 18:08 [PATCH 0/7] staging: media: zoran: Eliminate camelcase Zhansaya Bagdauletkyzy
` (3 preceding siblings ...)
2021-04-03 18:09 ` [PATCH 4/7] staging: media: zoran: Rename 'VidWinWid' to 'vid_win_wid' Zhansaya Bagdauletkyzy
@ 2021-04-03 18:09 ` Zhansaya Bagdauletkyzy
2021-04-03 18:09 ` [PATCH 6/7] staging: media: zoran: Rename 'We' to 'we' Zhansaya Bagdauletkyzy
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Zhansaya Bagdauletkyzy @ 2021-04-03 18:09 UTC (permalink / raw)
To: clabbe, mchehab, gregkh
Cc: linux-media, linux-staging, linux-kernel, outreachy-kernel
Rename 'VidWinHt' to 'vid_win_ht' to eliminate camelcase.
Reported by checkpatch.pl.
Signed-off-by: Zhansaya Bagdauletkyzy <zhansayabagdaulet@gmail.com>
---
drivers/staging/media/zoran/zoran_device.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_device.c b/drivers/staging/media/zoran/zoran_device.c
index f0344f4a4727..49e0efcc0062 100644
--- a/drivers/staging/media/zoran/zoran_device.c
+++ b/drivers/staging/media/zoran/zoran_device.c
@@ -293,7 +293,7 @@ static void zr36057_set_vfe(struct zoran *zr, int video_width, int video_height,
const struct tvnorm *tvn;
unsigned int h_start, h_end, v_start, v_end;
unsigned int disp_mode;
- unsigned int vid_win_wid, VidWinHt;
+ unsigned int vid_win_wid, vid_win_ht;
unsigned int hcrop1, hcrop2, vcrop1, vcrop2;
unsigned int wa, We, ha, He;
unsigned int X, Y, hor_dcm, ver_dcm;
@@ -342,9 +342,9 @@ static void zr36057_set_vfe(struct zoran *zr, int video_width, int video_height,
/* Vertical */
disp_mode = !(video_height > BUZ_MAX_HEIGHT / 2);
- VidWinHt = disp_mode ? video_height : video_height / 2;
- Y = DIV_ROUND_UP(VidWinHt * 64 * 2, tvn->ha);
- He = (VidWinHt * 64) / Y;
+ vid_win_ht = disp_mode ? video_height : video_height / 2;
+ Y = DIV_ROUND_UP(vid_win_ht * 64 * 2, tvn->ha);
+ He = (vid_win_ht * 64) / Y;
ver_dcm = 64 - Y;
vcrop1 = (tvn->ha / 2 - He) / 2;
vcrop2 = tvn->ha / 2 - He - vcrop1;
@@ -383,7 +383,7 @@ static void zr36057_set_vfe(struct zoran *zr, int video_width, int video_height,
/* display configuration */
reg = (16 << ZR36057_VDCR_MIN_PIX)
- | (VidWinHt << ZR36057_VDCR_VID_WIN_HT)
+ | (vid_win_ht << ZR36057_VDCR_VID_WIN_HT)
| (vid_win_wid << ZR36057_VDCR_VID_WIN_WID);
if (pci_pci_problems & PCIPCI_TRITON)
// || zr->revision < 1) // Revision 1 has also Triton support
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 6/7] staging: media: zoran: Rename 'We' to 'we'
2021-04-03 18:08 [PATCH 0/7] staging: media: zoran: Eliminate camelcase Zhansaya Bagdauletkyzy
` (4 preceding siblings ...)
2021-04-03 18:09 ` [PATCH 5/7] staging: media: zoran: Rename 'VidWinHt' to 'vid_win_ht' Zhansaya Bagdauletkyzy
@ 2021-04-03 18:09 ` Zhansaya Bagdauletkyzy
2021-04-03 18:09 ` [PATCH 7/7] staging: media: zoran: Rename 'He' to 'he' Zhansaya Bagdauletkyzy
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Zhansaya Bagdauletkyzy @ 2021-04-03 18:09 UTC (permalink / raw)
To: clabbe, mchehab, gregkh
Cc: linux-media, linux-staging, linux-kernel, outreachy-kernel
Rename variable 'We' to 'we' to eliminate camelcase.
Reported by checkpatch.pl.
Signed-off-by: Zhansaya Bagdauletkyzy <zhansayabagdaulet@gmail.com>
---
drivers/staging/media/zoran/zoran_device.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_device.c b/drivers/staging/media/zoran/zoran_device.c
index 49e0efcc0062..007d8855178e 100644
--- a/drivers/staging/media/zoran/zoran_device.c
+++ b/drivers/staging/media/zoran/zoran_device.c
@@ -295,7 +295,7 @@ static void zr36057_set_vfe(struct zoran *zr, int video_width, int video_height,
unsigned int disp_mode;
unsigned int vid_win_wid, vid_win_ht;
unsigned int hcrop1, hcrop2, vcrop1, vcrop2;
- unsigned int wa, We, ha, He;
+ unsigned int wa, we, ha, He;
unsigned int X, Y, hor_dcm, ver_dcm;
u32 reg;
@@ -318,10 +318,10 @@ static void zr36057_set_vfe(struct zoran *zr, int video_width, int video_height,
/* horizontal */
vid_win_wid = video_width;
X = DIV_ROUND_UP(vid_win_wid * 64, tvn->wa);
- We = (vid_win_wid * 64) / X;
+ we = (vid_win_wid * 64) / X;
hor_dcm = 64 - X;
- hcrop1 = 2 * ((tvn->wa - We) / 4);
- hcrop2 = tvn->wa - We - hcrop1;
+ hcrop1 = 2 * ((tvn->wa - we) / 4);
+ hcrop2 = tvn->wa - we - hcrop1;
h_start = tvn->h_start ? tvn->h_start : 1;
/* (Ronald) Original comment:
* "| 1 Doesn't have any effect, tested on both a DC10 and a DC10+"
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 7/7] staging: media: zoran: Rename 'He' to 'he'
2021-04-03 18:08 [PATCH 0/7] staging: media: zoran: Eliminate camelcase Zhansaya Bagdauletkyzy
` (5 preceding siblings ...)
2021-04-03 18:09 ` [PATCH 6/7] staging: media: zoran: Rename 'We' to 'we' Zhansaya Bagdauletkyzy
@ 2021-04-03 18:09 ` Zhansaya Bagdauletkyzy
2021-04-04 9:55 ` [PATCH 0/7] staging: media: zoran: Eliminate camelcase Greg KH
2021-04-07 15:27 ` Hans Verkuil
8 siblings, 0 replies; 10+ messages in thread
From: Zhansaya Bagdauletkyzy @ 2021-04-03 18:09 UTC (permalink / raw)
To: clabbe, mchehab, gregkh
Cc: linux-media, linux-staging, linux-kernel, outreachy-kernel
Rename variable 'He' to 'he' to eliminate camelcase.
Reported by checkpatch.pl.
Signed-off-by: Zhansaya Bagdauletkyzy <zhansayabagdaulet@gmail.com>
---
drivers/staging/media/zoran/zoran_device.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_device.c b/drivers/staging/media/zoran/zoran_device.c
index 007d8855178e..cf788d9cd1df 100644
--- a/drivers/staging/media/zoran/zoran_device.c
+++ b/drivers/staging/media/zoran/zoran_device.c
@@ -295,7 +295,7 @@ static void zr36057_set_vfe(struct zoran *zr, int video_width, int video_height,
unsigned int disp_mode;
unsigned int vid_win_wid, vid_win_ht;
unsigned int hcrop1, hcrop2, vcrop1, vcrop2;
- unsigned int wa, we, ha, He;
+ unsigned int wa, we, ha, he;
unsigned int X, Y, hor_dcm, ver_dcm;
u32 reg;
@@ -344,10 +344,10 @@ static void zr36057_set_vfe(struct zoran *zr, int video_width, int video_height,
disp_mode = !(video_height > BUZ_MAX_HEIGHT / 2);
vid_win_ht = disp_mode ? video_height : video_height / 2;
Y = DIV_ROUND_UP(vid_win_ht * 64 * 2, tvn->ha);
- He = (vid_win_ht * 64) / Y;
+ he = (vid_win_ht * 64) / Y;
ver_dcm = 64 - Y;
- vcrop1 = (tvn->ha / 2 - He) / 2;
- vcrop2 = tvn->ha / 2 - He - vcrop1;
+ vcrop1 = (tvn->ha / 2 - he) / 2;
+ vcrop2 = tvn->ha / 2 - he - vcrop1;
v_start = tvn->v_start;
v_end = v_start + tvn->ha / 2; // - 1; FIXME SnapShot times out with -1 in 768*576 on the DC10 - LP
v_start += vcrop1;
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 0/7] staging: media: zoran: Eliminate camelcase
2021-04-03 18:08 [PATCH 0/7] staging: media: zoran: Eliminate camelcase Zhansaya Bagdauletkyzy
` (6 preceding siblings ...)
2021-04-03 18:09 ` [PATCH 7/7] staging: media: zoran: Rename 'He' to 'he' Zhansaya Bagdauletkyzy
@ 2021-04-04 9:55 ` Greg KH
2021-04-07 15:27 ` Hans Verkuil
8 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2021-04-04 9:55 UTC (permalink / raw)
To: Zhansaya Bagdauletkyzy
Cc: clabbe, mchehab, linux-media, linux-staging, linux-kernel,
outreachy-kernel
On Sun, Apr 04, 2021 at 12:08:57AM +0600, Zhansaya Bagdauletkyzy wrote:
> This patchset fixes 'avoid camelcase' warning by converting local variables to lowercase and separating words using '_'.
> Renaming of each variable is implemented in separate patches.
>
> Zhansaya Bagdauletkyzy (7):
> Rename 'HEnd' to 'h_end'
> Rename 'VEnd' to 'v_end'
> Rename 'DispMode' to 'disp_mode'
> Rename 'VidWinWid' to 'vid_win_wid'
> Rename 'VidWinHt' to 'vid_win_ht'
> Rename 'We' to 'we'
> Rename 'He' to 'he'
>
> drivers/staging/media/zoran/zoran_device.c | 48 +++++++++++-----------
> 1 file changed, 24 insertions(+), 24 deletions(-)
You did not read the instructions for the outreachy work, sorry, but I
can not take these.
good luck!
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/7] staging: media: zoran: Eliminate camelcase
2021-04-03 18:08 [PATCH 0/7] staging: media: zoran: Eliminate camelcase Zhansaya Bagdauletkyzy
` (7 preceding siblings ...)
2021-04-04 9:55 ` [PATCH 0/7] staging: media: zoran: Eliminate camelcase Greg KH
@ 2021-04-07 15:27 ` Hans Verkuil
8 siblings, 0 replies; 10+ messages in thread
From: Hans Verkuil @ 2021-04-07 15:27 UTC (permalink / raw)
To: Zhansaya Bagdauletkyzy, clabbe, mchehab, gregkh
Cc: linux-media, linux-staging, linux-kernel, outreachy-kernel
Hi Zhansaya,
On 03/04/2021 20:08, Zhansaya Bagdauletkyzy wrote:
> This patchset fixes 'avoid camelcase' warning by converting local variables to lowercase and separating words using '_'.
> Renaming of each variable is implemented in separate patches.
>
> Zhansaya Bagdauletkyzy (7):
> Rename 'HEnd' to 'h_end'
> Rename 'VEnd' to 'v_end'
> Rename 'DispMode' to 'disp_mode'
> Rename 'VidWinWid' to 'vid_win_wid'
> Rename 'VidWinHt' to 'vid_win_ht'
> Rename 'We' to 'we'
> Rename 'He' to 'he'
>
> drivers/staging/media/zoran/zoran_device.c | 48 +++++++++++-----------
> 1 file changed, 24 insertions(+), 24 deletions(-)
>
Looks good. I'll take these patches.
You can use this reference to record your contributions:
https://patchwork.linuxtv.org/project/linux-media/list/?series=5052
The patch states will change to Accepted once it is merged in our media tree
here: https://git.linuxtv.org/media_tree.git/log/
I hate CamelCase, so this is a nice cleanup :-)
Regards,
Hans
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-04-07 15:27 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-03 18:08 [PATCH 0/7] staging: media: zoran: Eliminate camelcase Zhansaya Bagdauletkyzy
2021-04-03 18:08 ` [PATCH 1/7] staging: media: zoran: Rename 'HEnd' to 'h_end' Zhansaya Bagdauletkyzy
2021-04-03 18:09 ` [PATCH 2/7] staging: media: zoran: Rename 'VEnd' to 'v_end' Zhansaya Bagdauletkyzy
2021-04-03 18:09 ` [PATCH 3/7] staging: media: zoran: Rename 'DispMode' to 'disp_mode' Zhansaya Bagdauletkyzy
2021-04-03 18:09 ` [PATCH 4/7] staging: media: zoran: Rename 'VidWinWid' to 'vid_win_wid' Zhansaya Bagdauletkyzy
2021-04-03 18:09 ` [PATCH 5/7] staging: media: zoran: Rename 'VidWinHt' to 'vid_win_ht' Zhansaya Bagdauletkyzy
2021-04-03 18:09 ` [PATCH 6/7] staging: media: zoran: Rename 'We' to 'we' Zhansaya Bagdauletkyzy
2021-04-03 18:09 ` [PATCH 7/7] staging: media: zoran: Rename 'He' to 'he' Zhansaya Bagdauletkyzy
2021-04-04 9:55 ` [PATCH 0/7] staging: media: zoran: Eliminate camelcase Greg KH
2021-04-07 15:27 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).