linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/msm: fix repeated words in comments
@ 2022-08-23 11:54 Jilin Yuan
  2022-08-26  9:43 ` Dmitry Baryshkov
  0 siblings, 1 reply; 3+ messages in thread
From: Jilin Yuan @ 2022-08-23 11:54 UTC (permalink / raw)
  To: robdclark, quic_abhinavk, dmitry.baryshkov, airlied, daniel
  Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, Jilin Yuan

 Delete the redundant word 'one'.

Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
 drivers/gpu/drm/msm/msm_gem.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h
index c75d3b879a53..e300c70e8904 100644
--- a/drivers/gpu/drm/msm/msm_gem.h
+++ b/drivers/gpu/drm/msm/msm_gem.h
@@ -118,7 +118,7 @@ struct msm_gem_object {
 	 * An object is either:
 	 *  inactive - on priv->inactive_dontneed or priv->inactive_willneed
 	 *     (depending on purgeability status)
-	 *  active   - on one one of the gpu's active_list..  well, at
+	 *  active   - on one of the gpu's active_list..  well, at
 	 *     least for now we don't have (I don't think) hw sync between
 	 *     2d and 3d one devices which have both, meaning we need to
 	 *     block on submit if a bo is already on other ring
-- 
2.36.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/msm: fix repeated words in comments
  2022-08-23 11:54 [PATCH] drm/msm: fix repeated words in comments Jilin Yuan
@ 2022-08-26  9:43 ` Dmitry Baryshkov
  2022-08-27 16:42   ` Rob Clark
  0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Baryshkov @ 2022-08-26  9:43 UTC (permalink / raw)
  To: Jilin Yuan, robdclark, quic_abhinavk, airlied, daniel
  Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel

On 23/08/2022 14:54, Jilin Yuan wrote:
>   Delete the redundant word 'one'.

The whitespace is unnecessary.

> 
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Fixes: 7198e6b03155 ("drm/msm: add a3xx gpu support")


> ---
>   drivers/gpu/drm/msm/msm_gem.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h
> index c75d3b879a53..e300c70e8904 100644
> --- a/drivers/gpu/drm/msm/msm_gem.h
> +++ b/drivers/gpu/drm/msm/msm_gem.h
> @@ -118,7 +118,7 @@ struct msm_gem_object {
>   	 * An object is either:
>   	 *  inactive - on priv->inactive_dontneed or priv->inactive_willneed
>   	 *     (depending on purgeability status)
> -	 *  active   - on one one of the gpu's active_list..  well, at
> +	 *  active   - on one of the gpu's active_list..  well, at
>   	 *     least for now we don't have (I don't think) hw sync between
>   	 *     2d and 3d one devices which have both, meaning we need to
>   	 *     block on submit if a bo is already on other ring

-- 
With best wishes
Dmitry


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/msm: fix repeated words in comments
  2022-08-26  9:43 ` Dmitry Baryshkov
@ 2022-08-27 16:42   ` Rob Clark
  0 siblings, 0 replies; 3+ messages in thread
From: Rob Clark @ 2022-08-27 16:42 UTC (permalink / raw)
  To: Dmitry Baryshkov
  Cc: Jilin Yuan, quic_abhinavk, airlied, daniel, linux-arm-msm,
	dri-devel, freedreno, linux-kernel

On Fri, Aug 26, 2022 at 2:43 AM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> On 23/08/2022 14:54, Jilin Yuan wrote:
> >   Delete the redundant word 'one'.
>
> The whitespace is unnecessary.
>
> >
> > Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Fixes: 7198e6b03155 ("drm/msm: add a3xx gpu support")
>

jfyi, this comment (and associated list-head) is removed by:

https://patchwork.freedesktop.org/patch/496131/?series=105633&rev=4

BR,
-R

>
> > ---
> >   drivers/gpu/drm/msm/msm_gem.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h
> > index c75d3b879a53..e300c70e8904 100644
> > --- a/drivers/gpu/drm/msm/msm_gem.h
> > +++ b/drivers/gpu/drm/msm/msm_gem.h
> > @@ -118,7 +118,7 @@ struct msm_gem_object {
> >        * An object is either:
> >        *  inactive - on priv->inactive_dontneed or priv->inactive_willneed
> >        *     (depending on purgeability status)
> > -      *  active   - on one one of the gpu's active_list..  well, at
> > +      *  active   - on one of the gpu's active_list..  well, at
> >        *     least for now we don't have (I don't think) hw sync between
> >        *     2d and 3d one devices which have both, meaning we need to
> >        *     block on submit if a bo is already on other ring
>
> --
> With best wishes
> Dmitry
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-08-27 16:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-23 11:54 [PATCH] drm/msm: fix repeated words in comments Jilin Yuan
2022-08-26  9:43 ` Dmitry Baryshkov
2022-08-27 16:42   ` Rob Clark

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).