From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: fugang.duan@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: gregkh@linuxfoundation.org, kernel@pengutronix.de,
festevam@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH nvmem 1/1] nvmem: imx: add i.MX8QM platform support
Date: Tue, 6 Aug 2019 11:03:31 +0100 [thread overview]
Message-ID: <65afeaaf-f703-02f2-a918-90a8bb8f58b6@linaro.org> (raw)
In-Reply-To: <20190704142032.10745-1-fugang.duan@nxp.com>
On 04/07/2019 15:20, fugang.duan@nxp.com wrote:
> From: Fugang Duan <fugang.duan@nxp.com>
>
> i.MX8QM efuse table has some difference with i.MX8QXP platform,
> so add i.MX8QM platform support.
>
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> ---
> drivers/nvmem/imx-ocotp-scu.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/nvmem/imx-ocotp-scu.c b/drivers/nvmem/imx-ocotp-scu.c
> index be2f5f0..0d78ab4 100644
> --- a/drivers/nvmem/imx-ocotp-scu.c
> +++ b/drivers/nvmem/imx-ocotp-scu.c
> @@ -16,6 +16,7 @@
>
> enum ocotp_devtype {
> IMX8QXP,
> + IMX8QM,
> };
>
> struct ocotp_devtype_data {
> @@ -39,6 +40,11 @@ static struct ocotp_devtype_data imx8qxp_data = {
> .nregs = 800,
> };
>
> +static struct ocotp_devtype_data imx8qm_data = {
> + .devtype = IMX8QM,
> + .nregs = 800,
> +};
> +
> static int imx_sc_misc_otp_fuse_read(struct imx_sc_ipc *ipc, u32 word,
> u32 *val)
> {
> @@ -118,6 +124,7 @@ static struct nvmem_config imx_scu_ocotp_nvmem_config = {
>
> static const struct of_device_id imx_scu_ocotp_dt_ids[] = {
> { .compatible = "fsl,imx8qxp-scu-ocotp", (void *)&imx8qxp_data },
> + { .compatible = "fsl,imx8qm-scu-ocotp", (void *)&imx8qm_data },
> { },
Looks like you forgot to add this new compatible to device tree bindings
at ./Documentation/devicetree/bindings/nvmem/imx-ocotp.txt or forgot to
add me to CC.
Please resend the patch with it, I can not apply this as it is.
Thanks,
srini
> };
> MODULE_DEVICE_TABLE(of, imx_scu_ocotp_dt_ids);
>
next prev parent reply other threads:[~2019-08-06 10:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 14:20 [PATCH nvmem 1/1] nvmem: imx: add i.MX8QM platform support fugang.duan
2019-07-15 5:34 ` Andy Duan
2019-07-15 7:36 ` gregkh
2019-07-15 7:39 ` [EXT] " Andy Duan
2019-08-06 10:03 ` Srinivas Kandagatla [this message]
2019-08-07 1:50 ` Andy Duan
2019-08-07 3:50 ` Andy Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65afeaaf-f703-02f2-a918-90a8bb8f58b6@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).