* [PATCH nvmem 1/1] nvmem: imx: add i.MX8QM platform support
@ 2019-07-04 14:20 fugang.duan
2019-07-15 5:34 ` Andy Duan
2019-08-06 10:03 ` Srinivas Kandagatla
0 siblings, 2 replies; 7+ messages in thread
From: fugang.duan @ 2019-07-04 14:20 UTC (permalink / raw)
To: srinivas.kandagatla, shawnguo, s.hauer
Cc: gregkh, kernel, festevam, linux-arm-kernel, linux-kernel, fugang.duan
From: Fugang Duan <fugang.duan@nxp.com>
i.MX8QM efuse table has some difference with i.MX8QXP platform,
so add i.MX8QM platform support.
Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
---
drivers/nvmem/imx-ocotp-scu.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/nvmem/imx-ocotp-scu.c b/drivers/nvmem/imx-ocotp-scu.c
index be2f5f0..0d78ab4 100644
--- a/drivers/nvmem/imx-ocotp-scu.c
+++ b/drivers/nvmem/imx-ocotp-scu.c
@@ -16,6 +16,7 @@
enum ocotp_devtype {
IMX8QXP,
+ IMX8QM,
};
struct ocotp_devtype_data {
@@ -39,6 +40,11 @@ static struct ocotp_devtype_data imx8qxp_data = {
.nregs = 800,
};
+static struct ocotp_devtype_data imx8qm_data = {
+ .devtype = IMX8QM,
+ .nregs = 800,
+};
+
static int imx_sc_misc_otp_fuse_read(struct imx_sc_ipc *ipc, u32 word,
u32 *val)
{
@@ -118,6 +124,7 @@ static struct nvmem_config imx_scu_ocotp_nvmem_config = {
static const struct of_device_id imx_scu_ocotp_dt_ids[] = {
{ .compatible = "fsl,imx8qxp-scu-ocotp", (void *)&imx8qxp_data },
+ { .compatible = "fsl,imx8qm-scu-ocotp", (void *)&imx8qm_data },
{ },
};
MODULE_DEVICE_TABLE(of, imx_scu_ocotp_dt_ids);
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* RE: [PATCH nvmem 1/1] nvmem: imx: add i.MX8QM platform support
2019-07-04 14:20 [PATCH nvmem 1/1] nvmem: imx: add i.MX8QM platform support fugang.duan
@ 2019-07-15 5:34 ` Andy Duan
2019-07-15 7:36 ` gregkh
2019-08-06 10:03 ` Srinivas Kandagatla
1 sibling, 1 reply; 7+ messages in thread
From: Andy Duan @ 2019-07-15 5:34 UTC (permalink / raw)
To: Andy Duan, srinivas.kandagatla, shawnguo, s.hauer
Cc: gregkh, kernel, festevam, linux-arm-kernel, linux-kernel
Ping...
> From: Fugang Duan <fugang.duan@nxp.com>
>
> i.MX8QM efuse table has some difference with i.MX8QXP platform, so add
> i.MX8QM platform support.
>
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> ---
> drivers/nvmem/imx-ocotp-scu.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/nvmem/imx-ocotp-scu.c b/drivers/nvmem/imx-ocotp-scu.c
> index be2f5f0..0d78ab4 100644
> --- a/drivers/nvmem/imx-ocotp-scu.c
> +++ b/drivers/nvmem/imx-ocotp-scu.c
> @@ -16,6 +16,7 @@
>
> enum ocotp_devtype {
> IMX8QXP,
> + IMX8QM,
> };
>
> struct ocotp_devtype_data {
> @@ -39,6 +40,11 @@ static struct ocotp_devtype_data imx8qxp_data = {
> .nregs = 800,
> };
>
> +static struct ocotp_devtype_data imx8qm_data = {
> + .devtype = IMX8QM,
> + .nregs = 800,
> +};
> +
> static int imx_sc_misc_otp_fuse_read(struct imx_sc_ipc *ipc, u32 word,
> u32 *val)
> {
> @@ -118,6 +124,7 @@ static struct nvmem_config
> imx_scu_ocotp_nvmem_config = {
>
> static const struct of_device_id imx_scu_ocotp_dt_ids[] = {
> { .compatible = "fsl,imx8qxp-scu-ocotp", (void *)&imx8qxp_data },
> + { .compatible = "fsl,imx8qm-scu-ocotp", (void *)&imx8qm_data },
> { },
> };
> MODULE_DEVICE_TABLE(of, imx_scu_ocotp_dt_ids);
> --
> 2.7.4
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH nvmem 1/1] nvmem: imx: add i.MX8QM platform support
2019-07-15 5:34 ` Andy Duan
@ 2019-07-15 7:36 ` gregkh
2019-07-15 7:39 ` [EXT] " Andy Duan
0 siblings, 1 reply; 7+ messages in thread
From: gregkh @ 2019-07-15 7:36 UTC (permalink / raw)
To: Andy Duan
Cc: srinivas.kandagatla, shawnguo, s.hauer, kernel, festevam,
linux-arm-kernel, linux-kernel
On Mon, Jul 15, 2019 at 05:34:47AM +0000, Andy Duan wrote:
> Ping...
It's the middle of the merge window, we can't do anything with any
patches until after that. Please be patient.
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [EXT] Re: [PATCH nvmem 1/1] nvmem: imx: add i.MX8QM platform support
2019-07-15 7:36 ` gregkh
@ 2019-07-15 7:39 ` Andy Duan
0 siblings, 0 replies; 7+ messages in thread
From: Andy Duan @ 2019-07-15 7:39 UTC (permalink / raw)
To: gregkh
Cc: srinivas.kandagatla, shawnguo, s.hauer, kernel, festevam,
linux-arm-kernel, linux-kernel
From: gregkh@linuxfoundation.org <gregkh@linuxfoundation.org> Sent: Monday, July 15, 2019 3:37 PM
> On Mon, Jul 15, 2019 at 05:34:47AM +0000, Andy Duan wrote:
> > Ping...
>
> It's the middle of the merge window, we can't do anything with any patches
> until after that. Please be patient.
>
> greg k-h
Thanks for kindly reminder !
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH nvmem 1/1] nvmem: imx: add i.MX8QM platform support
2019-07-04 14:20 [PATCH nvmem 1/1] nvmem: imx: add i.MX8QM platform support fugang.duan
2019-07-15 5:34 ` Andy Duan
@ 2019-08-06 10:03 ` Srinivas Kandagatla
2019-08-07 1:50 ` [EXT] " Andy Duan
2019-08-07 3:50 ` Andy Duan
1 sibling, 2 replies; 7+ messages in thread
From: Srinivas Kandagatla @ 2019-08-06 10:03 UTC (permalink / raw)
To: fugang.duan, shawnguo, s.hauer
Cc: gregkh, kernel, festevam, linux-arm-kernel, linux-kernel
On 04/07/2019 15:20, fugang.duan@nxp.com wrote:
> From: Fugang Duan <fugang.duan@nxp.com>
>
> i.MX8QM efuse table has some difference with i.MX8QXP platform,
> so add i.MX8QM platform support.
>
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> ---
> drivers/nvmem/imx-ocotp-scu.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/nvmem/imx-ocotp-scu.c b/drivers/nvmem/imx-ocotp-scu.c
> index be2f5f0..0d78ab4 100644
> --- a/drivers/nvmem/imx-ocotp-scu.c
> +++ b/drivers/nvmem/imx-ocotp-scu.c
> @@ -16,6 +16,7 @@
>
> enum ocotp_devtype {
> IMX8QXP,
> + IMX8QM,
> };
>
> struct ocotp_devtype_data {
> @@ -39,6 +40,11 @@ static struct ocotp_devtype_data imx8qxp_data = {
> .nregs = 800,
> };
>
> +static struct ocotp_devtype_data imx8qm_data = {
> + .devtype = IMX8QM,
> + .nregs = 800,
> +};
> +
> static int imx_sc_misc_otp_fuse_read(struct imx_sc_ipc *ipc, u32 word,
> u32 *val)
> {
> @@ -118,6 +124,7 @@ static struct nvmem_config imx_scu_ocotp_nvmem_config = {
>
> static const struct of_device_id imx_scu_ocotp_dt_ids[] = {
> { .compatible = "fsl,imx8qxp-scu-ocotp", (void *)&imx8qxp_data },
> + { .compatible = "fsl,imx8qm-scu-ocotp", (void *)&imx8qm_data },
> { },
Looks like you forgot to add this new compatible to device tree bindings
at ./Documentation/devicetree/bindings/nvmem/imx-ocotp.txt or forgot to
add me to CC.
Please resend the patch with it, I can not apply this as it is.
Thanks,
srini
> };
> MODULE_DEVICE_TABLE(of, imx_scu_ocotp_dt_ids);
>
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [EXT] Re: [PATCH nvmem 1/1] nvmem: imx: add i.MX8QM platform support
2019-08-06 10:03 ` Srinivas Kandagatla
@ 2019-08-07 1:50 ` Andy Duan
2019-08-07 3:50 ` Andy Duan
1 sibling, 0 replies; 7+ messages in thread
From: Andy Duan @ 2019-08-07 1:50 UTC (permalink / raw)
To: Srinivas Kandagatla, shawnguo, s.hauer
Cc: gregkh, kernel, festevam, linux-arm-kernel, linux-kernel
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Sent: Tuesday, August 6, 2019 6:04 PM
> On 04/07/2019 15:20, fugang.duan@nxp.com wrote:
> > From: Fugang Duan <fugang.duan@nxp.com>
> >
> > i.MX8QM efuse table has some difference with i.MX8QXP platform, so add
> > i.MX8QM platform support.
> >
> > Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> > ---
> > drivers/nvmem/imx-ocotp-scu.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/nvmem/imx-ocotp-scu.c
> > b/drivers/nvmem/imx-ocotp-scu.c index be2f5f0..0d78ab4 100644
> > --- a/drivers/nvmem/imx-ocotp-scu.c
> > +++ b/drivers/nvmem/imx-ocotp-scu.c
> > @@ -16,6 +16,7 @@
> >
> > enum ocotp_devtype {
> > IMX8QXP,
> > + IMX8QM,
> > };
> >
> > struct ocotp_devtype_data {
> > @@ -39,6 +40,11 @@ static struct ocotp_devtype_data imx8qxp_data = {
> > .nregs = 800,
> > };
> >
> > +static struct ocotp_devtype_data imx8qm_data = {
> > + .devtype = IMX8QM,
> > + .nregs = 800,
> > +};
> > +
> > static int imx_sc_misc_otp_fuse_read(struct imx_sc_ipc *ipc, u32 word,
> > u32 *val)
> > {
> > @@ -118,6 +124,7 @@ static struct nvmem_config
> > imx_scu_ocotp_nvmem_config = {
> >
> > static const struct of_device_id imx_scu_ocotp_dt_ids[] = {
> > { .compatible = "fsl,imx8qxp-scu-ocotp", (void *)&imx8qxp_data
> > },
> > + { .compatible = "fsl,imx8qm-scu-ocotp", (void *)&imx8qm_data },
> > { },
>
> Looks like you forgot to add this new compatible to device tree bindings
> at ./Documentation/devicetree/bindings/nvmem/imx-ocotp.txt or forgot to
> add me to CC.
>
> Please resend the patch with it, I can not apply this as it is.
>
> Thanks,
> srini
Thanks for your review.
I will send the V2 version including the separated device tree bindings patch.
>
> > };
> > MODULE_DEVICE_TABLE(of, imx_scu_ocotp_dt_ids);
> >
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [EXT] Re: [PATCH nvmem 1/1] nvmem: imx: add i.MX8QM platform support
2019-08-06 10:03 ` Srinivas Kandagatla
2019-08-07 1:50 ` [EXT] " Andy Duan
@ 2019-08-07 3:50 ` Andy Duan
1 sibling, 0 replies; 7+ messages in thread
From: Andy Duan @ 2019-08-07 3:50 UTC (permalink / raw)
To: Srinivas Kandagatla, shawnguo, s.hauer
Cc: gregkh, kernel, festevam, linux-arm-kernel, linux-kernel
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Sent: Tuesday, August 6, 2019 6:04 PM
> On 04/07/2019 15:20, fugang.duan@nxp.com wrote:
> > From: Fugang Duan <fugang.duan@nxp.com>
> >
> > i.MX8QM efuse table has some difference with i.MX8QXP platform, so add
> > i.MX8QM platform support.
> >
> > Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> > ---
> > drivers/nvmem/imx-ocotp-scu.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/nvmem/imx-ocotp-scu.c
> > b/drivers/nvmem/imx-ocotp-scu.c index be2f5f0..0d78ab4 100644
> > --- a/drivers/nvmem/imx-ocotp-scu.c
> > +++ b/drivers/nvmem/imx-ocotp-scu.c
> > @@ -16,6 +16,7 @@
> >
> > enum ocotp_devtype {
> > IMX8QXP,
> > + IMX8QM,
> > };
> >
> > struct ocotp_devtype_data {
> > @@ -39,6 +40,11 @@ static struct ocotp_devtype_data imx8qxp_data = {
> > .nregs = 800,
> > };
> >
> > +static struct ocotp_devtype_data imx8qm_data = {
> > + .devtype = IMX8QM,
> > + .nregs = 800,
> > +};
> > +
> > static int imx_sc_misc_otp_fuse_read(struct imx_sc_ipc *ipc, u32 word,
> > u32 *val)
> > {
> > @@ -118,6 +124,7 @@ static struct nvmem_config
> > imx_scu_ocotp_nvmem_config = {
> >
> > static const struct of_device_id imx_scu_ocotp_dt_ids[] = {
> > { .compatible = "fsl,imx8qxp-scu-ocotp", (void *)&imx8qxp_data
> > },
> > + { .compatible = "fsl,imx8qm-scu-ocotp", (void *)&imx8qm_data },
> > { },
>
> Looks like you forgot to add this new compatible to device tree bindings
> at ./Documentation/devicetree/bindings/nvmem/imx-ocotp.txt or forgot to
> add me to CC.
>
> Please resend the patch with it, I can not apply this as it is.
>
> Thanks,
> srini
There have no separated binding documentation for imx-ocotp-scu.c driver.
It is reasonable to add the new compatible string on below binding file "fsl,scu.txt":
Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
>
> > };
> > MODULE_DEVICE_TABLE(of, imx_scu_ocotp_dt_ids);
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-08-07 3:51 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-04 14:20 [PATCH nvmem 1/1] nvmem: imx: add i.MX8QM platform support fugang.duan
2019-07-15 5:34 ` Andy Duan
2019-07-15 7:36 ` gregkh
2019-07-15 7:39 ` [EXT] " Andy Duan
2019-08-06 10:03 ` Srinivas Kandagatla
2019-08-07 1:50 ` [EXT] " Andy Duan
2019-08-07 3:50 ` Andy Duan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).