From: Chuck Lever III <chuck.lever@oracle.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: Bruce Fields <bfields@fieldses.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] NFSD: Fix inconsistent indenting
Date: Thu, 2 Dec 2021 16:29:14 +0000 [thread overview]
Message-ID: <6609E132-FDDA-490B-B1F5-C6823EB85834@oracle.com> (raw)
In-Reply-To: <1638434142-44998-1-git-send-email-jiapeng.chong@linux.alibaba.com>
> On Dec 2, 2021, at 3:35 AM, Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
>
> Eliminate the follow smatch warning:
>
> fs/nfsd/nfs4xdr.c:4766 nfsd4_encode_read_plus_hole() warn: inconsistent
> indenting.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> fs/nfsd/nfs4xdr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index c286690..3031126 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -4763,8 +4763,8 @@ static __be32 nfsd4_encode_readv(struct nfsd4_compoundres *resp,
> return nfserr_resource;
>
> *p++ = htonl(NFS4_CONTENT_HOLE);
> - p = xdr_encode_hyper(p, read->rd_offset);
> - p = xdr_encode_hyper(p, count);
> + p = xdr_encode_hyper(p, read->rd_offset);
> + p = xdr_encode_hyper(p, count);
>
> *eof = (read->rd_offset + count) >= f_size;
> *maxcount = min_t(unsigned long, count, *maxcount);
> --
> 1.8.3.1
>
Thanks! I've included this patch in my for-next topic branch.
--
Chuck Lever
prev parent reply other threads:[~2021-12-02 16:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 8:35 [PATCH] NFSD: Fix inconsistent indenting Jiapeng Chong
2021-12-02 16:29 ` Chuck Lever III [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6609E132-FDDA-490B-B1F5-C6823EB85834@oracle.com \
--to=chuck.lever@oracle.com \
--cc=bfields@fieldses.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).