linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] NFSD: Fix inconsistent indenting
@ 2021-12-02  8:35 Jiapeng Chong
  2021-12-02 16:29 ` Chuck Lever III
  0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-12-02  8:35 UTC (permalink / raw)
  To: bfields; +Cc: chuck.lever, linux-nfs, linux-kernel, Jiapeng Chong

Eliminate the follow smatch warning:

fs/nfsd/nfs4xdr.c:4766 nfsd4_encode_read_plus_hole() warn: inconsistent
indenting.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 fs/nfsd/nfs4xdr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index c286690..3031126 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -4763,8 +4763,8 @@ static __be32 nfsd4_encode_readv(struct nfsd4_compoundres *resp,
 		return nfserr_resource;
 
 	*p++ = htonl(NFS4_CONTENT_HOLE);
-	 p   = xdr_encode_hyper(p, read->rd_offset);
-	 p   = xdr_encode_hyper(p, count);
+	p = xdr_encode_hyper(p, read->rd_offset);
+	p = xdr_encode_hyper(p, count);
 
 	*eof = (read->rd_offset + count) >= f_size;
 	*maxcount = min_t(unsigned long, count, *maxcount);
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] NFSD: Fix inconsistent indenting
  2021-12-02  8:35 [PATCH] NFSD: Fix inconsistent indenting Jiapeng Chong
@ 2021-12-02 16:29 ` Chuck Lever III
  0 siblings, 0 replies; 2+ messages in thread
From: Chuck Lever III @ 2021-12-02 16:29 UTC (permalink / raw)
  To: Jiapeng Chong; +Cc: Bruce Fields, Linux NFS Mailing List, linux-kernel



> On Dec 2, 2021, at 3:35 AM, Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
> 
> Eliminate the follow smatch warning:
> 
> fs/nfsd/nfs4xdr.c:4766 nfsd4_encode_read_plus_hole() warn: inconsistent
> indenting.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> fs/nfsd/nfs4xdr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index c286690..3031126 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -4763,8 +4763,8 @@ static __be32 nfsd4_encode_readv(struct nfsd4_compoundres *resp,
> 		return nfserr_resource;
> 
> 	*p++ = htonl(NFS4_CONTENT_HOLE);
> -	 p   = xdr_encode_hyper(p, read->rd_offset);
> -	 p   = xdr_encode_hyper(p, count);
> +	p = xdr_encode_hyper(p, read->rd_offset);
> +	p = xdr_encode_hyper(p, count);
> 
> 	*eof = (read->rd_offset + count) >= f_size;
> 	*maxcount = min_t(unsigned long, count, *maxcount);
> -- 
> 1.8.3.1
> 

Thanks! I've included this patch in my for-next topic branch.

--
Chuck Lever




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-02 16:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-02  8:35 [PATCH] NFSD: Fix inconsistent indenting Jiapeng Chong
2021-12-02 16:29 ` Chuck Lever III

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).