linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	James Simmons <jsimmons@infradead.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org,
	"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Subject: [PATCH 15/20] staging: lustre: llite: mark expected switch fall-through
Date: Thu, 12 Oct 2017 11:17:23 -0500	[thread overview]
Message-ID: <661e7cdf247c7662f4f27ac7c54fb4636fd9c1e3.1507781178.git.garsilva@embeddedor.com> (raw)
In-Reply-To: <cover.1507781178.git.garsilva@embeddedor.com>

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/staging/lustre/lustre/llite/namei.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/llite/namei.c b/drivers/staging/lustre/lustre/llite/namei.c
index 5cc2b32..55e0d03 100644
--- a/drivers/staging/lustre/lustre/llite/namei.c
+++ b/drivers/staging/lustre/lustre/llite/namei.c
@@ -949,7 +949,9 @@ static int ll_mknod(struct inode *dir, struct dentry *dchild,
 
 	switch (mode & S_IFMT) {
 	case 0:
-		mode |= S_IFREG; /* for mode = 0 case, fallthrough */
+		mode |= S_IFREG;
+		/* for mode = 0 case */
+		/* fall through */
 	case S_IFREG:
 	case S_IFCHR:
 	case S_IFBLK:
-- 
2.7.4

  parent reply	other threads:[~2017-10-12 16:42 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12 16:15 [PATCH 00/20] mark expected switch fall-throughs Gustavo A. R. Silva
2017-10-12 16:15 ` [PATCH 01/20] staging: ks7010: ks_wlan_net: " Gustavo A. R. Silva
2017-10-12 16:16 ` [PATCH 02/20] staging: lustre: lnet: socklnd: mark expected switch fall-through Gustavo A. R. Silva
2017-10-17 22:56   ` Dilger, Andreas
2017-10-12 16:16 ` [PATCH 03/20] staging: rtl8192e: " Gustavo A. R. Silva
2017-10-12 16:16 ` [PATCH 04/20] staging: rtl8723bs: rtw_mlme_ext: " Gustavo A. R. Silva
2017-10-12 16:16 ` [PATCH 05/20] staging: lustre: lnet: net_fault: " Gustavo A. R. Silva
2017-10-17 22:57   ` Dilger, Andreas
2017-10-12 16:16 ` [PATCH 06/20] staging: comedi: s526: " Gustavo A. R. Silva
2017-10-12 16:16 ` [PATCH 07/20] staging: rtl8188eu: usb_halinit: " Gustavo A. R. Silva
2017-10-12 16:16 ` [PATCH 08/20] staging: vc04_services: vchiq_core: " Gustavo A. R. Silva
2017-10-12 17:29   ` Stefan Wahren
2017-10-12 16:16 ` [PATCH 09/20] staging: vt6656: card: mark expected switch fall-throughs Gustavo A. R. Silva
2017-10-12 16:16 ` [PATCH 10/20] staging: rtl8188eu: usb_ops_linux: mark expected switch fall-through Gustavo A. R. Silva
2017-10-12 16:17 ` [PATCH 11/20] staging: r8822be: mark expected switch fall-throughs Gustavo A. R. Silva
2017-10-12 16:17 ` [PATCH 12/20] staging: lustre: lnet: selftest: mark expected switch fall-through Gustavo A. R. Silva
2017-10-17 23:05   ` Dilger, Andreas
2017-10-12 16:17 ` [PATCH 13/20] staging: rtlwifi: halmac: " Gustavo A. R. Silva
2017-10-12 16:17 ` [PATCH 14/20] staging: lustre: lnet: selftest: mark expected switch fall-throughs Gustavo A. R. Silva
2017-10-17 22:58   ` Dilger, Andreas
2017-10-12 16:17 ` Gustavo A. R. Silva [this message]
2017-10-17 23:00   ` [PATCH 15/20] staging: lustre: llite: mark expected switch fall-through Dilger, Andreas
2017-10-12 16:17 ` [PATCH 16/20] staging: lustre: lprocfs: mark expected switch fall-throughs Gustavo A. R. Silva
2017-10-17 23:00   ` Dilger, Andreas
2017-10-12 16:17 ` [PATCH 17/20] staging: lustre: ldlm: mark expected switch fall-through Gustavo A. R. Silva
2017-10-17 23:01   ` Dilger, Andreas
2017-10-12 16:17 ` [PATCH 18/20] staging: lustre: osc: " Gustavo A. R. Silva
2017-10-17 23:03   ` Dilger, Andreas
2017-10-12 16:17 ` [PATCH 19/20] staging: lustre: ptlrpc: mark expected switch fall-throughs Gustavo A. R. Silva
2017-10-17 23:04   ` Dilger, Andreas
2017-10-12 16:17 ` [PATCH 20/20] staging: lustre: rpc: " Gustavo A. R. Silva
2017-10-17 23:05   ` Dilger, Andreas
2017-10-23 19:33 ` [PATCH 00/20] " Gustavo A. R. Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=661e7cdf247c7662f4f27ac7c54fb4636fd9c1e3.1507781178.git.garsilva@embeddedor.com \
    --to=garsilva@embeddedor.com \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jsimmons@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).