From: "Dilger, Andreas" <andreas.dilger@intel.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: "Drokin, Oleg" <oleg.drokin@intel.com>,
James Simmons <jsimmons@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"lustre-devel@lists.lustre.org" <lustre-devel@lists.lustre.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 19/20] staging: lustre: ptlrpc: mark expected switch fall-throughs
Date: Tue, 17 Oct 2017 23:04:00 +0000 [thread overview]
Message-ID: <D8E42C0A-24EF-4312-9C0E-0D90BF296193@intel.com> (raw)
In-Reply-To: <afa1f786515ab143ba5710a6df3797286269bbe2.1507781178.git.garsilva@embeddedor.com>
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva <garsilva@embeddedor.com> wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
> ---
> drivers/staging/lustre/lustre/ptlrpc/pack_generic.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
> index aad4ff1..a3664c1 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
> @@ -786,7 +786,7 @@ __u32 lustre_msg_get_flags(struct lustre_msg *msg)
>
> CERROR("invalid msg %p: no ptlrpc body!\n", msg);
> }
> - /* no break */
> + /* fall through */
> default:
> /* flags might be printed in debug code while message
> * uninitialized
> @@ -854,7 +854,7 @@ __u32 lustre_msg_get_op_flags(struct lustre_msg *msg)
>
> CERROR("invalid msg %p: no ptlrpc body!\n", msg);
> }
> - /* no break */
> + /* fall through */
> default:
> return 0;
> }
> @@ -1035,7 +1035,7 @@ int lustre_msg_get_status(struct lustre_msg *msg)
>
> CERROR("invalid msg %p: no ptlrpc body!\n", msg);
> }
> - /* no break */
> + /* fall through */
> default:
> /* status might be printed in debug code while message
> * uninitialized
> --
> 2.7.4
>
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation
next prev parent reply other threads:[~2017-10-17 23:04 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 16:15 [PATCH 00/20] mark expected switch fall-throughs Gustavo A. R. Silva
2017-10-12 16:15 ` [PATCH 01/20] staging: ks7010: ks_wlan_net: " Gustavo A. R. Silva
2017-10-12 16:16 ` [PATCH 02/20] staging: lustre: lnet: socklnd: mark expected switch fall-through Gustavo A. R. Silva
2017-10-17 22:56 ` Dilger, Andreas
2017-10-12 16:16 ` [PATCH 03/20] staging: rtl8192e: " Gustavo A. R. Silva
2017-10-12 16:16 ` [PATCH 04/20] staging: rtl8723bs: rtw_mlme_ext: " Gustavo A. R. Silva
2017-10-12 16:16 ` [PATCH 05/20] staging: lustre: lnet: net_fault: " Gustavo A. R. Silva
2017-10-17 22:57 ` Dilger, Andreas
2017-10-12 16:16 ` [PATCH 06/20] staging: comedi: s526: " Gustavo A. R. Silva
2017-10-12 16:16 ` [PATCH 07/20] staging: rtl8188eu: usb_halinit: " Gustavo A. R. Silva
2017-10-12 16:16 ` [PATCH 08/20] staging: vc04_services: vchiq_core: " Gustavo A. R. Silva
2017-10-12 17:29 ` Stefan Wahren
2017-10-12 16:16 ` [PATCH 09/20] staging: vt6656: card: mark expected switch fall-throughs Gustavo A. R. Silva
2017-10-12 16:16 ` [PATCH 10/20] staging: rtl8188eu: usb_ops_linux: mark expected switch fall-through Gustavo A. R. Silva
2017-10-12 16:17 ` [PATCH 11/20] staging: r8822be: mark expected switch fall-throughs Gustavo A. R. Silva
2017-10-12 16:17 ` [PATCH 12/20] staging: lustre: lnet: selftest: mark expected switch fall-through Gustavo A. R. Silva
2017-10-17 23:05 ` Dilger, Andreas
2017-10-12 16:17 ` [PATCH 13/20] staging: rtlwifi: halmac: " Gustavo A. R. Silva
2017-10-12 16:17 ` [PATCH 14/20] staging: lustre: lnet: selftest: mark expected switch fall-throughs Gustavo A. R. Silva
2017-10-17 22:58 ` Dilger, Andreas
2017-10-12 16:17 ` [PATCH 15/20] staging: lustre: llite: mark expected switch fall-through Gustavo A. R. Silva
2017-10-17 23:00 ` Dilger, Andreas
2017-10-12 16:17 ` [PATCH 16/20] staging: lustre: lprocfs: mark expected switch fall-throughs Gustavo A. R. Silva
2017-10-17 23:00 ` Dilger, Andreas
2017-10-12 16:17 ` [PATCH 17/20] staging: lustre: ldlm: mark expected switch fall-through Gustavo A. R. Silva
2017-10-17 23:01 ` Dilger, Andreas
2017-10-12 16:17 ` [PATCH 18/20] staging: lustre: osc: " Gustavo A. R. Silva
2017-10-17 23:03 ` Dilger, Andreas
2017-10-12 16:17 ` [PATCH 19/20] staging: lustre: ptlrpc: mark expected switch fall-throughs Gustavo A. R. Silva
2017-10-17 23:04 ` Dilger, Andreas [this message]
2017-10-12 16:17 ` [PATCH 20/20] staging: lustre: rpc: " Gustavo A. R. Silva
2017-10-17 23:05 ` Dilger, Andreas
2017-10-23 19:33 ` [PATCH 00/20] " Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D8E42C0A-24EF-4312-9C0E-0D90BF296193@intel.com \
--to=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=garsilva@embeddedor.com \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).