From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, robh@kernel.org,
Baolin Wang <baolin.wang@linaro.org>,
Daniel Mack <daniel@zonque.org>, Dan Murphy <dmurphy@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Oleh Kravchenko <oleg@kaa.org.ua>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Simon Shields <simon@lineageos.org>,
Xiaotong Lu <xiaotong.lu@spreadtrum.com>
Subject: Re: [PATCH 02/24] leds: core: Add support for composing LED class device names
Date: Mon, 12 Nov 2018 17:01:59 +0100 [thread overview]
Message-ID: <662c02ba-455b-e2bf-a5e2-ae3933161894@gmail.com> (raw)
In-Reply-To: <20181112103513.GB5695@amd>
Hi,
On 11/12/2018 11:35 AM, Pavel Machek wrote:
> Hi!
>
>>>> It's overcomplicating the naming again. In every case you can tweak
>>>> the function name to eth0_link, eth1_link etc.
>>>
>>> Well, but in such case it would be good to keep existing scheme.
>>>
>>> My system looks like this:
>>>
>>> input16::capslock tpacpi::bay_active tpacpi::standby
>>> input16::numlock tpacpi::dock_active tpacpi::thinklight
>>> input16::scrolllock tpacpi::dock_batt tpacpi::thinkvantage
>>> input5::capslock tpacpi::dock_status1 tpacpi::unknown_led
>>> input5::numlock tpacpi::dock_status2 tpacpi::unknown_led2
>>> input5::scrolllock tpacpi:green:batt tpacpi::unknown_led3
>>>
>>> I agree that we should get rid of "tpacpi:" part in some cases. But
>>> it does not make sense to get rid of "input16:" part -- it tells you
>>> if the LED is on USB or on built-in keyboard.
>>>
>>> Ideally, tpacpi::thinklight would be input5::frontlight (as it is
>>> frontlight for the keyboard).
>>>
>>> Yes we should simplify, but it still needs to work in all cases.
>>
>> Well, label is not being removed. You still can use it an the old
>> fashion, even when using new led_compose_name().
>>
>> Maybe removing the description of the old LED naming from
>> Documentation/leds/leds-class.txt was too drastic move.
>> I'll keep it next to the new one, and only add a note that
>> it is kept only for backwards compatibility.
>
> I agree that removing it is "just too drastic".
>
> But it is not just for backwards compatibility. See my examples above,
> it is needed to tell which device the LED is asociated with, and it is
> absolutely required for USB devices (for example).
For USB devices there is already ledtrig-usbport available, which
provides sysfs interface for defining and reading the usb ports,
the status of which the LED indicates. Since the USB devices can be
attached/removed dynamically, it would be impossible to reflect
the associations in the LED class device name.
> And even for "embedded" stuff like routers, we want eth0:green:link,
> eth0:yellow:activity and not some kind of hack.
eth0 is not something you can be certain of at the stage of defining DT
node.
> Ideally, colors would come from fixed list, functions would come from
> fixed list, and device part would come from name used elsewhere in the
> kernel.
>
> (And yes, it probably means we should have something in device tree to
> link LED to its device. device = "name" would be good start...)
Why would you need such link?
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2018-11-12 16:02 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 22:07 [PATCH 00/24] Add generic support for composing LED class device name Jacek Anaszewski
2018-11-06 22:07 ` [PATCH 01/24] leds: class: Improve LED and LED flash class registration API Jacek Anaszewski
2018-11-07 6:55 ` Baolin Wang
2018-11-07 20:51 ` Jacek Anaszewski
2018-11-08 17:50 ` Dan Murphy
2018-11-08 20:47 ` Jacek Anaszewski
2018-11-11 11:31 ` Pavel Machek
2018-11-06 22:07 ` [PATCH 02/24] leds: core: Add support for composing LED class device names Jacek Anaszewski
2018-11-07 7:20 ` Baolin Wang
2018-11-08 20:47 ` Jacek Anaszewski
2018-11-09 2:35 ` Baolin Wang
2018-11-08 18:06 ` Dan Murphy
2018-11-08 20:48 ` Jacek Anaszewski
2018-11-11 12:02 ` Pavel Machek
2018-11-11 20:02 ` Jacek Anaszewski
2018-11-11 20:16 ` Pavel Machek
2018-11-11 21:14 ` Jacek Anaszewski
2018-11-12 0:01 ` Vesa Jääskeläinen
2018-11-12 15:59 ` Jacek Anaszewski
2018-11-12 21:25 ` Linus Walleij
2018-11-12 22:11 ` LEDs on USB keyboards was " Pavel Machek
2018-11-12 10:35 ` Pavel Machek
2018-11-12 16:01 ` Jacek Anaszewski [this message]
2018-11-12 19:05 ` Pavel Machek
2018-11-12 20:11 ` Jacek Anaszewski
2018-11-12 22:06 ` Pavel Machek
2018-11-13 20:57 ` Jacek Anaszewski
2018-11-13 21:38 ` Geert Uytterhoeven
2018-11-13 21:50 ` Pavel Machek
2018-11-12 21:23 ` Linus Walleij
2018-11-13 19:55 ` Jacek Anaszewski
2018-11-15 9:10 ` Linus Walleij
2018-11-06 22:07 ` [PATCH 03/24] leds: dt-bindings: Add LED_FUNCTION definitions Jacek Anaszewski
2018-11-07 8:36 ` Vokáč Michal
2018-11-07 19:28 ` Jacek Anaszewski
2018-11-08 15:13 ` Rob Herring
2018-11-08 21:03 ` Jacek Anaszewski
2018-11-11 11:31 ` Pavel Machek
2018-11-11 20:02 ` Jacek Anaszewski
2018-11-11 20:20 ` Pavel Machek
2018-11-11 21:16 ` Jacek Anaszewski
2018-11-12 0:25 ` Vesa Jääskeläinen
2018-11-12 16:01 ` Jacek Anaszewski
2018-11-15 9:16 ` Linus Walleij
2018-11-06 22:07 ` [PATCH 04/24] dt-bindings: leds: Add function and color properties Jacek Anaszewski
2018-11-08 18:00 ` Dan Murphy
2018-11-08 20:47 ` Jacek Anaszewski
2018-11-08 21:08 ` Dan Murphy
2018-11-09 20:00 ` Jacek Anaszewski
2018-11-09 8:32 ` Vesa Jääskeläinen
2018-11-09 20:42 ` Jacek Anaszewski
2018-11-10 17:19 ` Vesa Jääskeläinen
2018-11-12 16:02 ` Jacek Anaszewski
2018-11-13 7:10 ` Vesa Jääskeläinen
2018-11-13 19:02 ` Jacek Anaszewski
[not found] ` <5bea0eb8.1c69fb81.6b921.80e6@mx.google.com>
2018-11-13 20:57 ` Jacek Anaszewski
2018-11-27 20:37 ` Jacek Anaszewski
2018-11-30 14:38 ` Rob Herring
2018-11-30 21:08 ` Pavel Machek
2018-11-30 22:19 ` Rob Herring
2018-12-01 21:17 ` Jacek Anaszewski
2018-12-11 17:27 ` Rob Herring
2018-12-11 22:44 ` Pavel Machek
2018-12-21 10:12 ` Linus Walleij
2018-12-12 9:59 ` Pavel Machek
2018-12-12 13:56 ` Rob Herring
2018-12-12 18:32 ` Pavel Machek
2018-12-23 20:11 ` Jacek Anaszewski
2018-11-06 22:07 ` [PATCH 05/24] dt-bindings: sc27xx-blt: " Jacek Anaszewski
2018-11-11 14:29 ` Pavel Machek
2018-11-11 20:03 ` Jacek Anaszewski
2018-11-06 22:07 ` [PATCH 06/24] leds: sc27xx-blt: Use led_compose_name() Jacek Anaszewski
2018-11-07 7:22 ` Baolin Wang
2018-11-11 14:31 ` Pavel Machek
2018-11-06 22:07 ` [PATCH 07/24] dt-bindings: lt3593: Add function and color properties Jacek Anaszewski
2018-11-06 22:07 ` [PATCH 08/24] leds: lt3593: Use led_compose_name() Jacek Anaszewski
2018-11-07 19:37 ` Daniel Mack
2018-11-07 19:49 ` Jacek Anaszewski
2018-11-08 8:33 ` Daniel Mack
2018-11-06 22:07 ` [PATCH 09/24] dt-bindings: lp8860: Add function and color properties Jacek Anaszewski
2018-11-08 18:01 ` Dan Murphy
2018-11-06 22:07 ` [PATCH 10/24] leds: lp8860: Use led_compose_name() Jacek Anaszewski
2018-11-08 18:16 ` Dan Murphy
2018-11-08 20:48 ` Jacek Anaszewski
2018-11-12 14:05 ` Dan Murphy
2018-11-06 22:07 ` [PATCH 11/24] dt-bindings: lm3692x: Add function and color properties Jacek Anaszewski
2018-11-08 18:12 ` Dan Murphy
2018-11-06 22:07 ` [PATCH 12/24] leds: lm3692x: Use led_compose_name() Jacek Anaszewski
2018-11-08 18:14 ` Dan Murphy
2018-11-08 20:48 ` Jacek Anaszewski
2018-11-08 21:11 ` Dan Murphy
2018-11-11 14:31 ` Pavel Machek
2018-11-06 22:07 ` [PATCH 13/24] dt-bindings: lm36010: Add function and color properties Jacek Anaszewski
2018-11-08 18:15 ` Dan Murphy
2018-11-06 22:07 ` [PATCH 14/24] leds: lm3601x: Use led_compose_name() Jacek Anaszewski
2018-11-06 22:07 ` [PATCH 15/24] dt-bindings: cr0014114: Add function and color properties Jacek Anaszewski
2018-11-06 22:07 ` [PATCH 16/24] leds: cr0014114: Use led_compose_name() Jacek Anaszewski
2018-11-06 22:07 ` [PATCH 17/24] dt-bindings: aat1290: Add function and color properties Jacek Anaszewski
2018-11-06 22:07 ` [PATCH 18/24] leds: aat1290: Use led_compose_name() Jacek Anaszewski
2018-11-06 22:07 ` [PATCH 19/24] dt-bindings: as3645a: Add function and color properties Jacek Anaszewski
2018-11-06 22:07 ` [PATCH 20/24] leds: as3645a: Use led_compose_name() Jacek Anaszewski
2018-11-06 22:07 ` [PATCH 21/24] dt-bindings: leds-gpio: Add function and color properties Jacek Anaszewski
2018-11-06 22:07 ` [PATCH 22/24] leds: gpio: Use led_compose_name() Jacek Anaszewski
2018-11-06 22:07 ` [PATCH 23/24] dt-bindings: an30259a: Add function and color properties Jacek Anaszewski
2018-11-06 22:07 ` [PATCH 24/24] leds: an30259a: Use led_compose_name() Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=662c02ba-455b-e2bf-a5e2-ae3933161894@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=baolin.wang@linaro.org \
--cc=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=oleg@kaa.org.ua \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=simon@lineageos.org \
--cc=xiaotong.lu@spreadtrum.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).