* [PATCH] MOUSE_ATARI: fix kconfig unmet dependency warning
@ 2021-05-26 7:03 Randy Dunlap
2021-05-26 7:20 ` Geert Uytterhoeven
2021-05-26 19:16 ` Michael Schmitz
0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2021-05-26 7:03 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Michael Schmitz, Roman Zippel, Geert Uytterhoeven,
Dmitry Torokhov, linux-input
MOUSE_ATARI should depend on INPUT_KEYBOARD since ATARI_KBD_CORE
depends on INPUT_KEYBOARD. This prevents MOUSE_ATARI from
selecting ATARI_KBD_CORE when INPUT_KEYBOARD is not set/enabled.
WARNING: unmet direct dependencies detected for ATARI_KBD_CORE
Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n]
Selected by [y]:
- MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y]
Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Michael Schmitz <schmitz@debian.org>
Cc: Roman Zippel <zippel@linux-m68k.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
---
drivers/input/mouse/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20210525.orig/drivers/input/mouse/Kconfig
+++ linux-next-20210525/drivers/input/mouse/Kconfig
@@ -348,6 +348,7 @@ config MOUSE_AMIGA
config MOUSE_ATARI
tristate "Atari mouse"
+ depends on INPUT_KEYBOARD
depends on ATARI
select ATARI_KBD_CORE
help
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] MOUSE_ATARI: fix kconfig unmet dependency warning
2021-05-26 7:03 [PATCH] MOUSE_ATARI: fix kconfig unmet dependency warning Randy Dunlap
@ 2021-05-26 7:20 ` Geert Uytterhoeven
2021-05-26 19:27 ` Michael Schmitz
2021-05-26 19:16 ` Michael Schmitz
1 sibling, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-05-26 7:20 UTC (permalink / raw)
To: Randy Dunlap
Cc: Linux Kernel Mailing List, Michael Schmitz, Roman Zippel,
Dmitry Torokhov, linux-input, linux-m68k
Hi Randy,
On Wed, May 26, 2021 at 9:03 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> MOUSE_ATARI should depend on INPUT_KEYBOARD since ATARI_KBD_CORE
> depends on INPUT_KEYBOARD. This prevents MOUSE_ATARI from
> selecting ATARI_KBD_CORE when INPUT_KEYBOARD is not set/enabled.
>
> WARNING: unmet direct dependencies detected for ATARI_KBD_CORE
> Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n]
> Selected by [y]:
> - MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y]
>
> Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Thanks for your patch!
> --- linux-next-20210525.orig/drivers/input/mouse/Kconfig
> +++ linux-next-20210525/drivers/input/mouse/Kconfig
> @@ -348,6 +348,7 @@ config MOUSE_AMIGA
>
> config MOUSE_ATARI
> tristate "Atari mouse"
> + depends on INPUT_KEYBOARD
> depends on ATARI
> select ATARI_KBD_CORE
> help
It looks like arch/m68k/atari/atakeyb.c doesn't use anything from the
input subsystem, so I think you can move the ATARI_KBD_CORE symbol
outside the "if INPUT_KEYBOARD" section instead.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] MOUSE_ATARI: fix kconfig unmet dependency warning
2021-05-26 7:20 ` Geert Uytterhoeven
@ 2021-05-26 19:27 ` Michael Schmitz
0 siblings, 0 replies; 4+ messages in thread
From: Michael Schmitz @ 2021-05-26 19:27 UTC (permalink / raw)
To: Geert Uytterhoeven, Randy Dunlap
Cc: Linux Kernel Mailing List, Michael Schmitz, Roman Zippel,
Dmitry Torokhov, linux-input, linux-m68k
Hi Geert,
On 26/05/21 7:20 pm, Geert Uytterhoeven wrote:
> Hi Randy,
>
> On Wed, May 26, 2021 at 9:03 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>> MOUSE_ATARI should depend on INPUT_KEYBOARD since ATARI_KBD_CORE
>> depends on INPUT_KEYBOARD. This prevents MOUSE_ATARI from
>> selecting ATARI_KBD_CORE when INPUT_KEYBOARD is not set/enabled.
>>
>> WARNING: unmet direct dependencies detected for ATARI_KBD_CORE
>> Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n]
>> Selected by [y]:
>> - MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y]
>>
>> Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Thanks for your patch!
>
>> --- linux-next-20210525.orig/drivers/input/mouse/Kconfig
>> +++ linux-next-20210525/drivers/input/mouse/Kconfig
>> @@ -348,6 +348,7 @@ config MOUSE_AMIGA
>>
>> config MOUSE_ATARI
>> tristate "Atari mouse"
>> + depends on INPUT_KEYBOARD
>> depends on ATARI
>> select ATARI_KBD_CORE
>> help
> It looks like arch/m68k/atari/atakeyb.c doesn't use anything from the
> input subsystem, so I think you can move the ATARI_KBD_CORE symbol
> outside the "if INPUT_KEYBOARD" section instead.
Correct - while we're at it, what about moving it to
arch/m68k/Kconfig.machine?
Cheers,
Michael
>
> Gr{oetje,eeting}s,
>
> Geert
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MOUSE_ATARI: fix kconfig unmet dependency warning
2021-05-26 7:03 [PATCH] MOUSE_ATARI: fix kconfig unmet dependency warning Randy Dunlap
2021-05-26 7:20 ` Geert Uytterhoeven
@ 2021-05-26 19:16 ` Michael Schmitz
1 sibling, 0 replies; 4+ messages in thread
From: Michael Schmitz @ 2021-05-26 19:16 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Michael Schmitz, Roman Zippel, Geert Uytterhoeven,
Dmitry Torokhov, linux-input
Randy,
On 26/05/21 7:03 pm, Randy Dunlap wrote:
> MOUSE_ATARI should depend on INPUT_KEYBOARD since ATARI_KBD_CORE
> depends on INPUT_KEYBOARD. This prevents MOUSE_ATARI from
> selecting ATARI_KBD_CORE when INPUT_KEYBOARD is not set/enabled.
Right you are! Thanks for spotting this.
Reviewed-by: Michael Schmitz <schmitzmic@gmail.com>
>
> WARNING: unmet direct dependencies detected for ATARI_KBD_CORE
> Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n]
> Selected by [y]:
> - MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y]
>
> Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Michael Schmitz <schmitz@debian.org>
> Cc: Roman Zippel <zippel@linux-m68k.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: linux-input@vger.kernel.org
> ---
> drivers/input/mouse/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20210525.orig/drivers/input/mouse/Kconfig
> +++ linux-next-20210525/drivers/input/mouse/Kconfig
> @@ -348,6 +348,7 @@ config MOUSE_AMIGA
>
> config MOUSE_ATARI
> tristate "Atari mouse"
> + depends on INPUT_KEYBOARD
> depends on ATARI
> select ATARI_KBD_CORE
> help
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-26 19:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-26 7:03 [PATCH] MOUSE_ATARI: fix kconfig unmet dependency warning Randy Dunlap
2021-05-26 7:20 ` Geert Uytterhoeven
2021-05-26 19:27 ` Michael Schmitz
2021-05-26 19:16 ` Michael Schmitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).