* [PATCH] mmc: sdhci: remove unneeded (void *) casts in sdhci_(pltfm_)priv()
@ 2016-11-10 13:22 Masahiro Yamada
2016-11-11 12:43 ` Adrian Hunter
2016-11-18 14:28 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2016-11-10 13:22 UTC (permalink / raw)
To: linux-mmc; +Cc: Masahiro Yamada, linux-kernel, Adrian Hunter, Ulf Hansson
The type of host->private is (unsigned long *). No cast is needed
to return an opaque pointer.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/mmc/host/sdhci-pltfm.h | 2 +-
drivers/mmc/host/sdhci.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pltfm.h b/drivers/mmc/host/sdhci-pltfm.h
index 3280f20..957839d 100644
--- a/drivers/mmc/host/sdhci-pltfm.h
+++ b/drivers/mmc/host/sdhci-pltfm.h
@@ -106,7 +106,7 @@ extern int sdhci_pltfm_register(struct platform_device *pdev,
static inline void *sdhci_pltfm_priv(struct sdhci_pltfm_host *host)
{
- return (void *)host->private;
+ return host->private;
}
extern const struct dev_pm_ops sdhci_pltfm_pmops;
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index 766df17..9886115 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -655,7 +655,7 @@ extern struct sdhci_host *sdhci_alloc_host(struct device *dev,
static inline void *sdhci_priv(struct sdhci_host *host)
{
- return (void *)host->private;
+ return host->private;
}
extern void sdhci_card_detect(struct sdhci_host *host);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci: remove unneeded (void *) casts in sdhci_(pltfm_)priv()
2016-11-10 13:22 [PATCH] mmc: sdhci: remove unneeded (void *) casts in sdhci_(pltfm_)priv() Masahiro Yamada
@ 2016-11-11 12:43 ` Adrian Hunter
2016-11-18 14:28 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2016-11-11 12:43 UTC (permalink / raw)
To: Masahiro Yamada, linux-mmc; +Cc: linux-kernel, Ulf Hansson
On 10/11/16 15:22, Masahiro Yamada wrote:
> The type of host->private is (unsigned long *). No cast is needed
> to return an opaque pointer.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
>
> drivers/mmc/host/sdhci-pltfm.h | 2 +-
> drivers/mmc/host/sdhci.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pltfm.h b/drivers/mmc/host/sdhci-pltfm.h
> index 3280f20..957839d 100644
> --- a/drivers/mmc/host/sdhci-pltfm.h
> +++ b/drivers/mmc/host/sdhci-pltfm.h
> @@ -106,7 +106,7 @@ extern int sdhci_pltfm_register(struct platform_device *pdev,
>
> static inline void *sdhci_pltfm_priv(struct sdhci_pltfm_host *host)
> {
> - return (void *)host->private;
> + return host->private;
> }
>
> extern const struct dev_pm_ops sdhci_pltfm_pmops;
> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
> index 766df17..9886115 100644
> --- a/drivers/mmc/host/sdhci.h
> +++ b/drivers/mmc/host/sdhci.h
> @@ -655,7 +655,7 @@ extern struct sdhci_host *sdhci_alloc_host(struct device *dev,
>
> static inline void *sdhci_priv(struct sdhci_host *host)
> {
> - return (void *)host->private;
> + return host->private;
> }
>
> extern void sdhci_card_detect(struct sdhci_host *host);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci: remove unneeded (void *) casts in sdhci_(pltfm_)priv()
2016-11-10 13:22 [PATCH] mmc: sdhci: remove unneeded (void *) casts in sdhci_(pltfm_)priv() Masahiro Yamada
2016-11-11 12:43 ` Adrian Hunter
@ 2016-11-18 14:28 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2016-11-18 14:28 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-mmc, linux-kernel, Adrian Hunter
On 10 November 2016 at 14:22, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> The type of host->private is (unsigned long *). No cast is needed
> to return an opaque pointer.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
>
> drivers/mmc/host/sdhci-pltfm.h | 2 +-
> drivers/mmc/host/sdhci.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pltfm.h b/drivers/mmc/host/sdhci-pltfm.h
> index 3280f20..957839d 100644
> --- a/drivers/mmc/host/sdhci-pltfm.h
> +++ b/drivers/mmc/host/sdhci-pltfm.h
> @@ -106,7 +106,7 @@ extern int sdhci_pltfm_register(struct platform_device *pdev,
>
> static inline void *sdhci_pltfm_priv(struct sdhci_pltfm_host *host)
> {
> - return (void *)host->private;
> + return host->private;
> }
>
> extern const struct dev_pm_ops sdhci_pltfm_pmops;
> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
> index 766df17..9886115 100644
> --- a/drivers/mmc/host/sdhci.h
> +++ b/drivers/mmc/host/sdhci.h
> @@ -655,7 +655,7 @@ extern struct sdhci_host *sdhci_alloc_host(struct device *dev,
>
> static inline void *sdhci_priv(struct sdhci_host *host)
> {
> - return (void *)host->private;
> + return host->private;
> }
>
> extern void sdhci_card_detect(struct sdhci_host *host);
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-18 14:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-10 13:22 [PATCH] mmc: sdhci: remove unneeded (void *) casts in sdhci_(pltfm_)priv() Masahiro Yamada
2016-11-11 12:43 ` Adrian Hunter
2016-11-18 14:28 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).