* [PATCH] amdkfd: always select MMU_NOTIFIER
@ 2018-03-28 15:53 Arnd Bergmann
2018-03-28 16:04 ` Christian König
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2018-03-28 15:53 UTC (permalink / raw)
To: Oded Gabbay, Alex Deucher, Christian König,
David (ChunMing) Zhou, David Airlie
Cc: Arnd Bergmann, Felix Kuehling, dri-devel, amd-gfx, linux-kernel
Building amdkfd without MMU notifiers is broken:
In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:
drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' has incomplete type
This adds the missing 'select MMU_NOTIFIER' line to make it build
cleanly all the time.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig
index ed2f06c9f346..5a26acb90e19 100644
--- a/drivers/gpu/drm/amd/amdkfd/Kconfig
+++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
@@ -4,6 +4,7 @@
config HSA_AMD
tristate "HSA kernel driver for AMD GPU devices"
+ select MMU_NOTIFIER
depends on DRM_AMDGPU && X86_64
imply AMD_IOMMU_V2
help
--
2.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] amdkfd: always select MMU_NOTIFIER
2018-03-28 15:53 [PATCH] amdkfd: always select MMU_NOTIFIER Arnd Bergmann
@ 2018-03-28 16:04 ` Christian König
2018-04-19 10:56 ` Anders Roxell
0 siblings, 1 reply; 5+ messages in thread
From: Christian König @ 2018-03-28 16:04 UTC (permalink / raw)
To: Arnd Bergmann, Oded Gabbay, Alex Deucher, David (ChunMing) Zhou,
David Airlie
Cc: Felix Kuehling, dri-devel, amd-gfx, linux-kernel
Am 28.03.2018 um 17:53 schrieb Arnd Bergmann:
> Building amdkfd without MMU notifiers is broken:
>
> In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:
> drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' has incomplete type
>
> This adds the missing 'select MMU_NOTIFIER' line to make it build
> cleanly all the time.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Christian König <christian.koenig@amd.com>, but I would wait
on what Felix says to that.
> ---
> drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig
> index ed2f06c9f346..5a26acb90e19 100644
> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig
> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
> @@ -4,6 +4,7 @@
>
> config HSA_AMD
> tristate "HSA kernel driver for AMD GPU devices"
> + select MMU_NOTIFIER
> depends on DRM_AMDGPU && X86_64
> imply AMD_IOMMU_V2
> help
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] amdkfd: always select MMU_NOTIFIER
2018-03-28 16:04 ` Christian König
@ 2018-04-19 10:56 ` Anders Roxell
2018-04-19 17:47 ` Felix Kuehling
0 siblings, 1 reply; 5+ messages in thread
From: Anders Roxell @ 2018-04-19 10:56 UTC (permalink / raw)
To: Christian König
Cc: Arnd Bergmann, Oded Gabbay, Alex Deucher, David (ChunMing) Zhou,
David Airlie, Felix Kuehling, dri-devel, amd-gfx,
Linux Kernel Mailing List
On 28 March 2018 at 18:04, Christian König <christian.koenig@amd.com> wrote:
> Am 28.03.2018 um 17:53 schrieb Arnd Bergmann:
>>
>> Building amdkfd without MMU notifiers is broken:
>>
>> In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:
>> drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier'
>> has incomplete type
>>
>> This adds the missing 'select MMU_NOTIFIER' line to make it build
>> cleanly all the time.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
>
> Acked-by: Christian König <christian.koenig@amd.com>, but I would wait on
> what Felix says to that.
Tested-by: Anders Roxell <anders.roxell@linaro.org>
Randy sent the same patch [1] and its still required.
Cheers,
Anders
[1] https://patchwork.kernel.org/patch/10340885/
>
>
>> ---
>> drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig
>> b/drivers/gpu/drm/amd/amdkfd/Kconfig
>> index ed2f06c9f346..5a26acb90e19 100644
>> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig
>> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
>> @@ -4,6 +4,7 @@
>> config HSA_AMD
>> tristate "HSA kernel driver for AMD GPU devices"
>> + select MMU_NOTIFIER
>> depends on DRM_AMDGPU && X86_64
>> imply AMD_IOMMU_V2
>> help
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] amdkfd: always select MMU_NOTIFIER
2018-04-19 10:56 ` Anders Roxell
@ 2018-04-19 17:47 ` Felix Kuehling
2018-04-24 9:53 ` Oded Gabbay
0 siblings, 1 reply; 5+ messages in thread
From: Felix Kuehling @ 2018-04-19 17:47 UTC (permalink / raw)
To: Anders Roxell, Christian König
Cc: Arnd Bergmann, Oded Gabbay, Alex Deucher, David (ChunMing) Zhou,
David Airlie, dri-devel, amd-gfx, Linux Kernel Mailing List
On 2018-04-19 06:56 AM, Anders Roxell wrote:
> On 28 March 2018 at 18:04, Christian König <christian.koenig@amd.com> wrote:
>> Am 28.03.2018 um 17:53 schrieb Arnd Bergmann:
>>> Building amdkfd without MMU notifiers is broken:
>>>
>>> In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:
>>> drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier'
>>> has incomplete type
>>>
>>> This adds the missing 'select MMU_NOTIFIER' line to make it build
>>> cleanly all the time.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Acked-by: Christian König <christian.koenig@amd.com>, but I would wait on
>> what Felix says to that.
> Tested-by: Anders Roxell <anders.roxell@linaro.org>
>
> Randy sent the same patch [1] and its still required.
>
> Cheers,
> Anders
> [1] https://patchwork.kernel.org/patch/10340885/
Yes, looks good. I think this probably broke when we relaxed the
dependency on iommuv2.
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Regards,
Felix
>
>>
>>> ---
>>> drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig
>>> b/drivers/gpu/drm/amd/amdkfd/Kconfig
>>> index ed2f06c9f346..5a26acb90e19 100644
>>> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig
>>> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
>>> @@ -4,6 +4,7 @@
>>> config HSA_AMD
>>> tristate "HSA kernel driver for AMD GPU devices"
>>> + select MMU_NOTIFIER
>>> depends on DRM_AMDGPU && X86_64
>>> imply AMD_IOMMU_V2
>>> help
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] amdkfd: always select MMU_NOTIFIER
2018-04-19 17:47 ` Felix Kuehling
@ 2018-04-24 9:53 ` Oded Gabbay
0 siblings, 0 replies; 5+ messages in thread
From: Oded Gabbay @ 2018-04-24 9:53 UTC (permalink / raw)
To: Felix Kuehling
Cc: Anders Roxell, Christian König, Arnd Bergmann, Alex Deucher,
David (ChunMing) Zhou, David Airlie, dri-devel, amd-gfx list,
Linux Kernel Mailing List
Thanks, but I took Randy's patch as it was earlier in my email queue.
Oded
On Thu, Apr 19, 2018 at 8:47 PM, Felix Kuehling <felix.kuehling@amd.com> wrote:
> On 2018-04-19 06:56 AM, Anders Roxell wrote:
>> On 28 March 2018 at 18:04, Christian König <christian.koenig@amd.com> wrote:
>>> Am 28.03.2018 um 17:53 schrieb Arnd Bergmann:
>>>> Building amdkfd without MMU notifiers is broken:
>>>>
>>>> In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:
>>>> drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier'
>>>> has incomplete type
>>>>
>>>> This adds the missing 'select MMU_NOTIFIER' line to make it build
>>>> cleanly all the time.
>>>>
>>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>>
>>> Acked-by: Christian König <christian.koenig@amd.com>, but I would wait on
>>> what Felix says to that.
>> Tested-by: Anders Roxell <anders.roxell@linaro.org>
>>
>> Randy sent the same patch [1] and its still required.
>>
>> Cheers,
>> Anders
>> [1] https://patchwork.kernel.org/patch/10340885/
> Yes, looks good. I think this probably broke when we relaxed the
> dependency on iommuv2.
>
> Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
>
> Regards,
> Felix
>
>
>>
>>>
>>>> ---
>>>> drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig
>>>> b/drivers/gpu/drm/amd/amdkfd/Kconfig
>>>> index ed2f06c9f346..5a26acb90e19 100644
>>>> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig
>>>> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
>>>> @@ -4,6 +4,7 @@
>>>> config HSA_AMD
>>>> tristate "HSA kernel driver for AMD GPU devices"
>>>> + select MMU_NOTIFIER
>>>> depends on DRM_AMDGPU && X86_64
>>>> imply AMD_IOMMU_V2
>>>> help
>>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-24 9:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-28 15:53 [PATCH] amdkfd: always select MMU_NOTIFIER Arnd Bergmann
2018-03-28 16:04 ` Christian König
2018-04-19 10:56 ` Anders Roxell
2018-04-19 17:47 ` Felix Kuehling
2018-04-24 9:53 ` Oded Gabbay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).