[PATCH] regulator: core: fixup regulator_is_equal() helper

[PATCH] regulator: core: fixup regulator_is_equal() helper

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

commit b059b7e0ec320 ("regulator: core: Add regulator_is_equal() helper")
added regulator_is_equal() helper.
But it has unneeded ";" if CONFIG_REGULATOR was not defined.
Thus, we will have this error

linux/include/linux/regulator/consumer.h:600:1: error: expected \
identifier or '(' before '{' token
 {
 ^
linux/include/linux/regulator/consumer.h:599:1: warning: \
'regulator_is_equal' declared 'static' but never defined \
[-Wunused-function]
 regulator_is_equal(struct regulator *reg1, struct regulator *reg2);
 ^~~~~~~~~~~~~~~~~~

This patch fixup it.

Cc: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Igor Opaniuk <igor.opaniuk@toradex.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 include/linux/regulator/consumer.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/regulator/consumer.h b/include/linux/regulator/consumer.h
index 2c89d88..6a92fd3 100644
--- a/include/linux/regulator/consumer.h
+++ b/include/linux/regulator/consumer.h
@@ -596,7 +596,7 @@ regulator_bulk_set_supply_names(struct regulator_bulk_data *consumers,
 }
 
 static inline bool
-regulator_is_equal(struct regulator *reg1, struct regulator *reg2);
+regulator_is_equal(struct regulator *reg1, struct regulator *reg2)
 {
 	return false;
 }
-- 
2.7.4

Re: [PATCH] regulator: core: fixup regulator_is_equal() helper

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

On Wed, Jan 15, 2020 at 10:17:00AM +0900, Kuninori Morimoto wrote:
> 
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> commit b059b7e0ec320 ("regulator: core: Add regulator_is_equal() helper")
> added regulator_is_equal() helper.
> But it has unneeded ";" if CONFIG_REGULATOR was not defined.
> Thus, we will have this error

Thanks but Stephen already sent a fix.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] regulator: core: fixup regulator_is_equal() helper

[Marek Vasut]

On 1/15/20 3:12 PM, Mark Brown wrote:
> On Wed, Jan 15, 2020 at 10:17:00AM +0900, Kuninori Morimoto wrote:
>>
>> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>>
>> commit b059b7e0ec320 ("regulator: core: Add regulator_is_equal() helper")
>> added regulator_is_equal() helper.
>> But it has unneeded ";" if CONFIG_REGULATOR was not defined.
>> Thus, we will have this error
> 
> Thanks but Stephen already sent a fix.

Sorry for the mess again.

Re: [PATCH] regulator: core: fixup regulator_is_equal() helper

[Kuninori Morimoto]

Hi Mark, Marek

> >> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >>
> >> commit b059b7e0ec320 ("regulator: core: Add regulator_is_equal() helper")
> >> added regulator_is_equal() helper.
> >> But it has unneeded ";" if CONFIG_REGULATOR was not defined.
> >> Thus, we will have this error
> > 
> > Thanks but Stephen already sent a fix.
> 
> Sorry for the mess again.

I could confirm it on mark/for-5.6 branch.
Thank you about it !

Thank you for your help !!
Best regards
---
Kuninori Morimoto