linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] xen: xen-pciback: fix warning Using plain integer as NULL pointer
@ 2019-04-06 12:29 Hariprasad Kelam
  2019-04-06 19:03 ` Mukesh Ojha
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Hariprasad Kelam @ 2019-04-06 12:29 UTC (permalink / raw)
  To: Boris Ostrovsky, Juergen Gross, Stefano Stabellini,
	Gustavo A. R. Silva, xen-devel, linux-kernel

Changes passing function argument 0 to NULL to avoid below sparse
warning

 CHECK   drivers/xen/xen-pciback/xenbus.c
drivers/xen/xen-pciback/xenbus.c:700:51: warning: Using plain integer as
NULL pointer

Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
 drivers/xen/xen-pciback/xenbus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c
index 23f7f6e..833b2d2 100644
--- a/drivers/xen/xen-pciback/xenbus.c
+++ b/drivers/xen/xen-pciback/xenbus.c
@@ -697,7 +697,7 @@ static int xen_pcibk_xenbus_probe(struct xenbus_device *dev,
 	/* We need to force a call to our callback here in case
 	 * xend already configured us!
 	 */
-	xen_pcibk_be_watch(&pdev->be_watch, NULL, 0);
+	xen_pcibk_be_watch(&pdev->be_watch, NULL, NULL);
 
 out:
 	return err;
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] xen: xen-pciback: fix warning Using plain integer as NULL pointer
  2019-04-06 12:29 [PATCH] xen: xen-pciback: fix warning Using plain integer as NULL pointer Hariprasad Kelam
@ 2019-04-06 19:03 ` Mukesh Ojha
  2019-04-08  5:10 ` Juergen Gross
  2019-04-24 18:48 ` Boris Ostrovsky
  2 siblings, 0 replies; 4+ messages in thread
From: Mukesh Ojha @ 2019-04-06 19:03 UTC (permalink / raw)
  To: Hariprasad Kelam, Boris Ostrovsky, Juergen Gross,
	Stefano Stabellini, Gustavo A. R. Silva, xen-devel, linux-kernel


On 4/6/2019 5:59 PM, Hariprasad Kelam wrote:
> Changes passing function argument 0 to NULL to avoid below sparse
> warning
>
>   CHECK   drivers/xen/xen-pciback/xenbus.c
> drivers/xen/xen-pciback/xenbus.c:700:51: warning: Using plain integer as
> NULL pointer
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Cheers,
-Mukesh

> ---
>   drivers/xen/xen-pciback/xenbus.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c
> index 23f7f6e..833b2d2 100644
> --- a/drivers/xen/xen-pciback/xenbus.c
> +++ b/drivers/xen/xen-pciback/xenbus.c
> @@ -697,7 +697,7 @@ static int xen_pcibk_xenbus_probe(struct xenbus_device *dev,
>   	/* We need to force a call to our callback here in case
>   	 * xend already configured us!
>   	 */
> -	xen_pcibk_be_watch(&pdev->be_watch, NULL, 0);
> +	xen_pcibk_be_watch(&pdev->be_watch, NULL, NULL);
>   
>   out:
>   	return err;

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] xen: xen-pciback: fix warning Using plain integer as NULL pointer
  2019-04-06 12:29 [PATCH] xen: xen-pciback: fix warning Using plain integer as NULL pointer Hariprasad Kelam
  2019-04-06 19:03 ` Mukesh Ojha
@ 2019-04-08  5:10 ` Juergen Gross
  2019-04-24 18:48 ` Boris Ostrovsky
  2 siblings, 0 replies; 4+ messages in thread
From: Juergen Gross @ 2019-04-08  5:10 UTC (permalink / raw)
  To: Hariprasad Kelam, Boris Ostrovsky, Stefano Stabellini,
	Gustavo A. R. Silva, xen-devel, linux-kernel

On 06/04/2019 14:29, Hariprasad Kelam wrote:
> Changes passing function argument 0 to NULL to avoid below sparse
> warning
> 
>  CHECK   drivers/xen/xen-pciback/xenbus.c
> drivers/xen/xen-pciback/xenbus.c:700:51: warning: Using plain integer as
> NULL pointer
> 
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] xen: xen-pciback: fix warning Using plain integer as NULL pointer
  2019-04-06 12:29 [PATCH] xen: xen-pciback: fix warning Using plain integer as NULL pointer Hariprasad Kelam
  2019-04-06 19:03 ` Mukesh Ojha
  2019-04-08  5:10 ` Juergen Gross
@ 2019-04-24 18:48 ` Boris Ostrovsky
  2 siblings, 0 replies; 4+ messages in thread
From: Boris Ostrovsky @ 2019-04-24 18:48 UTC (permalink / raw)
  To: Hariprasad Kelam, Juergen Gross, Stefano Stabellini,
	Gustavo A. R. Silva, xen-devel, linux-kernel

On 4/6/19 8:29 AM, Hariprasad Kelam wrote:
> Changes passing function argument 0 to NULL to avoid below sparse
> warning
>
>  CHECK   drivers/xen/xen-pciback/xenbus.c
> drivers/xen/xen-pciback/xenbus.c:700:51: warning: Using plain integer as
> NULL pointer
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>

Applied to for-linus-5.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-04-24 18:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-06 12:29 [PATCH] xen: xen-pciback: fix warning Using plain integer as NULL pointer Hariprasad Kelam
2019-04-06 19:03 ` Mukesh Ojha
2019-04-08  5:10 ` Juergen Gross
2019-04-24 18:48 ` Boris Ostrovsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).