* [PATCH] ASoC: Freescale: Delete an error message for a failed memory allocation in three functions
@ 2017-08-11 13:32 SF Markus Elfring
2017-08-11 14:44 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2017-08-11 13:32 UTC (permalink / raw)
To: alsa-devel, linuxppc-dev, Fabio Estevam, Jaroslav Kysela,
Liam Girdwood, Mark Brown, Nicolin Chen, Takashi Iwai,
Timur Tabi, Xiubo Li
Cc: LKML, kernel-janitors
>From 885ccd6c63291dcd4854a0cbaab5188cdc3db805 Mon Sep 17 00:00:00 2001
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 11 Aug 2017 15:10:43 +0200
Subject: [PATCH] ASoC: Freescale: Delete an error message for a failed memory allocation in three functions
Omit an extra message for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
sound/soc/fsl/fsl_asrc_dma.c | 4 +---
sound/soc/fsl/fsl_dma.c | 1 -
sound/soc/fsl/fsl_ssi.c | 4 +---
3 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/sound/soc/fsl/fsl_asrc_dma.c b/sound/soc/fsl/fsl_asrc_dma.c
index 282d841840b1..2baf19608bd0 100644
--- a/sound/soc/fsl/fsl_asrc_dma.c
+++ b/sound/soc/fsl/fsl_asrc_dma.c
@@ -282,7 +282,5 @@ static int fsl_asrc_dma_startup(struct snd_pcm_substream *substream)
- if (!pair) {
- dev_err(dev, "failed to allocate pair\n");
+ if (!pair)
return -ENOMEM;
- }
pair->asrc_priv = asrc_priv;
diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c
index ccadefceeff2..0ce172f86d6c 100644
--- a/sound/soc/fsl/fsl_dma.c
+++ b/sound/soc/fsl/fsl_dma.c
@@ -907,5 +907,4 @@ static int fsl_soc_dma_probe(struct platform_device *pdev)
if (!dma) {
- dev_err(&pdev->dev, "could not allocate dma object\n");
of_node_put(ssi_np);
return -ENOMEM;
}
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 173cb8496641..64598d1183f8 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -1435,7 +1435,5 @@ static int fsl_ssi_probe(struct platform_device *pdev)
- if (!ssi_private) {
- dev_err(&pdev->dev, "could not allocate DAI object\n");
+ if (!ssi_private)
return -ENOMEM;
- }
ssi_private->soc = of_id->data;
ssi_private->dev = &pdev->dev;
--
2.14.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: Freescale: Delete an error message for a failed memory allocation in three functions
2017-08-11 13:32 [PATCH] ASoC: Freescale: Delete an error message for a failed memory allocation in three functions SF Markus Elfring
@ 2017-08-11 14:44 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2017-08-11 14:44 UTC (permalink / raw)
To: SF Markus Elfring, alsa-devel, linuxppc-dev, Fabio Estevam,
Jaroslav Kysela, Liam Girdwood, Mark Brown, Nicolin Chen,
Takashi Iwai, Timur Tabi, Xiubo Li
Cc: LKML, kernel-janitors
On Fri, 2017-08-11 at 15:32 +0200, SF Markus Elfring wrote:
> From 885ccd6c63291dcd4854a0cbaab5188cdc3db805 Mon Sep 17 00:00:00 2001
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 11 Aug 2017 15:10:43 +0200
> Subject: [PATCH] ASoC: Freescale: Delete an error message for a failed memory allocation in three functions
>
> Omit an extra message for a memory allocation failure in these functions.
>
> This issue was detected by using the Coccinelle software.
>
> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
This doesn't have anything to do with refactoring strings.
Just note that allocations without GFP_NOWARN do a dump_stack()
> diff --git a/sound/soc/fsl/fsl_asrc_dma.c b/sound/soc/fsl/fsl_asrc_dma.c
[]
> @@ -282,7 +282,5 @@ static int fsl_asrc_dma_startup(struct snd_pcm_substream *substream)
> - if (!pair) {
> - dev_err(dev, "failed to allocate pair\n");
> + if (!pair)
> return -ENOMEM;
> - }
Use normal diff output that shows 3 lines of context
above and below the patched lines.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-11 14:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-11 13:32 [PATCH] ASoC: Freescale: Delete an error message for a failed memory allocation in three functions SF Markus Elfring
2017-08-11 14:44 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).