* [PATCH] usbip: Fix USB device hang due to wrong enabling of scatter-gather
@ 2017-11-30 2:22 Yuyang Du
2017-11-30 15:00 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Yuyang Du @ 2017-11-30 2:22 UTC (permalink / raw)
To: shuah, valentina.manea.m
Cc: gregkh, k.opasiak, kstewart, linux-usb, linux-kernel, juan.zea,
Yuyang Du
The previous USB3 SuperSpeed enabling patches mistakenly enabled
URB scatter-gather chaining, which is actually not supported by
the VHCI HCD. This patch fixes that.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197867
Fixes: 03cd00d538a6feb ("usbip: vhci-hcd: Set the vhci structure up to work")
Reported-by: Juan Zea <juan.zea@qindel.com>
Signed-off-by: Yuyang Du <yuyang.du@intel.com>
---
drivers/usb/usbip/vhci_hcd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
index 713e941..6b3278c 100644
--- a/drivers/usb/usbip/vhci_hcd.c
+++ b/drivers/usb/usbip/vhci_hcd.c
@@ -1098,7 +1098,6 @@ static int hcd_name_to_id(const char *name)
static int vhci_setup(struct usb_hcd *hcd)
{
struct vhci *vhci = *((void **)dev_get_platdata(hcd->self.controller));
- hcd->self.sg_tablesize = ~0;
if (usb_hcd_is_primary_hcd(hcd)) {
vhci->vhci_hcd_hs = hcd_to_vhci_hcd(hcd);
vhci->vhci_hcd_hs->vhci = vhci;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usbip: Fix USB device hang due to wrong enabling of scatter-gather
2017-11-30 2:22 [PATCH] usbip: Fix USB device hang due to wrong enabling of scatter-gather Yuyang Du
@ 2017-11-30 15:00 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2017-11-30 15:00 UTC (permalink / raw)
To: Yuyang Du, valentina.manea.m
Cc: gregkh, k.opasiak, kstewart, linux-usb, linux-kernel, juan.zea,
Shuah Khan, Shuah Khan
On 11/29/2017 07:22 PM, Yuyang Du wrote:
> The previous USB3 SuperSpeed enabling patches mistakenly enabled
> URB scatter-gather chaining, which is actually not supported by
> the VHCI HCD. This patch fixes that.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197867
> Fixes: 03cd00d538a6feb ("usbip: vhci-hcd: Set the vhci structure up to work")
> Reported-by: Juan Zea <juan.zea@qindel.com>
> Signed-off-by: Yuyang Du <yuyang.du@intel.com>> ---
> drivers/usb/usbip/vhci_hcd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index 713e941..6b3278c 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -1098,7 +1098,6 @@ static int hcd_name_to_id(const char *name)
> static int vhci_setup(struct usb_hcd *hcd)
> {
> struct vhci *vhci = *((void **)dev_get_platdata(hcd->self.controller));
> - hcd->self.sg_tablesize = ~0;
> if (usb_hcd_is_primary_hcd(hcd)) {
> vhci->vhci_hcd_hs = hcd_to_vhci_hcd(hcd);
> vhci->vhci_hcd_hs->vhci = vhci;
>
This need to go into stable as well. It applies to 4.14
Acked-by: Shuah Khan <shuahkh@osg.samsung.com>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-30 15:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-30 2:22 [PATCH] usbip: Fix USB device hang due to wrong enabling of scatter-gather Yuyang Du
2017-11-30 15:00 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).