* [PATCH] dt-bindings: align SPI NOR node name with dtschema
@ 2022-04-07 14:34 Krzysztof Kozlowski
2022-04-07 14:52 ` Miquel Raynal
2022-04-07 15:15 ` Mark Brown
0 siblings, 2 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-07 14:34 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Rob Herring, Krzysztof Kozlowski, Mark Brown, Linus Walleij,
linux-mtd, devicetree, linux-kernel, linux-spi, linux-arm-kernel
Cc: Krzysztof Kozlowski
The node names should be generic and SPI NOR dtschema expects "flash".
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/mtd/hisilicon,fmc-spi-nor.txt | 2 +-
Documentation/devicetree/bindings/spi/spi-davinci.txt | 2 +-
Documentation/devicetree/bindings/spi/spi-pl022.yaml | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/mtd/hisilicon,fmc-spi-nor.txt b/Documentation/devicetree/bindings/mtd/hisilicon,fmc-spi-nor.txt
index 74981520d6dd..a99de13c7ccd 100644
--- a/Documentation/devicetree/bindings/mtd/hisilicon,fmc-spi-nor.txt
+++ b/Documentation/devicetree/bindings/mtd/hisilicon,fmc-spi-nor.txt
@@ -17,7 +17,7 @@ spi-nor-controller@10000000 {
reg = <0x10000000 0x1000>, <0x14000000 0x1000000>;
reg-names = "control", "memory";
clocks = <&clock HI3519_FMC_CLK>;
- spi-nor@0 {
+ flash@0 {
compatible = "jedec,spi-nor";
reg = <0>;
};
diff --git a/Documentation/devicetree/bindings/spi/spi-davinci.txt b/Documentation/devicetree/bindings/spi/spi-davinci.txt
index 200c7fc7b089..f012888656ec 100644
--- a/Documentation/devicetree/bindings/spi/spi-davinci.txt
+++ b/Documentation/devicetree/bindings/spi/spi-davinci.txt
@@ -78,7 +78,7 @@ spi0:spi@20bf0000 {
interrupts = <338>;
clocks = <&clkspi>;
- flash: n25q032@0 {
+ flash: flash@0 {
#address-cells = <1>;
#size-cells = <1>;
compatible = "st,m25p32";
diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
index bda45ff3d294..0e382119c64f 100644
--- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
@@ -143,7 +143,7 @@ examples:
<&dma_controller 24 0>;
dma-names = "rx", "tx";
- m25p80@1 {
+ flash@1 {
compatible = "st,m25p80";
reg = <1>;
spi-max-frequency = <12000000>;
--
2.32.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: align SPI NOR node name with dtschema
2022-04-07 14:34 [PATCH] dt-bindings: align SPI NOR node name with dtschema Krzysztof Kozlowski
@ 2022-04-07 14:52 ` Miquel Raynal
2022-04-07 15:15 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Miquel Raynal @ 2022-04-07 14:52 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Richard Weinberger, Vignesh Raghavendra, Rob Herring,
Krzysztof Kozlowski, Mark Brown, Linus Walleij, linux-mtd,
devicetree, linux-kernel, linux-spi, linux-arm-kernel
Hi Krzysztof,
krzysztof.kozlowski@linaro.org wrote on Thu, 7 Apr 2022 16:34:05 +0200:
> The node names should be generic and SPI NOR dtschema expects "flash".
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: align SPI NOR node name with dtschema
2022-04-07 14:34 [PATCH] dt-bindings: align SPI NOR node name with dtschema Krzysztof Kozlowski
2022-04-07 14:52 ` Miquel Raynal
@ 2022-04-07 15:15 ` Mark Brown
2022-04-07 15:23 ` Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: Mark Brown @ 2022-04-07 15:15 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Rob Herring, Krzysztof Kozlowski, Linus Walleij, linux-mtd,
devicetree, linux-kernel, linux-spi, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 562 bytes --]
On Thu, Apr 07, 2022 at 04:34:05PM +0200, Krzysztof Kozlowski wrote:
> The node names should be generic and SPI NOR dtschema expects "flash".
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/mtd/hisilicon,fmc-spi-nor.txt | 2 +-
> Documentation/devicetree/bindings/spi/spi-davinci.txt | 2 +-
> Documentation/devicetree/bindings/spi/spi-pl022.yaml | 2 +-
Acked-by: Mark Brown <broonie@kernel.org>
but it would be easier to split this into per subsystem stuff.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: align SPI NOR node name with dtschema
2022-04-07 15:15 ` Mark Brown
@ 2022-04-07 15:23 ` Krzysztof Kozlowski
2022-04-07 19:03 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-07 15:23 UTC (permalink / raw)
To: Mark Brown
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Rob Herring, Krzysztof Kozlowski, Linus Walleij, linux-mtd,
devicetree, linux-kernel, linux-spi, linux-arm-kernel
On 07/04/2022 17:15, Mark Brown wrote:
> On Thu, Apr 07, 2022 at 04:34:05PM +0200, Krzysztof Kozlowski wrote:
>> The node names should be generic and SPI NOR dtschema expects "flash".
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> Documentation/devicetree/bindings/mtd/hisilicon,fmc-spi-nor.txt | 2 +-
>> Documentation/devicetree/bindings/spi/spi-davinci.txt | 2 +-
>> Documentation/devicetree/bindings/spi/spi-pl022.yaml | 2 +-
>
> Acked-by: Mark Brown <broonie@kernel.org>
>
> but it would be easier to split this into per subsystem stuff.
With DTS changes I had 22 patches, so splitting is a trade-off. If
that's preferred (actually can reduce conflicts), I'll split it and send
a v2.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: align SPI NOR node name with dtschema
2022-04-07 15:23 ` Krzysztof Kozlowski
@ 2022-04-07 19:03 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2022-04-07 19:03 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Mark Brown, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Krzysztof Kozlowski, Linus Walleij,
linux-mtd, devicetree, linux-kernel, linux-spi, linux-arm-kernel
On Thu, Apr 07, 2022 at 05:23:40PM +0200, Krzysztof Kozlowski wrote:
> On 07/04/2022 17:15, Mark Brown wrote:
> > On Thu, Apr 07, 2022 at 04:34:05PM +0200, Krzysztof Kozlowski wrote:
> >> The node names should be generic and SPI NOR dtschema expects "flash".
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> >> Documentation/devicetree/bindings/mtd/hisilicon,fmc-spi-nor.txt | 2 +-
> >> Documentation/devicetree/bindings/spi/spi-davinci.txt | 2 +-
> >> Documentation/devicetree/bindings/spi/spi-pl022.yaml | 2 +-
> >
> > Acked-by: Mark Brown <broonie@kernel.org>
> >
> > but it would be easier to split this into per subsystem stuff.
>
> With DTS changes I had 22 patches, so splitting is a trade-off. If
> that's preferred (actually can reduce conflicts), I'll split it and send
> a v2.
I've applied it.
Really, I would have just fixed spi-pl022.yaml. In general, I'm not that
interested in taking fixes on the .txt bindings.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-07 19:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-07 14:34 [PATCH] dt-bindings: align SPI NOR node name with dtschema Krzysztof Kozlowski
2022-04-07 14:52 ` Miquel Raynal
2022-04-07 15:15 ` Mark Brown
2022-04-07 15:23 ` Krzysztof Kozlowski
2022-04-07 19:03 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).