From: "Shenhar, Talel" <talel@amazon.com>
To: Marc Zyngier <maz@kernel.org>
Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>, <arnd@arndb.de>,
<bp@alien8.de>, <mchehab@kernel.org>, <james.morse@arm.com>,
<davem@davemloft.net>, <gregkh@linuxfoundation.org>,
<paulmck@linux.ibm.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-edac@vger.kernel.org>,
<dwmw@amazon.co.uk>, <benh@kernel.crashing.org>,
<hhhawa@amazon.com>, <ronenk@amazon.com>, <jonnyc@amazon.com>,
<hanochu@amazon.com>, <amirkl@amazon.com>, <barakw@amazon.com>
Subject: Re: [UNVERIFIED SENDER] Re: [PATCH v4 2/2] soc: amazon: al-pos-edac: Introduce Amazon's Annapurna Labs POS EDAC driver
Date: Mon, 7 Oct 2019 14:34:03 +0300 [thread overview]
Message-ID: <6815f9e9-f250-bd62-33b3-e3ab30aa47e2@amazon.com> (raw)
In-Reply-To: <86k19gztil.wl-maz@kernel.org>
thanks for the review
On 10/7/2019 2:26 PM, Marc Zyngier wrote:
> On Thu, 03 Oct 2019 12:32:41 +0100,
> Talel Shenhar <talel@amazon.com> wrote:
>> + log1 = readl(al_pos->mmio_base + AL_POS_ERROR_LOG_1);
> I already commented on the misuse of strict accesses. Unless you can
> explain and document *why* you need the extra ordering, please use
> relaxed accesses.
agreeing on relaxed, shall be part of v5
>
>> +
>> + if (al_pos->irq > 0) {
>> + ret = devm_request_irq(&pdev->dev,
>> + al_pos->irq,
>> + al_pos_irq_handler,
>> + 0,
>> + pdev->name,
>> + pdev);
>> + if (ret != 0) {
>> + dev_err(&pdev->dev,
>> + "failed to register to irq %d (%d)\n",
>> + al_pos->irq, ret);
>> + goto err_remove_edac;
> Would it be worth continuing without interrupts? After all, the
> interrupt seems to be an optional part of the device...
indeed interrupts are optional, however, this is optional for some of
the systems.
in some cases (and some systems), this error event is critical and
should cause fast handling. for those, we define the interrupts.
so bottom line, i would like to keep this error in case of error in
interrupt.
>
> Thanks,
>
> M.
>
prev parent reply other threads:[~2019-10-07 11:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 11:32 [PATCH v4 0/2] Amazon's Annapurna Labs POS Driver Talel Shenhar
2019-10-03 11:32 ` [PATCH v4 1/2] dt-bindings: soc: al-pos: Amazon's Annapurna Labs POS Talel Shenhar
2019-10-04 15:05 ` Rob Herring
2019-10-06 9:10 ` Shenhar, Talel
2019-10-03 11:32 ` [PATCH v4 2/2] soc: amazon: al-pos-edac: Introduce Amazon's Annapurna Labs POS EDAC driver Talel Shenhar
2019-10-07 11:26 ` Marc Zyngier
2019-10-07 11:34 ` Shenhar, Talel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6815f9e9-f250-bd62-33b3-e3ab30aa47e2@amazon.com \
--to=talel@amazon.com \
--cc=amirkl@amazon.com \
--cc=arnd@arndb.de \
--cc=barakw@amazon.com \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=james.morse@arm.com \
--cc=jonnyc@amazon.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mchehab@kernel.org \
--cc=paulmck@linux.ibm.com \
--cc=robh+dt@kernel.org \
--cc=ronenk@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).