From: "Shenhar, Talel" <talel@amazon.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"Arnd Bergmann" <arnd@arndb.de>, Borislav Petkov <bp@alien8.de>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
James Morse <james.morse@arm.com>,
David Miller <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Paul E. McKenney" <paulmck@linux.ibm.com>,
<devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-edac <linux-edac@vger.kernel.org>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
"Hawa, Hanna" <hhhawa@amazon.com>,
"Krupnik, Ronen" <ronenk@amazon.com>,
Jonathan Chocron <jonnyc@amazon.com>,
"Hanoch, Uri" <hanochu@amazon.com>, <amirkl@amazon.com>,
"Wasserstrom, Barak" <barakw@amazon.com>
Subject: Re: [PATCH v4 1/2] dt-bindings: soc: al-pos: Amazon's Annapurna Labs POS
Date: Sun, 6 Oct 2019 12:10:50 +0300 [thread overview]
Message-ID: <ee5a0727-6cc0-062b-0797-20fecdf1a450@amazon.com> (raw)
In-Reply-To: <CAL_JsqJDJF7h=nSw3dkNF=H3ghJeLR=MUgrEh+qxw0jhDnfxFw@mail.gmail.com>
thanks for the review.
On 10/4/2019 6:05 PM, Rob Herring wrote:
> On Thu, Oct 3, 2019 at 6:33 AM Talel Shenhar <talel@amazon.com> wrote:
>
> Fails 'make dt_binding_check' (drop the '-'):
ack, shall be part of v5
>
>> +
>> +examples:
>> + - |
>> + al_pos_edac@f0070084 {
> edac@...
ack, shall be part of v5
>
>> + compatible = "amazon,al-pos-edac";
>> + reg = <0x0 0xf0070084 0x0 0x00000008>;
>> + interrupt-parent = <&amazon_system_fabric>;
>> + interrupts = <24 IRQ_TYPE_LEVEL_HIGH>;
> Not documented.
looks good?
interrupts:
description: Interrupt for the error event.
maxItems: 1
next prev parent reply other threads:[~2019-10-06 9:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 11:32 [PATCH v4 0/2] Amazon's Annapurna Labs POS Driver Talel Shenhar
2019-10-03 11:32 ` [PATCH v4 1/2] dt-bindings: soc: al-pos: Amazon's Annapurna Labs POS Talel Shenhar
2019-10-04 15:05 ` Rob Herring
2019-10-06 9:10 ` Shenhar, Talel [this message]
2019-10-03 11:32 ` [PATCH v4 2/2] soc: amazon: al-pos-edac: Introduce Amazon's Annapurna Labs POS EDAC driver Talel Shenhar
2019-10-07 11:26 ` Marc Zyngier
2019-10-07 11:34 ` [UNVERIFIED SENDER] " Shenhar, Talel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee5a0727-6cc0-062b-0797-20fecdf1a450@amazon.com \
--to=talel@amazon.com \
--cc=amirkl@amazon.com \
--cc=arnd@arndb.de \
--cc=barakw@amazon.com \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=james.morse@arm.com \
--cc=jonnyc@amazon.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mchehab@kernel.org \
--cc=paulmck@linux.ibm.com \
--cc=robh+dt@kernel.org \
--cc=ronenk@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).