* [PATCH] soc: amlogic: gx pm domain: add PM and OF dependencies
@ 2017-11-02 22:42 Arnd Bergmann
2017-11-03 14:59 ` Neil Armstrong
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-11-02 22:42 UTC (permalink / raw)
To: Kevin Hilman, Neil Armstrong, Arnd Bergmann, Martin Blumenstingl
Cc: linux-kernel
The new driver introduces harmless warnings:
warning: (PM_RMOBILE && ARCH_RCAR_GEN1 && ARCH_RCAR_GEN2 && ARCH_R7S72100 && MESON_GX_PM_DOMAINS) selects PM_GENERIC_DOMAINS which has unmet direct dependencies (PM)
warning: (MESON_GX_PM_DOMAINS) selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF)
This adds CONFIG_OF and CONFIG_PM dependencies to ensure it
will only be enabled in valid configurations.
Fixes: 75fcb5ca4b46 ("soc: amlogic: add Meson GX VPU Domains driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/soc/amlogic/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/amlogic/Kconfig b/drivers/soc/amlogic/Kconfig
index 1621bb25a1ea..b04f6e4aedbc 100644
--- a/drivers/soc/amlogic/Kconfig
+++ b/drivers/soc/amlogic/Kconfig
@@ -12,6 +12,7 @@ config MESON_GX_SOCINFO
config MESON_GX_PM_DOMAINS
bool "Amlogic Meson GX Power Domains driver"
depends on ARCH_MESON || COMPILE_TEST
+ depends on PM && OF
default ARCH_MESON
select PM_GENERIC_DOMAINS
select PM_GENERIC_DOMAINS_OF
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] soc: amlogic: gx pm domain: add PM and OF dependencies
2017-11-02 22:42 [PATCH] soc: amlogic: gx pm domain: add PM and OF dependencies Arnd Bergmann
@ 2017-11-03 14:59 ` Neil Armstrong
0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2017-11-03 14:59 UTC (permalink / raw)
To: Arnd Bergmann, Kevin Hilman, Martin Blumenstingl; +Cc: linux-kernel
On 02/11/2017 23:42, Arnd Bergmann wrote:
> The new driver introduces harmless warnings:
>
> warning: (PM_RMOBILE && ARCH_RCAR_GEN1 && ARCH_RCAR_GEN2 && ARCH_R7S72100 && MESON_GX_PM_DOMAINS) selects PM_GENERIC_DOMAINS which has unmet direct dependencies (PM)
> warning: (MESON_GX_PM_DOMAINS) selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF)
>
> This adds CONFIG_OF and CONFIG_PM dependencies to ensure it
> will only be enabled in valid configurations.
>
> Fixes: 75fcb5ca4b46 ("soc: amlogic: add Meson GX VPU Domains driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/soc/amlogic/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/amlogic/Kconfig b/drivers/soc/amlogic/Kconfig
> index 1621bb25a1ea..b04f6e4aedbc 100644
> --- a/drivers/soc/amlogic/Kconfig
> +++ b/drivers/soc/amlogic/Kconfig
> @@ -12,6 +12,7 @@ config MESON_GX_SOCINFO
> config MESON_GX_PM_DOMAINS
> bool "Amlogic Meson GX Power Domains driver"
> depends on ARCH_MESON || COMPILE_TEST
> + depends on PM && OF
> default ARCH_MESON
> select PM_GENERIC_DOMAINS
> select PM_GENERIC_DOMAINS_OF
>
Thanks for the fix
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-03 14:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-02 22:42 [PATCH] soc: amlogic: gx pm domain: add PM and OF dependencies Arnd Bergmann
2017-11-03 14:59 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).