From: Dilip Kota <eswara.kota@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: robh@kernel.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
daniel.schwierzeck@gmail.com, hauke@hauke-m.de,
andriy.shevchenko@intel.com, cheol.yong.kim@intel.com,
chuanhua.lei@linux.intel.com, qi-ming.wu@intel.com
Subject: Re: [PATCH 1/4] spi: lantiq: Synchronize interrupt handlers and transfers
Date: Wed, 29 Apr 2020 15:20:21 +0800 [thread overview]
Message-ID: <68948cb1-6c78-1545-45c6-5a95465b05e2@linux.intel.com> (raw)
In-Reply-To: <20200428100055.GB5677@sirena.org.uk>
On 4/28/2020 6:00 PM, Mark Brown wrote:
> On Tue, Apr 28, 2020 at 01:39:06PM +0800, Dilip Kota wrote:
>
>> Do you suggest to use different ISRs for multiple interrupt lines and single
>> ISR for single interrupt line? I see, this results in writing repetitive
>> code lines.
> It looks like the shared case is mainly a handler that calls the two
> other handlers?
Yes.
>
>> Does single ISR looks erroneous! Please let me know.
> The change was not entirely clear, I was having trouble convincing
> myself that all the transformations were OK partly because I kept on
> finding little extra changes in there and partly because there were
> several things going on. In theory it could work.
You want me to split this in to multiple patches?
Regards,
Dilip
next prev parent reply other threads:[~2020-04-29 7:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 10:42 [PATCH 0/4] spi: lantiq: Synchronize interrupts, transfers and add new features Dilip Kota
2020-04-24 10:42 ` [PATCH 1/4] spi: lantiq: Synchronize interrupt handlers and transfers Dilip Kota
2020-04-24 11:25 ` Mark Brown
2020-04-27 6:01 ` Dilip Kota
2020-04-27 13:45 ` Mark Brown
2020-04-28 5:39 ` Dilip Kota
2020-04-28 10:00 ` Mark Brown
2020-04-29 7:20 ` Dilip Kota [this message]
2020-04-29 12:27 ` Mark Brown
2020-04-27 21:52 ` Hauke Mehrtens
2020-04-28 6:03 ` Dilip Kota
2020-04-28 11:10 ` Daniel Schwierzeck
2020-04-28 11:30 ` Hauke Mehrtens
2020-04-29 8:22 ` Dilip Kota
2020-04-29 8:20 ` Dilip Kota
2020-04-29 12:13 ` Mark Brown
2020-05-04 10:15 ` Dilip Kota
2020-05-05 11:23 ` Mark Brown
2020-05-06 7:40 ` Dilip Kota
2020-07-16 9:36 ` Dilip Kota
2020-04-24 10:42 ` [PATCH 2/4] spi: lantiq: Dynamic configuration of interrupts and FIFO size Dilip Kota
2020-04-24 10:42 ` [PATCH 3/4] dt-bindings: spi: Add support to Lightning Mountain SoC Dilip Kota
2020-05-11 21:22 ` Rob Herring
2020-04-24 10:42 ` [PATCH 4/4] spi: lantiq: " Dilip Kota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68948cb1-6c78-1545-45c6-5a95465b05e2@linux.intel.com \
--to=eswara.kota@linux.intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=broonie@kernel.org \
--cc=cheol.yong.kim@intel.com \
--cc=chuanhua.lei@linux.intel.com \
--cc=daniel.schwierzeck@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hauke@hauke-m.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=qi-ming.wu@intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).