linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clocksource: Remove duplicated argument in arm_global_timer
@ 2021-06-15 11:54 Wan Jiabing
  2021-06-15 14:00 ` Patrice CHOTARD
  2021-06-18 16:03 ` [tip: timers/core] clocksource/drivers/arm_global_timer: " tip-bot2 for Wan Jiabing
  0 siblings, 2 replies; 3+ messages in thread
From: Wan Jiabing @ 2021-06-15 11:54 UTC (permalink / raw)
  To: Patrice Chotard, Daniel Lezcano, Thomas Gleixner,
	linux-arm-kernel, linux-kernel
  Cc: Wan Jiabing

Fix the following coccicheck warning:
drivers/clocksource/arm_global_timer.c:107:4-23: 
duplicated argument to & or |

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/clocksource/arm_global_timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/arm_global_timer.c b/drivers/clocksource/arm_global_timer.c
index 60a8047fd32e..fdf32a0c86d1 100644
--- a/drivers/clocksource/arm_global_timer.c
+++ b/drivers/clocksource/arm_global_timer.c
@@ -104,7 +104,7 @@ static void gt_compare_set(unsigned long delta, int periodic)
 	counter += delta;
 	ctrl = readl(gt_base + GT_CONTROL);
 	ctrl &= ~(GT_CONTROL_COMP_ENABLE | GT_CONTROL_IRQ_ENABLE |
-		  GT_CONTROL_AUTO_INC | GT_CONTROL_AUTO_INC);
+		  GT_CONTROL_AUTO_INC);
 	ctrl |= GT_CONTROL_TIMER_ENABLE;
 	writel_relaxed(ctrl, gt_base + GT_CONTROL);
 	writel_relaxed(lower_32_bits(counter), gt_base + GT_COMP0);
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] clocksource: Remove duplicated argument in arm_global_timer
  2021-06-15 11:54 [PATCH] clocksource: Remove duplicated argument in arm_global_timer Wan Jiabing
@ 2021-06-15 14:00 ` Patrice CHOTARD
  2021-06-18 16:03 ` [tip: timers/core] clocksource/drivers/arm_global_timer: " tip-bot2 for Wan Jiabing
  1 sibling, 0 replies; 3+ messages in thread
From: Patrice CHOTARD @ 2021-06-15 14:00 UTC (permalink / raw)
  To: Wan Jiabing, Daniel Lezcano, Thomas Gleixner, linux-arm-kernel,
	linux-kernel

Hi Wan

On 6/15/21 1:54 PM, Wan Jiabing wrote:
> Fix the following coccicheck warning:
> drivers/clocksource/arm_global_timer.c:107:4-23: 
> duplicated argument to & or |
> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>  drivers/clocksource/arm_global_timer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/arm_global_timer.c b/drivers/clocksource/arm_global_timer.c
> index 60a8047fd32e..fdf32a0c86d1 100644
> --- a/drivers/clocksource/arm_global_timer.c
> +++ b/drivers/clocksource/arm_global_timer.c
> @@ -104,7 +104,7 @@ static void gt_compare_set(unsigned long delta, int periodic)
>  	counter += delta;
>  	ctrl = readl(gt_base + GT_CONTROL);
>  	ctrl &= ~(GT_CONTROL_COMP_ENABLE | GT_CONTROL_IRQ_ENABLE |
> -		  GT_CONTROL_AUTO_INC | GT_CONTROL_AUTO_INC);
> +		  GT_CONTROL_AUTO_INC);
>  	ctrl |= GT_CONTROL_TIMER_ENABLE;
>  	writel_relaxed(ctrl, gt_base + GT_CONTROL);
>  	writel_relaxed(lower_32_bits(counter), gt_base + GT_COMP0);
> 

Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [tip: timers/core] clocksource/drivers/arm_global_timer: Remove duplicated argument in arm_global_timer
  2021-06-15 11:54 [PATCH] clocksource: Remove duplicated argument in arm_global_timer Wan Jiabing
  2021-06-15 14:00 ` Patrice CHOTARD
@ 2021-06-18 16:03 ` tip-bot2 for Wan Jiabing
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Wan Jiabing @ 2021-06-18 16:03 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Wan Jiabing, Patrice Chotard, Daniel Lezcano, x86, linux-kernel

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     f94bc2667fb204d7c131ac39d9ea342bd16116dc
Gitweb:        https://git.kernel.org/tip/f94bc2667fb204d7c131ac39d9ea342bd16116dc
Author:        Wan Jiabing <wanjiabing@vivo.com>
AuthorDate:    Tue, 15 Jun 2021 19:54:40 +08:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Wed, 16 Jun 2021 17:33:04 +02:00

clocksource/drivers/arm_global_timer: Remove duplicated argument in arm_global_timer

Fix the following coccicheck warning:

    drivers/clocksource/arm_global_timer.c:107:4-23:
    duplicated argument to & or |

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210615115440.8881-1-wanjiabing@vivo.com
---
 drivers/clocksource/arm_global_timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/arm_global_timer.c b/drivers/clocksource/arm_global_timer.c
index 68b1d14..44a61dc 100644
--- a/drivers/clocksource/arm_global_timer.c
+++ b/drivers/clocksource/arm_global_timer.c
@@ -104,7 +104,7 @@ static void gt_compare_set(unsigned long delta, int periodic)
 	counter += delta;
 	ctrl = readl(gt_base + GT_CONTROL);
 	ctrl &= ~(GT_CONTROL_COMP_ENABLE | GT_CONTROL_IRQ_ENABLE |
-		  GT_CONTROL_AUTO_INC | GT_CONTROL_AUTO_INC);
+		  GT_CONTROL_AUTO_INC);
 	ctrl |= GT_CONTROL_TIMER_ENABLE;
 	writel_relaxed(ctrl, gt_base + GT_CONTROL);
 	writel_relaxed(lower_32_bits(counter), gt_base + GT_COMP0);

^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-18 16:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-15 11:54 [PATCH] clocksource: Remove duplicated argument in arm_global_timer Wan Jiabing
2021-06-15 14:00 ` Patrice CHOTARD
2021-06-18 16:03 ` [tip: timers/core] clocksource/drivers/arm_global_timer: " tip-bot2 for Wan Jiabing

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).