* [PATCH] Add USB_QUIRK_DELAY_CTRL_MSG quirk for Corsair K70 RGB
@ 2019-01-02 18:37 Jack Stocker
2019-01-02 20:57 ` Danilo Krummrich
0 siblings, 1 reply; 3+ messages in thread
From: Jack Stocker @ 2019-01-02 18:37 UTC (permalink / raw)
Cc: Jack Stocker, Greg Kroah-Hartman, Kai-Heng Feng, Seth Forshee,
Thadeu Lima de Souza Cascardo, Harry Pan, Kamil Lulko,
Danilo Krummrich, linux-usb, linux-kernel
To match the Corsair Strafe RGB, the Corsair K70 RGB also requires
USB_QUIRK_DELAY_CTRL_MSG to completely resolve boot connection issues
discussed here: https://github.com/ckb-next/ckb-next/issues/42.
Otherwise roughly 1 in 10 boots the keyboard will fail to be detected.
Signed-off-by: Jack Stocker <jackstocker.93@gmail.com>
---
drivers/usb/core/quirks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 7909262..4a9267d 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -377,7 +377,8 @@ static const struct usb_device_id usb_quirk_list[] = {
USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
/* Corsair K70 RGB */
- { USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
+ { USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT |
+ USB_QUIRK_DELAY_CTRL_MSG },
/* Corsair Strafe RGB */
{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT |
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Add USB_QUIRK_DELAY_CTRL_MSG quirk for Corsair K70 RGB
2019-01-02 18:37 [PATCH] Add USB_QUIRK_DELAY_CTRL_MSG quirk for Corsair K70 RGB Jack Stocker
@ 2019-01-02 20:57 ` Danilo Krummrich
2019-01-03 21:56 ` [PATCH v2] " Jack Stocker
0 siblings, 1 reply; 3+ messages in thread
From: Danilo Krummrich @ 2019-01-02 20:57 UTC (permalink / raw)
To: Jack Stocker
Cc: Greg Kroah-Hartman, Kai-Heng Feng, Seth Forshee,
Thadeu Lima de Souza Cascardo, Harry Pan, Kamil Lulko, linux-usb,
linux-kernel
You're referring to this patch
cb88a0588717 ("usb: quirks: add control message delay for 1b1c:1b20")
I guess. Maybe you want to name it explicitly for better reference.
Acked-by: Danilo Krummrich <danilokrummrich@dk-develop.de>
On 2019-01-02 19:37, Jack Stocker wrote:
> To match the Corsair Strafe RGB, the Corsair K70 RGB also requires
> USB_QUIRK_DELAY_CTRL_MSG to completely resolve boot connection issues
> discussed here: https://github.com/ckb-next/ckb-next/issues/42.
> Otherwise roughly 1 in 10 boots the keyboard will fail to be detected.
>
> Signed-off-by: Jack Stocker <jackstocker.93@gmail.com>
> ---
> drivers/usb/core/quirks.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 7909262..4a9267d 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -377,7 +377,8 @@ static const struct usb_device_id usb_quirk_list[]
> = {
> USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
>
> /* Corsair K70 RGB */
> - { USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
> + { USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT |
> + USB_QUIRK_DELAY_CTRL_MSG },
>
> /* Corsair Strafe RGB */
> { USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT |
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] Add USB_QUIRK_DELAY_CTRL_MSG quirk for Corsair K70 RGB
2019-01-02 20:57 ` Danilo Krummrich
@ 2019-01-03 21:56 ` Jack Stocker
0 siblings, 0 replies; 3+ messages in thread
From: Jack Stocker @ 2019-01-03 21:56 UTC (permalink / raw)
Cc: Jack Stocker, Greg Kroah-Hartman, Kai-Heng Feng, Seth Forshee,
Thadeu Lima de Souza Cascardo, Danilo Krummrich, Harry Pan,
Kamil Lulko, linux-usb, linux-kernel
To match the Corsair Strafe RGB, the Corsair K70 RGB also requires
USB_QUIRK_DELAY_CTRL_MSG to completely resolve boot connection issues
discussed here: https://github.com/ckb-next/ckb-next/issues/42.
Otherwise roughly 1 in 10 boots the keyboard will fail to be detected.
Patch that applied delay control quirk for Corsair Strafe RGB:
cb88a0588717 ("usb: quirks: add control message delay for 1b1c:1b20")
Previous K70 RGB patch to add delay-init quirk:
7a1646d92257 ("Add delay-init quirk for Corsair K70 RGB keyboards")
Signed-off-by: Jack Stocker <jackstocker.93@gmail.com>
---
Changes in v2:
- Added references to previous patches that affect this change.
drivers/usb/core/quirks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 7909262..4a9267d 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -377,7 +377,8 @@ static const struct usb_device_id usb_quirk_list[] = {
USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
/* Corsair K70 RGB */
- { USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
+ { USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT |
+ USB_QUIRK_DELAY_CTRL_MSG },
/* Corsair Strafe RGB */
{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT |
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-03 21:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-02 18:37 [PATCH] Add USB_QUIRK_DELAY_CTRL_MSG quirk for Corsair K70 RGB Jack Stocker
2019-01-02 20:57 ` Danilo Krummrich
2019-01-03 21:56 ` [PATCH v2] " Jack Stocker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).