From: Denis Efremov <efremov@linux.com>
To: Dexuan-Linux Cui <dexuan.linux@gmail.com>,
Dexuan Cui <decui@microsoft.com>,
Michael Kelley <mikelley@microsoft.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-hyperv@vger.kernel.org,
Linux SCSI List <linux-scsi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: storvsc: Use kzfree() in storvsc_suspend()
Date: Fri, 5 Jun 2020 00:43:09 +0300 [thread overview]
Message-ID: <696a6af8-744d-01b5-4a37-5320887e9108@linux.com> (raw)
In-Reply-To: <CAA42JLat6Ern5_mztmoBX9-ONtmz=gZE3YUphY+njTa+A=efVw@mail.gmail.com>
>
> Hi Denis,
> When I added the function storvsc_suspend() several months ago, somehow I forgot
> to remove the unnecessary memset(). Sorry!
>
> The buffer is recreated in storvsc_resume() -> storvsc_connect_to_vsp() ->
> storvsc_channel_init() -> stor_device->stor_chns = kcalloc(...), so I believe
> the memset() can be safely removed.
I'm not sure that I understand your description. As for me, memset with 0 before
memory freeing is required only for sensitive information and it's completely
unrelated to memory zeroing during allocation with kzalloc/kcalloc.
If it's not a sensitive information then memset could be safely removed.
> Can you please make a v2 patch for it and Cc my corporate email "decui" (in To)?
Yes, of course. Could I add "Suggested-by"?
Thanks,
Denis
next prev parent reply other threads:[~2020-06-04 21:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 13:04 [PATCH] scsi: storvsc: Use kzfree() in storvsc_suspend() Denis Efremov
2020-06-04 17:05 ` Dexuan-Linux Cui
2020-06-04 21:43 ` Denis Efremov [this message]
2020-06-04 21:49 ` Dexuan Cui
2020-06-04 21:51 ` Dexuan Cui
2020-06-05 7:59 ` [PATCH] scsi: storvsc: Remove memset before memory freeing " Denis Efremov
2020-06-05 8:07 ` Dexuan Cui
2020-06-10 2:02 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=696a6af8-744d-01b5-4a37-5320887e9108@linux.com \
--to=efremov@linux.com \
--cc=decui@microsoft.com \
--cc=dexuan.linux@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mikelley@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).