From: Dexuan Cui <decui@microsoft.com>
To: Denis Efremov <efremov@linux.com>,
Michael Kelley <mikelley@microsoft.com>
Cc: "James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
Linux SCSI List <linux-scsi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] scsi: storvsc: Remove memset before memory freeing in storvsc_suspend()
Date: Fri, 5 Jun 2020 08:07:55 +0000 [thread overview]
Message-ID: <HK0P153MB03228CB6B766D5FF30FBF751BF860@HK0P153MB0322.APCP153.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20200605075934.8403-1-efremov@linux.com>
> From: Denis Efremov <efremov@linux.com>
> Sent: Friday, June 5, 2020 1:00 AM
> To: Dexuan Cui <decui@microsoft.com>; Michael Kelley
> <mikelley@microsoft.com>
> Cc: Denis Efremov <efremov@linux.com>; James E . J . Bottomley
> <jejb@linux.ibm.com>; Martin K . Petersen <martin.petersen@oracle.com>;
> linux-hyperv@vger.kernel.org; Linux SCSI List <linux-scsi@vger.kernel.org>;
> Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
> Subject: [PATCH] scsi: storvsc: Remove memset before memory freeing in
> storvsc_suspend()
>
> Remove memset with 0 for stor_device->stor_chns in storvsc_suspend()
> before the call to kfree() as the memory contains no sensitive information.
>
> Fixes: 56fb10585934 ("scsi: storvsc: Add the support of hibernation")
> Suggested-by: Dexuan Cui <decui@microsoft.com>
> Signed-off-by: Denis Efremov <efremov@linux.com>
> ---
> drivers/scsi/storvsc_drv.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 072ed8728657..2d90cddd8ac2 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -2035,9 +2035,6 @@ static int storvsc_suspend(struct hv_device
> *hv_dev)
>
> vmbus_close(hv_dev->channel);
>
> - memset(stor_device->stor_chns, 0,
> - num_possible_cpus() * sizeof(void *));
> -
> kfree(stor_device->stor_chns);
> stor_device->stor_chns = NULL;
>
> --
Denis, thank you for fixing this!
Reviewed-by: Dexuan Cui <decui@microsoft.com>
next prev parent reply other threads:[~2020-06-05 8:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 13:04 [PATCH] scsi: storvsc: Use kzfree() in storvsc_suspend() Denis Efremov
2020-06-04 17:05 ` Dexuan-Linux Cui
2020-06-04 21:43 ` Denis Efremov
2020-06-04 21:49 ` Dexuan Cui
2020-06-04 21:51 ` Dexuan Cui
2020-06-05 7:59 ` [PATCH] scsi: storvsc: Remove memset before memory freeing " Denis Efremov
2020-06-05 8:07 ` Dexuan Cui [this message]
2020-06-10 2:02 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HK0P153MB03228CB6B766D5FF30FBF751BF860@HK0P153MB0322.APCP153.PROD.OUTLOOK.COM \
--to=decui@microsoft.com \
--cc=efremov@linux.com \
--cc=jejb@linux.ibm.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mikelley@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).