From: "Mani, Rajmohan" <rajmohan.mani@intel.com>
To: Sakari Ailus <sakari.ailus@iki.fi>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>
Subject: RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver
Date: Sat, 10 Jun 2017 00:10:41 +0000 [thread overview]
Message-ID: <6F87890CF0F5204F892DEA1EF0D77A59725BED6B@FMSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <20170607211256.GF1019@valkosipuli.retiisi.org.uk>
Hi Sakari, Andy,
> Subject: Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation
> region driver
>
> On Wed, Jun 07, 2017 at 11:40:27PM +0300, Andy Shevchenko wrote:
> > On Wed, Jun 7, 2017 at 11:10 PM, Sakari Ailus <sakari.ailus@iki.fi> wrote:
> > > On Wed, Jun 07, 2017 at 04:40:13PM +0300, Andy Shevchenko wrote:
> > >> On Wed, Jun 7, 2017 at 3:15 PM, Sakari Ailus <sakari.ailus@iki.fi> wrote:
> > >> > On Tue, Jun 06, 2017 at 05:23:56PM +0300, Andy Shevchenko wrote:
> >
> > >> >> Follow the pattern, please, I suppose ti_pmic_tps68470.c
> > >>
> > >> Would it work for you?
> > >
> > > This is still a different driver from the tps68470 driver which is
> > > an MFD driver. For clarity, I'd keep pmic as part of the name (and
> > > I'd use tps68470_pmic_ prefix for internal symbols, too).
> > >
> > > As PMICs are typically linked to the kernel (vs. being modules),
> > > there's no issue with the module name. I would suppose few if any
> > > PMICs will be compiled as modules in general.
> > >
> > > It's not a big deal though. I'm fine either way.
> >
> > Okay, let's agree on tps68470_pmic for internal prefix and for file name?
>
> Ack. Thanks!
>
Ack
next prev parent reply other threads:[~2017-06-10 0:10 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 11:55 [PATCH v1 0/3] TPS68470 PMIC drivers Rajmohan Mani
2017-06-06 11:55 ` [PATCH v1 1/3] mfd: Add new mfd device TPS68470 Rajmohan Mani
2017-06-06 12:48 ` Heikki Krogerus
2017-06-09 22:04 ` Mani, Rajmohan
2017-06-06 12:59 ` Andy Shevchenko
2017-06-07 11:58 ` Sakari Ailus
2017-06-09 22:12 ` Mani, Rajmohan
2017-06-12 8:20 ` Lee Jones
2017-06-12 9:20 ` Mani, Rajmohan
2017-07-19 23:23 ` Mani, Rajmohan
2017-07-20 8:15 ` Lee Jones
2017-06-09 22:09 ` Mani, Rajmohan
2017-06-07 2:10 ` kbuild test robot
2017-06-07 10:07 ` kbuild test robot
2017-06-06 11:55 ` [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs Rajmohan Mani
2017-06-06 14:15 ` Andy Shevchenko
2017-06-11 3:49 ` Mani, Rajmohan
2017-06-11 11:30 ` Sakari Ailus
2017-06-11 13:40 ` Andy Shevchenko
2017-06-11 16:50 ` Sakari Ailus
2017-06-11 19:43 ` Andy Shevchenko
2017-06-12 9:17 ` Mani, Rajmohan
2017-06-12 9:29 ` Andy Shevchenko
2017-06-12 9:51 ` Mani, Rajmohan
2017-06-09 11:15 ` Linus Walleij
2017-06-11 5:04 ` Mani, Rajmohan
2017-06-12 0:18 ` Mani, Rajmohan
2017-06-06 11:55 ` [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver Rajmohan Mani
2017-06-06 14:23 ` Andy Shevchenko
2017-06-06 15:21 ` Hans de Goede
2017-06-09 22:20 ` Mani, Rajmohan
2017-06-07 12:15 ` Sakari Ailus
2017-06-07 13:40 ` Andy Shevchenko
2017-06-07 20:10 ` Sakari Ailus
2017-06-07 20:40 ` Andy Shevchenko
2017-06-07 21:12 ` Sakari Ailus
2017-06-09 23:38 ` Mani, Rajmohan
2017-06-10 0:10 ` Mani, Rajmohan [this message]
2017-06-08 7:03 ` Hans de Goede
2017-06-09 23:47 ` Mani, Rajmohan
2017-06-09 22:19 ` Mani, Rajmohan
2017-06-07 12:07 ` Sakari Ailus
2017-06-07 13:37 ` Andy Shevchenko
2017-06-07 20:06 ` Sakari Ailus
2017-06-10 0:07 ` Mani, Rajmohan
2017-06-10 0:09 ` Mani, Rajmohan
2017-06-10 0:04 ` Mani, Rajmohan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6F87890CF0F5204F892DEA1EF0D77A59725BED6B@FMSMSX114.amr.corp.intel.com \
--to=rajmohan.mani@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=gnurou@gmail.com \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).