From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Rajmohan Mani <rajmohan.mani@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs
Date: Tue, 6 Jun 2017 17:15:55 +0300 [thread overview]
Message-ID: <CAHp75Vc6PSDqc=Vxj2z-d49p+E-7tciunhki=8a7HPjQGuSwXQ@mail.gmail.com> (raw)
In-Reply-To: <1496750118-5570-3-git-send-email-rajmohan.mani@intel.com>
On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani <rajmohan.mani@intel.com> wrote:
> This patch adds support for TPS68470 GPIOs.
> There are 7 GPIOs and a few sensor related GPIOs.
> These GPIOs can be requested and configured as
> appropriate.
Besides my below comments, just put it here that I recommended earlier
to provide 2 GPIO chips (one per bank of GPIOs).
It's up to Linus to decide since you didn't follow the recommendation.
> +#include <linux/gpio.h>
> +#include <linux/gpio/machine.h>
These shouldn't be in the driver.
Instead use
#include <linux/gpio/driver.h>
> +#include <linux/mfd/tps68470.h>
> +#include <linux/module.h>
> +#include <linux/platform_device.h>
> + if (offset >= TPS68470_N_REGULAR_GPIO) {
> + offset -= TPS68470_N_REGULAR_GPIO;
> + reg = TPS68470_REG_SGPO;
> + }
Two GPIO chips makes this gone.
> +struct gpiod_lookup_table gpios_table = {
> + .dev_id = NULL,
> + .table = {
> + GPIO_LOOKUP("tps68470-gpio", 0, "gpio.0", GPIO_ACTIVE_HIGH),
> + GPIO_LOOKUP("tps68470-gpio", 1, "gpio.1", GPIO_ACTIVE_HIGH),
> + GPIO_LOOKUP("tps68470-gpio", 2, "gpio.2", GPIO_ACTIVE_HIGH),
> + GPIO_LOOKUP("tps68470-gpio", 3, "gpio.3", GPIO_ACTIVE_HIGH),
> + GPIO_LOOKUP("tps68470-gpio", 4, "gpio.4", GPIO_ACTIVE_HIGH),
> + GPIO_LOOKUP("tps68470-gpio", 5, "gpio.5", GPIO_ACTIVE_HIGH),
> + GPIO_LOOKUP("tps68470-gpio", 6, "gpio.6", GPIO_ACTIVE_HIGH),
> + GPIO_LOOKUP("tps68470-gpio", 7, "s_enable", GPIO_ACTIVE_HIGH),
> + GPIO_LOOKUP("tps68470-gpio", 8, "s_idle", GPIO_ACTIVE_HIGH),
> + GPIO_LOOKUP("tps68470-gpio", 9, "s_resetn", GPIO_ACTIVE_HIGH),
> + {},
> + },
> +};
This doesn't belong to the driver.
> +static int tps68470_gpio_probe(struct platform_device *pdev)
> +{
> + struct tps68470 *tps68470 = dev_get_drvdata(pdev->dev.parent);
> + struct tps68470_gpio_data *tps68470_gpio;
> + int i, ret;
unsingned int i;
> + ret = gpiochip_add(&tps68470_gpio->gc);
devm_ ?
> + gpiod_add_lookup_table(&gpios_table);
Doesn't belong to the driver either.
I suppose it's a part of MFD (patch 1)
> + /*
> + * Initialize all the GPIOs to 0, just to make sure all
> + * GPIOs start with known default values. This protects against
> + * any GPIOs getting set with a value of 1, after TPS68470 reset
So, this is hardware bug. Right? Or misconfiguration of the chip we may avoid?
> + */
> + for (i = 0; i < tps68470_gpio->gc.ngpio; i++)
> + tps68470_gpio_set(&tps68470_gpio->gc, i, 0);
> +
> + return ret;
> +}
> +
> +static int tps68470_gpio_remove(struct platform_device *pdev)
> +{
> + struct tps68470_gpio_data *tps68470_gpio = platform_get_drvdata(pdev);
> +
> + gpiod_remove_lookup_table(&gpios_table);
> + gpiochip_remove(&tps68470_gpio->gc);
> +
> + return 0;
> +}
Should gone after devm_ in use.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-06-06 14:15 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 11:55 [PATCH v1 0/3] TPS68470 PMIC drivers Rajmohan Mani
2017-06-06 11:55 ` [PATCH v1 1/3] mfd: Add new mfd device TPS68470 Rajmohan Mani
2017-06-06 12:48 ` Heikki Krogerus
2017-06-09 22:04 ` Mani, Rajmohan
2017-06-06 12:59 ` Andy Shevchenko
2017-06-07 11:58 ` Sakari Ailus
2017-06-09 22:12 ` Mani, Rajmohan
2017-06-12 8:20 ` Lee Jones
2017-06-12 9:20 ` Mani, Rajmohan
2017-07-19 23:23 ` Mani, Rajmohan
2017-07-20 8:15 ` Lee Jones
2017-06-09 22:09 ` Mani, Rajmohan
2017-06-07 2:10 ` kbuild test robot
2017-06-07 10:07 ` kbuild test robot
2017-06-06 11:55 ` [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs Rajmohan Mani
2017-06-06 14:15 ` Andy Shevchenko [this message]
2017-06-11 3:49 ` Mani, Rajmohan
2017-06-11 11:30 ` Sakari Ailus
2017-06-11 13:40 ` Andy Shevchenko
2017-06-11 16:50 ` Sakari Ailus
2017-06-11 19:43 ` Andy Shevchenko
2017-06-12 9:17 ` Mani, Rajmohan
2017-06-12 9:29 ` Andy Shevchenko
2017-06-12 9:51 ` Mani, Rajmohan
2017-06-09 11:15 ` Linus Walleij
2017-06-11 5:04 ` Mani, Rajmohan
2017-06-12 0:18 ` Mani, Rajmohan
2017-06-06 11:55 ` [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver Rajmohan Mani
2017-06-06 14:23 ` Andy Shevchenko
2017-06-06 15:21 ` Hans de Goede
2017-06-09 22:20 ` Mani, Rajmohan
2017-06-07 12:15 ` Sakari Ailus
2017-06-07 13:40 ` Andy Shevchenko
2017-06-07 20:10 ` Sakari Ailus
2017-06-07 20:40 ` Andy Shevchenko
2017-06-07 21:12 ` Sakari Ailus
2017-06-09 23:38 ` Mani, Rajmohan
2017-06-10 0:10 ` Mani, Rajmohan
2017-06-08 7:03 ` Hans de Goede
2017-06-09 23:47 ` Mani, Rajmohan
2017-06-09 22:19 ` Mani, Rajmohan
2017-06-07 12:07 ` Sakari Ailus
2017-06-07 13:37 ` Andy Shevchenko
2017-06-07 20:06 ` Sakari Ailus
2017-06-10 0:07 ` Mani, Rajmohan
2017-06-10 0:09 ` Mani, Rajmohan
2017-06-10 0:04 ` Mani, Rajmohan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vc6PSDqc=Vxj2z-d49p+E-7tciunhki=8a7HPjQGuSwXQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=gnurou@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rajmohan.mani@intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).