From: Thomas Zimmermann <tzimmermann@suse.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: javierm@redhat.com, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
dri-devel@lists.freedesktop.org, Ard Biesheuvel <ardb@kernel.org>,
Helge Deller <deller@gmx.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, Guo Ren <guoren@kernel.org>,
linux-riscv@lists.infradead.org, linux-csky@vger.kernel.org
Subject: Re: [PATCH 1/4] vgacon: rework Kconfig dependencies
Date: Fri, 7 Jul 2023 17:07:22 +0200 [thread overview]
Message-ID: <6a6baea8-c7ca-1399-97d8-b6cb8263829c@suse.de> (raw)
In-Reply-To: <20230707095415.1449376-1-arnd@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 2543 bytes --]
Hi,
for the whole series:
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Best regards
Thomas
Am 07.07.23 um 11:52 schrieb Arnd Bergmann:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The list of dependencies here is phrased as an opt-out, but this is missing
> a lot of architectures that don't actually support VGA consoles, and some
> of the entries are stale:
>
> - powerpc used to support VGA consoles in the old arch/ppc codebase, but
> the merged arch/powerpc never did
>
> - arm lists footbridge, integrator and netwinder, but netwinder is actually
> part of footbridge, and integrator does not appear to have an actual
> VGA hardware, or list it in its ATAG or DT.
>
> - mips has a few platforms (jazz, sibyte, and sni) that initialize
> screen_info, on everything else the console is selected but cannot
> actually work.
>
> - csky, hexgagon, loongarch, nios2, riscv and xtensa are not listed
> in the opt-out table and declare a screen_info to allow building
> vga_con, but this cannot work because the console is never selected.
>
> Replace this with an opt-in table that lists only the platforms that
> remain. This is effectively x86, plus a couple of historic workstation
> and server machines that reused parts of the x86 system architecture.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/video/console/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
> index a2a88d42edf0c..47c498defc211 100644
> --- a/drivers/video/console/Kconfig
> +++ b/drivers/video/console/Kconfig
> @@ -7,9 +7,9 @@ menu "Console display driver support"
>
> config VGA_CONSOLE
> bool "VGA text console" if EXPERT || !X86
> - depends on !4xx && !PPC_8xx && !SPARC && !M68K && !PARISC && !SUPERH && \
> - (!ARM || ARCH_FOOTBRIDGE || ARCH_INTEGRATOR || ARCH_NETWINDER) && \
> - !ARM64 && !ARC && !MICROBLAZE && !OPENRISC && !S390 && !UML
> + depends on ALPHA || IA64 || X86 || \
> + (ARM && ARCH_FOOTBRIDGE) || \
> + (MIPS && (MIPS_MALTA || SIBYTE_BCM112X || SIBYTE_SB1250 || SIBYTE_BCM1x80 || SNI_RM))
> select APERTURE_HELPERS if (DRM || FB || VFIO_PCI_CORE)
> default y
> help
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2023-07-07 15:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 9:52 [PATCH 1/4] vgacon: rework Kconfig dependencies Arnd Bergmann
2023-07-07 9:52 ` [PATCH 2/4] vgacon: rework screen_info #ifdef checks Arnd Bergmann
2023-07-07 13:40 ` Javier Martinez Canillas
2023-07-07 14:32 ` Arnd Bergmann
2023-07-07 15:27 ` Javier Martinez Canillas
2023-07-08 14:11 ` Thomas Bogendoerfer
2023-07-07 9:52 ` [PATCH 3/4] dummycon: limit Arm console size hack to footbridge Arnd Bergmann
2023-07-07 11:33 ` Linus Walleij
2023-07-07 14:27 ` Arnd Bergmann
2023-07-16 21:22 ` Linus Walleij
2023-07-07 13:41 ` Javier Martinez Canillas
2023-07-07 9:52 ` [PATCH 4/4] vgacon, arch/*: remove unused screen_info definitions Arnd Bergmann
2023-07-07 13:42 ` Javier Martinez Canillas
2023-07-10 3:38 ` Dinh Nguyen
2023-07-10 4:08 ` Max Filippov
2023-07-12 14:46 ` Palmer Dabbelt
2023-07-13 0:33 ` Guo Ren
2023-07-07 13:17 ` [PATCH 1/4] vgacon: rework Kconfig dependencies Javier Martinez Canillas
2023-07-07 15:07 ` Thomas Zimmermann [this message]
2023-08-01 16:55 ` Thomas Zimmermann
2023-08-01 17:05 ` Russell King (Oracle)
2023-08-04 20:55 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a6baea8-c7ca-1399-97d8-b6cb8263829c@suse.de \
--to=tzimmermann@suse.de \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=guoren@kernel.org \
--cc=javierm@redhat.com \
--cc=linux-csky@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).