From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
javierm@redhat.com, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
dri-devel@lists.freedesktop.org, Ard Biesheuvel <ardb@kernel.org>,
Helge Deller <deller@gmx.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Richard Henderson <richard.henderson@linaro.org>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org,
loongarch@lists.linux.dev, linux-mips@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 2/4] vgacon: rework screen_info #ifdef checks
Date: Sat, 8 Jul 2023 16:11:52 +0200 [thread overview]
Message-ID: <ZKluqG2ZqKtAmnEG@alpha.franken.de> (raw)
In-Reply-To: <20230707095415.1449376-2-arnd@kernel.org>
On Fri, Jul 07, 2023 at 11:52:24AM +0200, Arnd Bergmann wrote:
> diff --git a/arch/mips/jazz/setup.c b/arch/mips/jazz/setup.c
> index ee044261eb223..3c14548353e47 100644
> --- a/arch/mips/jazz/setup.c
> +++ b/arch/mips/jazz/setup.c
> @@ -76,7 +76,7 @@ void __init plat_mem_setup(void)
>
> _machine_restart = jazz_machine_restart;
>
> -#ifdef CONFIG_VT
> +#ifdef CONFIG_VGA_CONSOLE
> screen_info = (struct screen_info) {
> .orig_video_cols = 160,
> .orig_video_lines = 64,
that wssn't intended for VGA but for fbdev/g364fb, which doesn't use
it. So removing it is probably the best thing.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2023-07-08 14:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 9:52 [PATCH 1/4] vgacon: rework Kconfig dependencies Arnd Bergmann
2023-07-07 9:52 ` [PATCH 2/4] vgacon: rework screen_info #ifdef checks Arnd Bergmann
2023-07-07 13:40 ` Javier Martinez Canillas
2023-07-07 14:32 ` Arnd Bergmann
2023-07-07 15:27 ` Javier Martinez Canillas
2023-07-08 14:11 ` Thomas Bogendoerfer [this message]
2023-07-07 9:52 ` [PATCH 3/4] dummycon: limit Arm console size hack to footbridge Arnd Bergmann
2023-07-07 11:33 ` Linus Walleij
2023-07-07 14:27 ` Arnd Bergmann
2023-07-16 21:22 ` Linus Walleij
2023-07-07 13:41 ` Javier Martinez Canillas
2023-07-07 9:52 ` [PATCH 4/4] vgacon, arch/*: remove unused screen_info definitions Arnd Bergmann
2023-07-07 13:42 ` Javier Martinez Canillas
2023-07-10 3:38 ` Dinh Nguyen
2023-07-10 4:08 ` Max Filippov
2023-07-12 14:46 ` Palmer Dabbelt
2023-07-13 0:33 ` Guo Ren
2023-07-07 13:17 ` [PATCH 1/4] vgacon: rework Kconfig dependencies Javier Martinez Canillas
2023-07-07 15:07 ` Thomas Zimmermann
2023-08-01 16:55 ` Thomas Zimmermann
2023-08-01 17:05 ` Russell King (Oracle)
2023-08-04 20:55 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKluqG2ZqKtAmnEG@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=ink@jurassic.park.msu.ru \
--cc=javierm@redhat.com \
--cc=kernel@xen0n.name \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=mattst88@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=richard.henderson@linaro.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).