Re: [PATCH v16 08/40] gpu: host1x: Add initial runtime PM and OPP support

From: Marc Zyngier <maz@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: "Jon Hunter" <jonathanh@nvidia.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Viresh Kumar" <vireshk@kernel.org>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Peter De Schrijver" <pdeschrijver@nvidia.com>,
	"Mikko Perttunen" <mperttunen@nvidia.com>,
	"Lee Jones" <lee.jones@linaro.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Nishanth Menon" <nm@ti.com>,
	"Adrian Hunter" <adrian.hunter@intel.com>,
	"Michael Turquette" <mturquette@baylibre.com>,
	linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org,
	linux-mmc@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-clk@vger.kernel.org, "David Heidelberg" <david@ixit.cz>
Subject: Re: [PATCH v16 08/40] gpu: host1x: Add initial runtime PM and OPP support
Date: Mon, 31 Jan 2022 20:39:33 +0000	[thread overview]
Message-ID: <6adda63b4de6b55d11426ecbb08d6c51@kernel.org> (raw)
In-Reply-To: <40983f6e-92ee-40d4-861f-06faea0113fc@gmail.com>

Hi all,

On 2021-12-22 19:31, Dmitry Osipenko wrote:
> 22.12.2021 22:30, Jon Hunter пишет:
>> 
>> On 22/12/2021 19:01, Dmitry Osipenko wrote:
>> 
>> ...
>> 
>>> diff --git a/drivers/gpu/host1x/syncpt.c 
>>> b/drivers/gpu/host1x/syncpt.c
>>> index e08e331e46ae..8194826c9ce3 100644
>>> --- a/drivers/gpu/host1x/syncpt.c
>>> +++ b/drivers/gpu/host1x/syncpt.c
>>> @@ -137,6 +137,15 @@ void host1x_syncpt_restore(struct host1x *host)
>>>       struct host1x_syncpt *sp_base = host->syncpt;
>>>       unsigned int i;
>>> 
>>> +    for (i = 0; i < host->info->nb_pts; i++) {
>>> +        /*
>>> +         * Unassign syncpt from channels for purposes of Tegra186
>>> +         * syncpoint protection. This prevents any channel from
>>> +         * accessing it until it is reassigned.
>>> +         */
>>> +        host1x_hw_syncpt_assign_to_channel(host, sp_base + i, NULL);
>>> +    }
>>> +
>>>       for (i = 0; i < host1x_syncpt_nb_pts(host); i++)
>>>           host1x_hw_syncpt_restore(host, sp_base + i);
>>> 
>>> @@ -352,13 +361,6 @@ int host1x_syncpt_init(struct host1x *host)
>>>       for (i = 0; i < host->info->nb_pts; i++) {
>>>           syncpt[i].id = i;
>>>           syncpt[i].host = host;
>>> -
>>> -        /*
>>> -         * Unassign syncpt from channels for purposes of Tegra186
>>> -         * syncpoint protection. This prevents any channel from
>>> -         * accessing it until it is reassigned.
>>> -         */
>>> -        host1x_hw_syncpt_assign_to_channel(host, &syncpt[i], NULL);
>>>       }
>>> 
>>>       for (i = 0; i < host->info->nb_bases; i++)
>>> 
>> 
>> 
>> Thanks! This fixed it!
> 
> I'll prepare proper patch with yours t-b, thank you.

The fix has been in -next for some time now, but it still hasn't
made it into Linus' tree (at least not in -rc2).

Any hope for this to land -rc3?

Thanks,

      M.
-- 
Jazz is not dead. It just smells funny...