From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Melody Olvera <quic_molvera@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Georgi Djakov <djakov@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Odelu Kukatla <quic_okukatla@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/3] interconnect: qcom: Add QDU1000/QRU1000 interconnect driver
Date: Sun, 20 Nov 2022 13:19:37 +0100 [thread overview]
Message-ID: <6b68b7c2-e070-0a88-35ee-2060dcbdee91@wanadoo.fr> (raw)
In-Reply-To: <20221118182245.31035-4-quic_molvera@quicinc.com>
Le 18/11/2022 à 19:22, Melody Olvera a écrit :
> Add interconnect provider driver for Qualcomm QDU1000 and QRU1000
> platforms.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
> drivers/interconnect/qcom/Kconfig | 9 +
> drivers/interconnect/qcom/Makefile | 2 +
> drivers/interconnect/qcom/qdu1000.c | 1079 +++++++++++++++++++++++++++
> drivers/interconnect/qcom/qdu1000.h | 95 +++
> 4 files changed, 1185 insertions(+)
> create mode 100644 drivers/interconnect/qcom/qdu1000.c
> create mode 100644 drivers/interconnect/qcom/qdu1000.h
>
[...]
> +static int qnoc_probe(struct platform_device *pdev)
> +{
> + int ret;
> +
> + ret = qcom_icc_rpmh_probe(pdev);
> + if (ret)
> + dev_err(&pdev->dev, "failed to register ICC provider\n");
> +
> + return ret;
> +}
> +
> +static int qnoc_remove(struct platform_device *pdev)
> +{
> + struct qcom_icc_provider *qp = platform_get_drvdata(pdev);
> +
> + icc_nodes_remove(&qp->provider);
> + icc_provider_del(&qp->provider);
qcom_icc_rpmh_remove()?
(more future proof, less verbose and more consistent with
qcom_icc_rpmh_probe() in the probe)
CJ
> +
> + return 0;
> +}
> +
> +static const struct of_device_id qnoc_of_match[] = {
> + { .compatible = "qcom,qdu1000-clk-virt",
> + .data = &qdu1000_clk_virt
> + },
> + { .compatible = "qcom,qdu1000-gem-noc",
> + .data = &qdu1000_gem_noc
> + },
> + { .compatible = "qcom,qdu1000-mc-virt",
> + .data = &qdu1000_mc_virt
> + },
> + { .compatible = "qcom,qdu1000-system-noc",
> + .data = &qdu1000_system_noc
> + },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, qnoc_of_match);
> +
> +static struct platform_driver qnoc_driver = {
> + .probe = qnoc_probe,
> + .remove = qnoc_remove,
> + .driver = {
> + .name = "qnoc-qdu1000",
> + .of_match_table = qnoc_of_match,
> + },
> +};
[...]
next prev parent reply other threads:[~2022-11-20 12:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 18:22 [PATCH v4 0/3] Add interconnect support for QDU1000/QRU1000 SoCs Melody Olvera
2022-11-18 18:22 ` [PATCH v4 1/3] dt-bindings: interconnect: Add rpmh virt devices Melody Olvera
2022-11-20 11:13 ` Krzysztof Kozlowski
2022-11-21 17:39 ` Melody Olvera
2022-11-22 7:50 ` Krzysztof Kozlowski
2022-11-22 17:57 ` Melody Olvera
2022-11-24 10:30 ` Krzysztof Kozlowski
2022-11-28 17:25 ` Melody Olvera
2022-11-28 23:08 ` Melody Olvera
2022-11-28 23:14 ` Melody Olvera
2022-11-21 15:23 ` Georgi Djakov
2022-11-21 16:34 ` Krzysztof Kozlowski
2022-11-21 17:38 ` Melody Olvera
2022-11-18 18:22 ` [PATCH v4 2/3] dt-bindings: interconnect: Add QDU1000/QRU1000 devices Melody Olvera
2022-11-20 11:13 ` Krzysztof Kozlowski
2022-11-18 18:22 ` [PATCH v4 3/3] interconnect: qcom: Add QDU1000/QRU1000 interconnect driver Melody Olvera
2022-11-20 12:19 ` Christophe JAILLET [this message]
2022-11-21 17:55 ` Melody Olvera
2022-11-21 19:02 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b68b7c2-e070-0a88-35ee-2060dcbdee91@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_molvera@quicinc.com \
--cc=quic_okukatla@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).