From: Melody Olvera <quic_molvera@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Georgi Djakov <djakov@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Odelu Kukatla <quic_okukatla@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/3] dt-bindings: interconnect: Add rpmh virt devices
Date: Mon, 28 Nov 2022 15:08:38 -0800 [thread overview]
Message-ID: <cb6a434f-9dc1-d24e-4c4a-02a223c12619@quicinc.com> (raw)
In-Reply-To: <e538affc-5c43-9b40-f6c7-2ceb2fa2fec8@quicinc.com>
On 11/28/2022 9:25 AM, Melody Olvera wrote:
>
> On 11/24/2022 2:30 AM, Krzysztof Kozlowski wrote:
>> On 22/11/2022 18:57, Melody Olvera wrote:
>>>>>>> +
>>>>>>> +maintainers:
>>>>>>> + - Georgi Djakov <georgi.djakov@linaro.org>
>>>>>>> + - Odelu Kukatla <quic_okukatla@quicinc.com>
>>>>>>> +
>>>>>>> +description: |
>>>>>>> + RPMh interconnect providers support system bandwidth requirements through
>>>>>>> + RPMh hardware accelerators known as Bus Clock Manager (BCM). The provider is
>>>>>>> + able to communicate with the BCM through the Resource State Coordinator (RSC)
>>>>>>> + associated with each execution environment. Provider nodes must point to at
>>>>>>> + least one RPMh device child node pertaining to their RSC and each provider
>>>>>>> + can map to multiple RPMh resources. Virtual interconnect providers are not
>>>>>>> + controlled by AP and do not support QoS; they should not have associated
>>>>>>> + register regions.
>>>>>>> +
>>>>>>> +allOf:
>>>>>>> + - $ref: qcom,rpmh-common.yaml#
>>>>>>> +
>>>>>>> +properties:
>>>>>>> + compatible:
>>>>>>> + enum:
>>>>>>> + - qcom,qdu1000-clk-virt
>>>>>>> + - qcom,qdu1000-mc-virt
>>>>>>> + - qcom,sm8450-clk-virt
>>>>>>> + - qcom,sm8450-mc-virt
>>>>>> You should also move qcom,sdx65-mc-virt, qcom,sc8280xp-mc-virt,
>>>>>> qcom,sc8280xp-clk-virt and more.
>>>>> Ok. I wasn't sure since some of these entries don't seem to conform to
>>>>> these bindings, even though it seems they should.
>>>> I have impression that devices I listed conform to these bindings, this
>>>> is why I listed them. But if you are sure that they do not, then they
>>>> should not be moved.
>>> You're correct; those you listed do conform to the new bindings and should be moved.
>>> I also caught qcom,sc7280-clk-virt which needs to be moved. I'll add to the new bindings.
>> Actually let's wait a bit with this. For SM8550 we had an idea to move
>> interconnect to their own bindings file, because they will grow a bit
>> with allOf:if:then clauses.
>>
>> Maybe SM8450 and QDU1000 should also go to their own files which will
>> describe all their interconnects (the virt and the ones requiring clocks)?
>>
>> Apologies for bringing it late for your patches, but SM8550 is also
>> happening right now, so new things pop-up :)
> Yeah no worries. I can definitely make this change; if this is how we want to do
> things going forward I'm happy to oblige.
>
> Thanks,
> Melody
I think though for these PS, I'll stick to doing w QDU1000. So I'll have a file qcom,qdu1000-rpmh.yaml
and qcom,qdu1000-rpmh-virt.yaml
Thanks,
Melody
>> Best regards,
>> Krzysztof
>>
next prev parent reply other threads:[~2022-11-28 23:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 18:22 [PATCH v4 0/3] Add interconnect support for QDU1000/QRU1000 SoCs Melody Olvera
2022-11-18 18:22 ` [PATCH v4 1/3] dt-bindings: interconnect: Add rpmh virt devices Melody Olvera
2022-11-20 11:13 ` Krzysztof Kozlowski
2022-11-21 17:39 ` Melody Olvera
2022-11-22 7:50 ` Krzysztof Kozlowski
2022-11-22 17:57 ` Melody Olvera
2022-11-24 10:30 ` Krzysztof Kozlowski
2022-11-28 17:25 ` Melody Olvera
2022-11-28 23:08 ` Melody Olvera [this message]
2022-11-28 23:14 ` Melody Olvera
2022-11-21 15:23 ` Georgi Djakov
2022-11-21 16:34 ` Krzysztof Kozlowski
2022-11-21 17:38 ` Melody Olvera
2022-11-18 18:22 ` [PATCH v4 2/3] dt-bindings: interconnect: Add QDU1000/QRU1000 devices Melody Olvera
2022-11-20 11:13 ` Krzysztof Kozlowski
2022-11-18 18:22 ` [PATCH v4 3/3] interconnect: qcom: Add QDU1000/QRU1000 interconnect driver Melody Olvera
2022-11-20 12:19 ` Christophe JAILLET
2022-11-21 17:55 ` Melody Olvera
2022-11-21 19:02 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb6a434f-9dc1-d24e-4c4a-02a223c12619@quicinc.com \
--to=quic_molvera@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_okukatla@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).