From: Wayne Chang <waynec@nvidia.com>
To: Jonathan Hunter <jonathanh@nvidia.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
Thierry Reding <treding@nvidia.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>, Ajay Gupta <ajayg@nvidia.com>,
"kishon@ti.com" <kishon@ti.com>,
"vkoul@kernel.org" <vkoul@kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"balbi@kernel.org" <balbi@kernel.org>,
"mathias.nyman@intel.com" <mathias.nyman@intel.com>,
Jui Chang Kuo <jckuo@nvidia.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sing-Han Chen <singhanc@nvidia.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 07/11] i2c: nvidia-gpu: Replace ccgx to well-known regex
Date: Thu, 3 Nov 2022 11:36:55 +0000 [thread overview]
Message-ID: <6b7aa45f-15da-2948-0472-259d446a6039@nvidia.com> (raw)
In-Reply-To: <e63e9d49-318f-93ae-178f-93a7023538c1@nvidia.com>
On 11/1/22 23:07, Jon Hunter wrote:
>
> On 24/10/2022 08:41, Wayne Chang wrote:
>> ccgx is refer to the cypress cypd4226 typec controller.
>> Replace ccgx to well-known regex "cypress".
>>
>> Signed-off-by: Wayne Chang <waynec@nvidia.com>
>> ---
>> drivers/i2c/busses/i2c-nvidia-gpu.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c
>> b/drivers/i2c/busses/i2c-nvidia-gpu.c
>> index 12e330cd7635..0934f8ad7f49 100644
>> --- a/drivers/i2c/busses/i2c-nvidia-gpu.c
>> +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c
>> @@ -260,7 +260,7 @@ MODULE_DEVICE_TABLE(pci, gpu_i2c_ids);
>> static const struct property_entry ccgx_props[] = {
>> /* Use FW built for NVIDIA (nv) only */
>> - PROPERTY_ENTRY_U16("ccgx,firmware-build", ('n' << 8) | 'v'),
>> + PROPERTY_ENTRY_U16("cypress,firmware-build", ('n' << 8) | 'v'),
>> { }
>> };
>
>
> Could we change this to be PROPERTY_ENTRY_STRING instead of
> PROPERTY_ENTRY_U16? The benefit of this would be to allow us to use a
> proper string identifier in device-tree for the Tegra devices which is
> more flexible and descriptive.
>
> So given that this is for NVIDIA GPUs, we could simply make this ...
>
> PROPERTY_ENTRY_STRING("cypress,firmware-build", "nvidia,gpu"),
>
> Then in the ucsi_ccg.c driver, when we read the device property
> "cypress,firmware-build", if it is 'nvidia,gpu' then we set the
> uc->fw_build variable to CCG_FW_BUILD_NVIDIA.
>
Yes, it should be nice to have the change.
Thanks for the review.
I'll make the changes and using string instead of u16 in the next patch
series.
thanks,
Wayne.
> Jon
>
next prev parent reply other threads:[~2022-11-03 11:37 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 7:41 [PATCH 00/11] Enable USB host and device functions on Jetson Wayne Chang
2022-10-24 7:41 ` [PATCH 01/11] dt-bindings: usb: tegra-xudc: Add Tegra234 XUSB controller support Wayne Chang
2022-10-25 23:24 ` Rob Herring
2022-11-03 10:36 ` Wayne Chang
2022-10-24 7:41 ` [PATCH 02/11] dt-bindings: usb: Add NVIDIA Tegra XUSB host controller binding Wayne Chang
2022-10-24 13:30 ` Rob Herring
2022-10-24 15:58 ` Jon Hunter
2022-10-24 14:54 ` Rob Herring
2022-10-25 8:02 ` Wayne Chang
2022-10-28 2:19 ` Krzysztof Kozlowski
2022-10-28 9:25 ` Jon Hunter
2022-10-28 11:07 ` Jon Hunter
2022-10-28 11:30 ` Thierry Reding
2022-11-03 10:24 ` Wayne Chang
2022-10-24 7:41 ` [PATCH 03/11] dt-bindings: usb: Add binding for Cypress cypd4226 I2C driver Wayne Chang
2022-10-26 1:07 ` Rob Herring
2022-10-26 7:13 ` Jon Hunter
2022-10-28 12:31 ` Thierry Reding
2022-10-28 12:42 ` Jon Hunter
2022-10-28 14:07 ` Thierry Reding
2022-11-03 10:47 ` Wayne Chang
2022-10-24 7:41 ` [PATCH 04/11] arm64: tegra: Enable XUSB host and device on Jetson AGX Orin Wayne Chang
2022-10-28 2:23 ` Krzysztof Kozlowski
2022-10-28 9:33 ` Jon Hunter
2022-10-28 11:27 ` Krzysztof Kozlowski
2022-10-28 11:34 ` Jon Hunter
2022-10-28 12:38 ` Thierry Reding
2022-10-28 21:48 ` Krzysztof Kozlowski
2022-10-24 7:41 ` [PATCH 05/11] usb: typec: ucsi_ccg: Add OF support Wayne Chang
2022-10-24 7:41 ` [PATCH 06/11] usb: typec: ucsi_ccg: Replace ccgx to well-known regex Wayne Chang
2022-10-24 8:01 ` Heikki Krogerus
2022-10-24 8:29 ` Felipe Balbi
2022-10-24 8:46 ` Heikki Krogerus
2022-10-25 7:26 ` Wayne Chang
2022-10-24 7:41 ` [PATCH 07/11] i2c: nvidia-gpu: " Wayne Chang
2022-11-01 15:07 ` Jon Hunter
2022-11-03 11:36 ` Wayne Chang [this message]
2022-10-24 7:41 ` [PATCH 08/11] phy: tegra: xusb: Disable trk clk when not using Wayne Chang
2022-11-05 14:58 ` Vinod Koul
2022-11-07 10:37 ` Wayne Chang
2022-10-24 7:41 ` [PATCH 09/11] phy: tegra: xusb: Add Tegra234 support Wayne Chang
2022-10-28 12:56 ` Thierry Reding
2022-11-03 11:42 ` Wayne Chang
2022-11-05 15:01 ` Vinod Koul
2022-11-07 10:36 ` Wayne Chang
2022-10-24 7:41 ` [PATCH 10/11] usb: host: xhci-tegra: Add Tegra234 XHCI support Wayne Chang
2022-10-28 13:39 ` Thierry Reding
2022-11-01 14:53 ` Jon Hunter
2022-11-03 11:35 ` Wayne Chang
2022-10-24 7:41 ` [PATCH 11/11] usb: gadget: tegra-xudc: Add Tegra234 support Wayne Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b7aa45f-15da-2948-0472-259d446a6039@nvidia.com \
--to=waynec@nvidia.com \
--cc=ajayg@nvidia.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=singhanc@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).