From: Thierry Reding <thierry.reding@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Jon Hunter <jonathanh@nvidia.com>,
Wayne Chang <waynec@nvidia.com>,
gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, treding@nvidia.com,
heikki.krogerus@linux.intel.com, ajayg@nvidia.com, kishon@ti.com,
vkoul@kernel.org, p.zabel@pengutronix.de, balbi@kernel.org,
mathias.nyman@intel.com, jckuo@nvidia.com,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, singhanc@nvidia.com,
linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 04/11] arm64: tegra: Enable XUSB host and device on Jetson AGX Orin
Date: Fri, 28 Oct 2022 14:38:43 +0200 [thread overview]
Message-ID: <Y1vNU1KeUH8LvG0r@orome> (raw)
In-Reply-To: <5676bcd2-14fc-4e1d-643e-89e575d190c3@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]
On Fri, Oct 28, 2022 at 07:27:09AM -0400, Krzysztof Kozlowski wrote:
> On 28/10/2022 05:33, Jon Hunter wrote:
> >>> + ucsi_ccg: ucsi_ccg@8 {
> >>
> >> No underscores in node names.
> >>
> >>> + compatible = "cypress,cypd4226";
> >>> + cypress,firmware-build = "gn";
> >>> + interrupt-parent = <&gpio>;
> >>> + interrupts = <TEGRA234_MAIN_GPIO(Y, 4) IRQ_TYPE_LEVEL_LOW>;
> >>> + reg = <0x08>;
> >>> + status = "okay";
> >>
> >> The pattern of redefining full path in Tegra is confusing - I have no
> >> clue which of these status=okay are correct which are redundant.
> >>
> >> Do you?
> >
> > I understand you may not like this approach, however, this comment is
> > not really relevant to just this patch, but a general comment. But yes
> > we will ensure that this is correct.
> >
>
> Just to clarify - this status looks redundant, but I have no way to tell
> for sure...
But that's independent of whether we specify this using the full path or
reference the node by label, isn't it? The only way to make sure that a
status = "okay" is not redundant is by manual inspection. I don't know
of an automated way to do that. Perhaps it's something that could be
added as a check to DTC?
In this particular case I don't think the status is needed. As Jon
mentioned, this device is first defined here and status = "okay" is the
default, so this is redundant.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-10-28 12:39 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 7:41 [PATCH 00/11] Enable USB host and device functions on Jetson Wayne Chang
2022-10-24 7:41 ` [PATCH 01/11] dt-bindings: usb: tegra-xudc: Add Tegra234 XUSB controller support Wayne Chang
2022-10-25 23:24 ` Rob Herring
2022-11-03 10:36 ` Wayne Chang
2022-10-24 7:41 ` [PATCH 02/11] dt-bindings: usb: Add NVIDIA Tegra XUSB host controller binding Wayne Chang
2022-10-24 13:30 ` Rob Herring
2022-10-24 15:58 ` Jon Hunter
2022-10-24 14:54 ` Rob Herring
2022-10-25 8:02 ` Wayne Chang
2022-10-28 2:19 ` Krzysztof Kozlowski
2022-10-28 9:25 ` Jon Hunter
2022-10-28 11:07 ` Jon Hunter
2022-10-28 11:30 ` Thierry Reding
2022-11-03 10:24 ` Wayne Chang
2022-10-24 7:41 ` [PATCH 03/11] dt-bindings: usb: Add binding for Cypress cypd4226 I2C driver Wayne Chang
2022-10-26 1:07 ` Rob Herring
2022-10-26 7:13 ` Jon Hunter
2022-10-28 12:31 ` Thierry Reding
2022-10-28 12:42 ` Jon Hunter
2022-10-28 14:07 ` Thierry Reding
2022-11-03 10:47 ` Wayne Chang
2022-10-24 7:41 ` [PATCH 04/11] arm64: tegra: Enable XUSB host and device on Jetson AGX Orin Wayne Chang
2022-10-28 2:23 ` Krzysztof Kozlowski
2022-10-28 9:33 ` Jon Hunter
2022-10-28 11:27 ` Krzysztof Kozlowski
2022-10-28 11:34 ` Jon Hunter
2022-10-28 12:38 ` Thierry Reding [this message]
2022-10-28 21:48 ` Krzysztof Kozlowski
2022-10-24 7:41 ` [PATCH 05/11] usb: typec: ucsi_ccg: Add OF support Wayne Chang
2022-10-24 7:41 ` [PATCH 06/11] usb: typec: ucsi_ccg: Replace ccgx to well-known regex Wayne Chang
2022-10-24 8:01 ` Heikki Krogerus
2022-10-24 8:29 ` Felipe Balbi
2022-10-24 8:46 ` Heikki Krogerus
2022-10-25 7:26 ` Wayne Chang
2022-10-24 7:41 ` [PATCH 07/11] i2c: nvidia-gpu: " Wayne Chang
2022-11-01 15:07 ` Jon Hunter
2022-11-03 11:36 ` Wayne Chang
2022-10-24 7:41 ` [PATCH 08/11] phy: tegra: xusb: Disable trk clk when not using Wayne Chang
2022-11-05 14:58 ` Vinod Koul
2022-11-07 10:37 ` Wayne Chang
2022-10-24 7:41 ` [PATCH 09/11] phy: tegra: xusb: Add Tegra234 support Wayne Chang
2022-10-28 12:56 ` Thierry Reding
2022-11-03 11:42 ` Wayne Chang
2022-11-05 15:01 ` Vinod Koul
2022-11-07 10:36 ` Wayne Chang
2022-10-24 7:41 ` [PATCH 10/11] usb: host: xhci-tegra: Add Tegra234 XHCI support Wayne Chang
2022-10-28 13:39 ` Thierry Reding
2022-11-01 14:53 ` Jon Hunter
2022-11-03 11:35 ` Wayne Chang
2022-10-24 7:41 ` [PATCH 11/11] usb: gadget: tegra-xudc: Add Tegra234 support Wayne Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1vNU1KeUH8LvG0r@orome \
--to=thierry.reding@gmail.com \
--cc=ajayg@nvidia.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=singhanc@nvidia.com \
--cc=treding@nvidia.com \
--cc=vkoul@kernel.org \
--cc=waynec@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).