* [PATCH] virtio: remove export for virtio_config_{enable, disable}
@ 2021-02-20 16:28 Xianting Tian
2021-02-22 3:45 ` Jason Wang
2021-02-22 15:27 ` Stefano Garzarella
0 siblings, 2 replies; 4+ messages in thread
From: Xianting Tian @ 2021-02-20 16:28 UTC (permalink / raw)
To: mst, jasowang; +Cc: guoren, virtualization, linux-kernel
virtio_config_enable(), virtio_config_disable() are only used inside
drivers/virtio/virtio.c, so it doesn't need export the symbols.
Signed-off-by: Xianting Tian <xianting_tian@126.com>
---
drivers/virtio/virtio.c | 6 ++----
include/linux/virtio.h | 2 --
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index 42e09cc..4b15c00 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -141,15 +141,14 @@ void virtio_config_changed(struct virtio_device *dev)
}
EXPORT_SYMBOL_GPL(virtio_config_changed);
-void virtio_config_disable(struct virtio_device *dev)
+static void virtio_config_disable(struct virtio_device *dev)
{
spin_lock_irq(&dev->config_lock);
dev->config_enabled = false;
spin_unlock_irq(&dev->config_lock);
}
-EXPORT_SYMBOL_GPL(virtio_config_disable);
-void virtio_config_enable(struct virtio_device *dev)
+static void virtio_config_enable(struct virtio_device *dev)
{
spin_lock_irq(&dev->config_lock);
dev->config_enabled = true;
@@ -158,7 +157,6 @@ void virtio_config_enable(struct virtio_device *dev)
dev->config_change_pending = false;
spin_unlock_irq(&dev->config_lock);
}
-EXPORT_SYMBOL_GPL(virtio_config_enable);
void virtio_add_status(struct virtio_device *dev, unsigned int status)
{
diff --git a/include/linux/virtio.h b/include/linux/virtio.h
index 55ea329..b1894e0 100644
--- a/include/linux/virtio.h
+++ b/include/linux/virtio.h
@@ -132,8 +132,6 @@ static inline struct virtio_device *dev_to_virtio(struct device *_dev)
void virtio_break_device(struct virtio_device *dev);
void virtio_config_changed(struct virtio_device *dev);
-void virtio_config_disable(struct virtio_device *dev);
-void virtio_config_enable(struct virtio_device *dev);
int virtio_finalize_features(struct virtio_device *dev);
#ifdef CONFIG_PM_SLEEP
int virtio_device_freeze(struct virtio_device *dev);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] virtio: remove export for virtio_config_{enable, disable}
2021-02-20 16:28 [PATCH] virtio: remove export for virtio_config_{enable, disable} Xianting Tian
@ 2021-02-22 3:45 ` Jason Wang
2021-02-22 15:27 ` Stefano Garzarella
1 sibling, 0 replies; 4+ messages in thread
From: Jason Wang @ 2021-02-22 3:45 UTC (permalink / raw)
To: Xianting Tian, mst; +Cc: guoren, virtualization, linux-kernel
On 2021/2/21 12:28 上午, Xianting Tian wrote:
> virtio_config_enable(), virtio_config_disable() are only used inside
> drivers/virtio/virtio.c, so it doesn't need export the symbols.
>
> Signed-off-by: Xianting Tian <xianting_tian@126.com>
Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> drivers/virtio/virtio.c | 6 ++----
> include/linux/virtio.h | 2 --
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
> index 42e09cc..4b15c00 100644
> --- a/drivers/virtio/virtio.c
> +++ b/drivers/virtio/virtio.c
> @@ -141,15 +141,14 @@ void virtio_config_changed(struct virtio_device *dev)
> }
> EXPORT_SYMBOL_GPL(virtio_config_changed);
>
> -void virtio_config_disable(struct virtio_device *dev)
> +static void virtio_config_disable(struct virtio_device *dev)
> {
> spin_lock_irq(&dev->config_lock);
> dev->config_enabled = false;
> spin_unlock_irq(&dev->config_lock);
> }
> -EXPORT_SYMBOL_GPL(virtio_config_disable);
>
> -void virtio_config_enable(struct virtio_device *dev)
> +static void virtio_config_enable(struct virtio_device *dev)
> {
> spin_lock_irq(&dev->config_lock);
> dev->config_enabled = true;
> @@ -158,7 +157,6 @@ void virtio_config_enable(struct virtio_device *dev)
> dev->config_change_pending = false;
> spin_unlock_irq(&dev->config_lock);
> }
> -EXPORT_SYMBOL_GPL(virtio_config_enable);
>
> void virtio_add_status(struct virtio_device *dev, unsigned int status)
> {
> diff --git a/include/linux/virtio.h b/include/linux/virtio.h
> index 55ea329..b1894e0 100644
> --- a/include/linux/virtio.h
> +++ b/include/linux/virtio.h
> @@ -132,8 +132,6 @@ static inline struct virtio_device *dev_to_virtio(struct device *_dev)
> void virtio_break_device(struct virtio_device *dev);
>
> void virtio_config_changed(struct virtio_device *dev);
> -void virtio_config_disable(struct virtio_device *dev);
> -void virtio_config_enable(struct virtio_device *dev);
> int virtio_finalize_features(struct virtio_device *dev);
> #ifdef CONFIG_PM_SLEEP
> int virtio_device_freeze(struct virtio_device *dev);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] virtio: remove export for virtio_config_{enable, disable}
2021-02-20 16:28 [PATCH] virtio: remove export for virtio_config_{enable, disable} Xianting Tian
2021-02-22 3:45 ` Jason Wang
@ 2021-02-22 15:27 ` Stefano Garzarella
1 sibling, 0 replies; 4+ messages in thread
From: Stefano Garzarella @ 2021-02-22 15:27 UTC (permalink / raw)
To: Xianting Tian; +Cc: mst, jasowang, guoren, virtualization, linux-kernel
On Sat, Feb 20, 2021 at 11:28:18AM -0500, Xianting Tian wrote:
>virtio_config_enable(), virtio_config_disable() are only used inside
>drivers/virtio/virtio.c, so it doesn't need export the symbols.
>
>Signed-off-by: Xianting Tian <xianting_tian@126.com>
>---
> drivers/virtio/virtio.c | 6 ++----
> include/linux/virtio.h | 2 --
> 2 files changed, 2 insertions(+), 6 deletions(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
>
>diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
>index 42e09cc..4b15c00 100644
>--- a/drivers/virtio/virtio.c
>+++ b/drivers/virtio/virtio.c
>@@ -141,15 +141,14 @@ void virtio_config_changed(struct virtio_device *dev)
> }
> EXPORT_SYMBOL_GPL(virtio_config_changed);
>
>-void virtio_config_disable(struct virtio_device *dev)
>+static void virtio_config_disable(struct virtio_device *dev)
> {
> spin_lock_irq(&dev->config_lock);
> dev->config_enabled = false;
> spin_unlock_irq(&dev->config_lock);
> }
>-EXPORT_SYMBOL_GPL(virtio_config_disable);
>
>-void virtio_config_enable(struct virtio_device *dev)
>+static void virtio_config_enable(struct virtio_device *dev)
> {
> spin_lock_irq(&dev->config_lock);
> dev->config_enabled = true;
>@@ -158,7 +157,6 @@ void virtio_config_enable(struct virtio_device *dev)
> dev->config_change_pending = false;
> spin_unlock_irq(&dev->config_lock);
> }
>-EXPORT_SYMBOL_GPL(virtio_config_enable);
>
> void virtio_add_status(struct virtio_device *dev, unsigned int status)
> {
>diff --git a/include/linux/virtio.h b/include/linux/virtio.h
>index 55ea329..b1894e0 100644
>--- a/include/linux/virtio.h
>+++ b/include/linux/virtio.h
>@@ -132,8 +132,6 @@ static inline struct virtio_device *dev_to_virtio(struct device *_dev)
> void virtio_break_device(struct virtio_device *dev);
>
> void virtio_config_changed(struct virtio_device *dev);
>-void virtio_config_disable(struct virtio_device *dev);
>-void virtio_config_enable(struct virtio_device *dev);
> int virtio_finalize_features(struct virtio_device *dev);
> #ifdef CONFIG_PM_SLEEP
> int virtio_device_freeze(struct virtio_device *dev);
>--
>1.8.3.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] virtio: remove export for virtio_config_{enable, disable}
@ 2021-02-21 2:48 Xianting Tian
0 siblings, 0 replies; 4+ messages in thread
From: Xianting Tian @ 2021-02-21 2:48 UTC (permalink / raw)
To: mst, jasowang; +Cc: guoren, virtualization, linux-kernel
virtio_config_enable(), virtio_config_disable() are only used inside
drivers/virtio/virtio.c, so it doesn't need export the symbols.
Signed-off-by: Xianting Tian <xianting_tian@126.com>
---
drivers/virtio/virtio.c | 6 ++----
include/linux/virtio.h | 2 --
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index 42e09cc..4b15c00 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -141,15 +141,14 @@ void virtio_config_changed(struct virtio_device *dev)
}
EXPORT_SYMBOL_GPL(virtio_config_changed);
-void virtio_config_disable(struct virtio_device *dev)
+static void virtio_config_disable(struct virtio_device *dev)
{
spin_lock_irq(&dev->config_lock);
dev->config_enabled = false;
spin_unlock_irq(&dev->config_lock);
}
-EXPORT_SYMBOL_GPL(virtio_config_disable);
-void virtio_config_enable(struct virtio_device *dev)
+static void virtio_config_enable(struct virtio_device *dev)
{
spin_lock_irq(&dev->config_lock);
dev->config_enabled = true;
@@ -158,7 +157,6 @@ void virtio_config_enable(struct virtio_device *dev)
dev->config_change_pending = false;
spin_unlock_irq(&dev->config_lock);
}
-EXPORT_SYMBOL_GPL(virtio_config_enable);
void virtio_add_status(struct virtio_device *dev, unsigned int status)
{
diff --git a/include/linux/virtio.h b/include/linux/virtio.h
index 55ea329..b1894e0 100644
--- a/include/linux/virtio.h
+++ b/include/linux/virtio.h
@@ -132,8 +132,6 @@ static inline struct virtio_device *dev_to_virtio(struct device *_dev)
void virtio_break_device(struct virtio_device *dev);
void virtio_config_changed(struct virtio_device *dev);
-void virtio_config_disable(struct virtio_device *dev);
-void virtio_config_enable(struct virtio_device *dev);
int virtio_finalize_features(struct virtio_device *dev);
#ifdef CONFIG_PM_SLEEP
int virtio_device_freeze(struct virtio_device *dev);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-22 15:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-20 16:28 [PATCH] virtio: remove export for virtio_config_{enable, disable} Xianting Tian
2021-02-22 3:45 ` Jason Wang
2021-02-22 15:27 ` Stefano Garzarella
2021-02-21 2:48 Xianting Tian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).