From: Michal Simek <michal.simek@amd.com>
To: <tumic@gpxsee.org>, Mauro Carvalho Chehab <mchehab@kernel.org>,
Vinod Koul <vkoul@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
"Sreeram, Manikanta" <manikanta.sreeram@amd.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
dmaengine@vger.kernel.org, linux-i2c@vger.kernel.org,
"Martin Tůma" <martin.tuma@digiteqautomotive.com>
Subject: Re: [PATCH v2 1/3] Added platform module alias for the xiic I2C driver
Date: Tue, 20 Sep 2022 16:30:44 +0200 [thread overview]
Message-ID: <6c5fd7a8-523b-100c-a104-d2f0bf69be16@amd.com> (raw)
In-Reply-To: <20220919185556.5215-2-tumic@gpxsee.org>
On 9/19/22 20:55, tumic@gpxsee.org wrote:
> From: Martin Tůma <martin.tuma@digiteqautomotive.com>
Subject should contain subsystem prefix and driver.
i2c: xiic: is commonly used in this driver.
>
> The missing "platform" alias is required for the mgb4 v4l2 driver to load
> the i2c controller driver when probing the HW.
>
> Signed-off-by: Martin Tůma <martin.tuma@digiteqautomotive.com>
> ---
> drivers/i2c/busses/i2c-xiic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index b3fe6b2aa3ca..277a02455cdd 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -920,6 +920,7 @@ static struct platform_driver xiic_i2c_driver = {
>
> module_platform_driver(xiic_i2c_driver);
>
> +MODULE_ALIAS("platform:" DRIVER_NAME);
> MODULE_AUTHOR("info@mocean-labs.com");
> MODULE_DESCRIPTION("Xilinx I2C bus driver");
> MODULE_LICENSE("GPL v2");
> --
> 2.37.2
>
Change is fine.
Thanks,
Michal
next prev parent reply other threads:[~2022-09-20 14:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 18:55 [PATCH v2 0/3] Digiteq Automotive MGB4 driver tumic
2022-09-19 18:55 ` [PATCH v2 1/3] Added platform module alias for the xiic I2C driver tumic
2022-09-20 14:30 ` Michal Simek [this message]
2022-09-19 18:55 ` [PATCH v2 2/3] Added Xilinx XDMA IP core driver tumic
2022-09-20 2:12 ` kernel test robot
2022-09-21 6:24 ` Lizhi Hou
2022-09-21 9:25 ` Martin Tůma
2022-09-21 15:15 ` Lizhi Hou
2022-09-21 15:35 ` Martin Tůma
2022-09-19 18:55 ` [PATCH v2 3/3] Added Digiteq Automotive MGB4 driver tumic
2022-10-03 5:19 ` kernel test robot
2022-09-21 5:32 ` [PATCH v2 0/3] " Sonal Santan
2022-09-21 9:44 ` Martin Tůma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c5fd7a8-523b-100c-a104-d2f0bf69be16@amd.com \
--to=michal.simek@amd.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=manikanta.sreeram@amd.com \
--cc=martin.tuma@digiteqautomotive.com \
--cc=mchehab@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=tumic@gpxsee.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).