From: Doug Berger <opendmb@gmail.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>,
wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com,
f.fainelli@gmail.com, davem@davemloft.net,
Vladislav.Zakharov@synopsys.com
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH 02/10] net: bcmgenet: free netdev on of_match_node() error
Date: Mon, 4 Dec 2017 17:05:27 -0800 [thread overview]
Message-ID: <6c661895-0587-26fb-cfd9-cf24dee2e002@gmail.com> (raw)
In-Reply-To: <1512242782-7134-3-git-send-email-arvind.yadav.cs@gmail.com>
On 12/02/2017 11:26 AM, Arvind Yadav wrote:
> The change is to call free_netdev(), If of_match_node() will fail.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index e2f1268..e0a8f79 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> @@ -3363,8 +3363,10 @@ static int bcmgenet_probe(struct platform_device *pdev)
>
> if (dn) {
> of_id = of_match_node(bcmgenet_match, dn);
> - if (!of_id)
> - return -EINVAL;
> + if (!of_id) {
> + err = -EINVAL;
> + goto err;
> + }
> }
>
> priv = netdev_priv(dev);
>
I agree with the fix if you want to resubmit separate from this series
and please include a "fixes" tag.
Thanks,
Doug
next prev parent reply other threads:[~2017-12-05 1:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-02 19:26 [PATCH 00/10] Handle return value of platform_get_* Arvind Yadav
2017-12-02 19:26 ` [PATCH 01/10] net: bcmgenet: Fix platform_get_irq's error checking Arvind Yadav
2017-12-02 19:26 ` [PATCH 02/10] net: bcmgenet: free netdev on of_match_node() error Arvind Yadav
2017-12-05 1:05 ` Doug Berger [this message]
2017-12-02 19:26 ` [PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking Arvind Yadav
2017-12-04 16:20 ` David Miller
2017-12-04 16:24 ` Russell King - ARM Linux
2017-12-04 16:34 ` David Miller
2017-12-04 16:42 ` Russell King - ARM Linux
2017-12-04 16:44 ` arvindY
2017-12-02 19:26 ` [PATCH 04/10] can: xilinx: Handle return value of platform_get_irq Arvind Yadav
2017-12-02 19:26 ` [PATCH 05/10] net: ethernet: i825xx: Fix platform_get_irq's error checking Arvind Yadav
2017-12-02 20:08 ` Sergei Shtylyov
2017-12-02 20:22 ` arvindY
2017-12-02 19:26 ` [PATCH 06/10] net: ethernet: natsemi: Handle return value of platform_get_irq Arvind Yadav
2017-12-02 19:26 ` [PATCH 07/10] net: ethernet: smsc: " Arvind Yadav
2017-12-02 20:06 ` Sergei Shtylyov
2017-12-02 19:26 ` [PATCH 08/10] net: fjes: Handle return value of platform_get_irq and platform_get_resource Arvind Yadav
2017-12-02 20:06 ` Sergei Shtylyov
2017-12-02 20:26 ` arvindY
2017-12-02 19:26 ` [PATCH 09/10] net: ethernet: korina: Handle return value of platform_get_irq_byname Arvind Yadav
2017-12-02 19:26 ` [PATCH 10/10] net: ethernet: cpmac: " Arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c661895-0587-26fb-cfd9-cf24dee2e002@gmail.com \
--to=opendmb@gmail.com \
--cc=Vladislav.Zakharov@synopsys.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).