From: Florian Vaussard <florian.vaussard@heig-vd.ch>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
<devicetree@vger.kernel.org>,
Andre Przywara <andre.przywara@arm.com>,
<linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 10/13] arm64: allwinner: a64: Increase the MMC max frequency
Date: Fri, 27 Jan 2017 11:29:53 +0100 [thread overview]
Message-ID: <6c6bf169-4b2e-6b55-54db-d21da73a8f6e@heig-vd.ch> (raw)
In-Reply-To: <dee0dc8e1d98698231738b10fbe79cdf6d5e4c36.1485421557.git-series.maxime.ripard@free-electrons.com>
Hi Maxime,
On 01/26/2017 10:06 AM, Maxime Ripard wrote:
> The eMMC controller seem to have a maximum frequency of 200MHz, while the
> regular MMC controllers are capped at 150MHz.
>
> Since older SoCs cannot go that high, we cannot change the default maximum
> frequency, but fortunately for us we have a property for that in the DT.
>
> This also has the side effect of allowing to use the MMC HS200 and SD
> SDR104 modes for the boards that support it (with either 1.2v or 1.8v IOs).
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> arm64: allwinner: a64: Limit MMC0 and MMC1 rates to 150MHz
>
> Trying to set the bus to 200MHz on MMC1 when doing SDIO is failing.
> Allwinner sets the maximum for this bus to 150MHz, so enforce that limit.
>
> This hasn't been tested with MMC0, but the documented limit is the same,
> and I expect the behaviour to be the same.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
I suspect that you are trying to increase your number of Signed-off-by tags by
using unfair means :) Otherwise the squashed commit message is probably worth
some cleaning.
Best,
Florian
> ---
> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 3 +++
> 1 file changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index 7b79c319ad3c..cb3e0cf2191a 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -130,6 +130,7 @@
> resets = <&ccu RST_BUS_MMC0>;
> reset-names = "ahb";
> interrupts = <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>;
> + max-frequency = <150000000>;
> status = "disabled";
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -143,6 +144,7 @@
> resets = <&ccu RST_BUS_MMC1>;
> reset-names = "ahb";
> interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
> + max-frequency = <150000000>;
> status = "disabled";
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -156,6 +158,7 @@
> resets = <&ccu RST_BUS_MMC2>;
> reset-names = "ahb";
> interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
> + max-frequency = <200000000>;
> status = "disabled";
> #address-cells = <1>;
> #size-cells = <0>;
>
next prev parent reply other threads:[~2017-01-27 10:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 9:05 [PATCH v4 0/13] arm64: allwinner: a64: Enable MMC support Maxime Ripard
2017-01-26 9:05 ` [PATCH v4 1/13] mmc: sunxi: Fix clock frequency change sequence Maxime Ripard
2017-01-26 9:05 ` [PATCH v4 2/13] mmc: sunxi: Gate the clock when rate is 0 Maxime Ripard
2017-01-26 9:05 ` [PATCH v4 3/13] mmc: sunxi: Always set signal delay to 0 for A64 Maxime Ripard
2017-01-26 9:05 ` [PATCH v4 4/13] mmc: sunxi: Enable the new timings for the A64 MMC controllers Maxime Ripard
2017-01-26 9:05 ` [PATCH v4 5/13] mmc: sunxi: Mask DATA0 when updating the clock Maxime Ripard
2017-01-26 9:05 ` [PATCH v4 6/13] mmc: sunxi: Add EMMC (MMC2) controller compatible Maxime Ripard
2017-01-26 9:06 ` [PATCH v4 7/13] mmc: sunxi: Add more debug informations Maxime Ripard
2017-01-26 9:06 ` [PATCH v4 8/13] arm64: allwinner: a64: Add MMC nodes Maxime Ripard
2017-01-26 9:06 ` [PATCH v4 9/13] arm64: allwinner: a64: Add MMC pinctrl nodes Maxime Ripard
2017-01-26 9:06 ` [PATCH v4 10/13] arm64: allwinner: a64: Increase the MMC max frequency Maxime Ripard
2017-01-27 10:29 ` Florian Vaussard [this message]
2017-01-27 21:26 ` Maxime Ripard
2017-01-26 9:06 ` [PATCH v4 11/13] arm64: allwinner: pine64: add MMC support Maxime Ripard
2017-01-26 9:06 ` [PATCH v4 12/13] arm64: allwinner: a64: add UART1 pin nodes Maxime Ripard
2017-01-26 9:06 ` [PATCH v4 13/13] arm64: allwinner: add BananaPi-M64 support Maxime Ripard
2017-01-27 10:37 ` [PATCH v4 0/13] arm64: allwinner: a64: Enable MMC support Florian Vaussard
2017-01-27 21:27 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c6bf169-4b2e-6b55-54db-d21da73a8f6e@heig-vd.ch \
--to=florian.vaussard@heig-vd.ch \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).