From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
Andre Przywara <andre.przywara@arm.com>
Subject: [PATCH v4 4/13] mmc: sunxi: Enable the new timings for the A64 MMC controllers
Date: Thu, 26 Jan 2017 10:05:57 +0100 [thread overview]
Message-ID: <d6dfbf595cb99709877e7e57595125ce0b783ff6.1485421557.git-series.maxime.ripard@free-electrons.com> (raw)
In-Reply-To: <cover.8d42a39b7bd5143e709979dc42cc47862ebe3728.1485421557.git-series.maxime.ripard@free-electrons.com>
In-Reply-To: <cover.8d42a39b7bd5143e709979dc42cc47862ebe3728.1485421557.git-series.maxime.ripard@free-electrons.com>
The A64 MMC controllers need to set a "new timings" bit when a new rate is
set.
The actual meaning of that bit is not clear yet, but not setting it leads
to some corner-case issues, like the CMD53 failing, which is used to
implement SDIO packet aggregation.
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
drivers/mmc/host/sunxi-mmc.c | 6 ++++++
1 file changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index b9c8a62bc212..51d6388a194e 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c
@@ -253,6 +253,8 @@ struct sunxi_mmc_cfg {
/* does the IP block support autocalibration? */
bool can_calibrate;
+
+ bool needs_new_timings;
};
struct sunxi_mmc_host {
@@ -779,6 +781,9 @@ static int sunxi_mmc_clk_set_rate(struct sunxi_mmc_host *host,
}
mmc_writel(host, REG_CLKCR, rval);
+ if (host->cfg->needs_new_timings)
+ mmc_writel(host, REG_SD_NTSR, SDXC_2X_TIMING_MODE);
+
ret = sunxi_mmc_clk_set_phase(host, ios, rate);
if (ret)
return ret;
@@ -1076,6 +1081,7 @@ static const struct sunxi_mmc_cfg sun50i_a64_cfg = {
.idma_des_size_bits = 16,
.clk_delays = NULL,
.can_calibrate = true,
+ .needs_new_timings = true,
};
static const struct of_device_id sunxi_mmc_of_match[] = {
--
git-series 0.8.11
next prev parent reply other threads:[~2017-01-26 9:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 9:05 [PATCH v4 0/13] arm64: allwinner: a64: Enable MMC support Maxime Ripard
2017-01-26 9:05 ` [PATCH v4 1/13] mmc: sunxi: Fix clock frequency change sequence Maxime Ripard
2017-01-26 9:05 ` [PATCH v4 2/13] mmc: sunxi: Gate the clock when rate is 0 Maxime Ripard
2017-01-26 9:05 ` [PATCH v4 3/13] mmc: sunxi: Always set signal delay to 0 for A64 Maxime Ripard
2017-01-26 9:05 ` Maxime Ripard [this message]
2017-01-26 9:05 ` [PATCH v4 5/13] mmc: sunxi: Mask DATA0 when updating the clock Maxime Ripard
2017-01-26 9:05 ` [PATCH v4 6/13] mmc: sunxi: Add EMMC (MMC2) controller compatible Maxime Ripard
2017-01-26 9:06 ` [PATCH v4 7/13] mmc: sunxi: Add more debug informations Maxime Ripard
2017-01-26 9:06 ` [PATCH v4 8/13] arm64: allwinner: a64: Add MMC nodes Maxime Ripard
2017-01-26 9:06 ` [PATCH v4 9/13] arm64: allwinner: a64: Add MMC pinctrl nodes Maxime Ripard
2017-01-26 9:06 ` [PATCH v4 10/13] arm64: allwinner: a64: Increase the MMC max frequency Maxime Ripard
2017-01-27 10:29 ` Florian Vaussard
2017-01-27 21:26 ` Maxime Ripard
2017-01-26 9:06 ` [PATCH v4 11/13] arm64: allwinner: pine64: add MMC support Maxime Ripard
2017-01-26 9:06 ` [PATCH v4 12/13] arm64: allwinner: a64: add UART1 pin nodes Maxime Ripard
2017-01-26 9:06 ` [PATCH v4 13/13] arm64: allwinner: add BananaPi-M64 support Maxime Ripard
2017-01-27 10:37 ` [PATCH v4 0/13] arm64: allwinner: a64: Enable MMC support Florian Vaussard
2017-01-27 21:27 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6dfbf595cb99709877e7e57595125ce0b783ff6.1485421557.git-series.maxime.ripard@free-electrons.com \
--to=maxime.ripard@free-electrons.com \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).