[PATCH 0/2] cleanup patches for PM reference leak

[PATCH 0/2] cleanup patches for PM reference leak

[Yu Kuai]

Yu Kuai (2):
  drm/v3d: Fix PM reference leak in v3d_get_param_ioctl()
  drm/v3d: Fix PM reference leak in v3d_v3d_debugfs_ident()

 drivers/gpu/drm/v3d/v3d_debugfs.c | 4 ++--
 drivers/gpu/drm/v3d/v3d_drv.c     | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.25.4

[PATCH 1/2] drm/v3d: Fix PM reference leak in v3d_get_param_ioctl()

[Yu Kuai]

pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
 drivers/gpu/drm/v3d/v3d_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
index 99e22beea90b..12abcc7e9d53 100644
--- a/drivers/gpu/drm/v3d/v3d_drv.c
+++ b/drivers/gpu/drm/v3d/v3d_drv.c
@@ -69,7 +69,7 @@ static int v3d_get_param_ioctl(struct drm_device *dev, void *data,
 		if (args->value != 0)
 			return -EINVAL;
 
-		ret = pm_runtime_get_sync(v3d->drm.dev);
+		ret = pm_runtime_resume_and_get(v3d->drm.dev);
 		if (ret < 0)
 			return ret;
 		if (args->param >= DRM_V3D_PARAM_V3D_CORE0_IDENT0 &&
-- 
2.25.4

[PATCH 2/2] drm/v3d: Fix PM reference leak in v3d_v3d_debugfs_ident()

[Yu Kuai]

pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
 drivers/gpu/drm/v3d/v3d_debugfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/v3d/v3d_debugfs.c b/drivers/gpu/drm/v3d/v3d_debugfs.c
index e76b24bb8828..91ceed774140 100644
--- a/drivers/gpu/drm/v3d/v3d_debugfs.c
+++ b/drivers/gpu/drm/v3d/v3d_debugfs.c
@@ -132,7 +132,7 @@ static int v3d_v3d_debugfs_ident(struct seq_file *m, void *unused)
 	u32 ident0, ident1, ident2, ident3, cores;
 	int ret, core;
 
-	ret = pm_runtime_get_sync(v3d->drm.dev);
+	ret = pm_runtime_resume_and_get(v3d->drm.dev);
 	if (ret < 0)
 		return ret;
 
@@ -219,7 +219,7 @@ static int v3d_measure_clock(struct seq_file *m, void *unused)
 	int measure_ms = 1000;
 	int ret;
 
-	ret = pm_runtime_get_sync(v3d->drm.dev);
+	ret = pm_runtime_resume_and_get(v3d->drm.dev);
 	if (ret < 0)
 		return ret;
 
-- 
2.25.4

Re: [PATCH 0/2] cleanup patches for PM reference leak

[yukuai (C)]

ping ...

On 2021/05/17 16:14, Yu Kuai wrote:
> Yu Kuai (2):
>    drm/v3d: Fix PM reference leak in v3d_get_param_ioctl()
>    drm/v3d: Fix PM reference leak in v3d_v3d_debugfs_ident()
> 
>   drivers/gpu/drm/v3d/v3d_debugfs.c | 4 ++--
>   drivers/gpu/drm/v3d/v3d_drv.c     | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 

Re: [PATCH 0/2] cleanup patches for PM reference leak

[yukuai (C)]

ping ...

On 2021/05/29 17:11, yukuai (C) wrote:
> ping ...
> 
> On 2021/05/17 16:14, Yu Kuai wrote:
>> Yu Kuai (2):
>>    drm/v3d: Fix PM reference leak in v3d_get_param_ioctl()
>>    drm/v3d: Fix PM reference leak in v3d_v3d_debugfs_ident()
>>
>>   drivers/gpu/drm/v3d/v3d_debugfs.c | 4 ++--
>>   drivers/gpu/drm/v3d/v3d_drv.c     | 2 +-
>>   2 files changed, 3 insertions(+), 3 deletions(-)
>>