From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Naga Sureshkumar Relli <nagasuresh.relli@microchip.com>,
broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor.dooley@microchip.com
Cc: linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] spi: dt-binding: add Microchip CoreQSPI compatible
Date: Tue, 2 Aug 2022 10:52:25 +0200 [thread overview]
Message-ID: <6d36b192-9e63-ec13-5583-22b81c99c18b@linaro.org> (raw)
In-Reply-To: <20220801094255.664548-2-nagasuresh.relli@microchip.com>
On 01/08/2022 11:42, Naga Sureshkumar Relli wrote:
> Add compatible string for Microchip CoreQSPI controller.
>
> Signed-off-by: Naga Sureshkumar Relli <nagasuresh.relli@microchip.com>
> ---
> .../devicetree/bindings/spi/microchip,mpfs-spi.yaml | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> index 7326c0a28d16..b65f4e070796 100644
> --- a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> @@ -14,9 +14,13 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - microchip,mpfs-spi
> - - microchip,mpfs-qspi
> + oneOf:
> + - description: Microchip's Polarfire SoC SPI controller.
> + const: microchip,mpfs-spi
> + - description: Microchip's Polarfire SoC QSPI controller.
Useless descriptions - they repeat compatible. Just keep it as enum and
skip descriptions. What value do they bring?
> + const: microchip,mpfs-qspi
> + - description: Microchip's FPGA QSPI controller.
> + const: microchip,coreqspi-rtl-v2
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-02 8:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 9:42 [PATCH 0/2] Add support for Microchip QSPI controller Naga Sureshkumar Relli
2022-08-01 9:42 ` [PATCH 1/2] spi: dt-binding: add Microchip CoreQSPI compatible Naga Sureshkumar Relli
2022-08-01 10:17 ` Conor.Dooley
2022-08-01 10:52 ` naga sureshkumar
2022-08-02 8:52 ` Krzysztof Kozlowski [this message]
2022-08-02 13:13 ` Mark Brown
2022-08-03 6:11 ` Krzysztof Kozlowski
2022-08-03 6:59 ` naga sureshkumar
2022-08-03 7:48 ` Krzysztof Kozlowski
2022-08-03 13:29 ` Mark Brown
2022-08-04 11:31 ` Krzysztof Kozlowski
2022-08-04 11:35 ` Krzysztof Kozlowski
2022-08-04 12:13 ` Mark Brown
2022-08-01 9:42 ` [PATCH 2/2] spi: microchip-core-qspi: Add support for microchip fpga qspi controllers Naga Sureshkumar Relli
2022-08-01 10:40 ` Conor.Dooley
2022-08-01 11:09 ` naga sureshkumar
2022-08-01 12:33 ` Mark Brown
2022-08-01 12:56 ` Conor.Dooley
2022-08-02 8:54 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d36b192-9e63-ec13-5583-22b81c99c18b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nagasuresh.relli@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).