From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Naga Sureshkumar Relli <nagasuresh.relli@microchip.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor.dooley@microchip.com, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] spi: dt-binding: add Microchip CoreQSPI compatible
Date: Wed, 3 Aug 2022 08:11:03 +0200 [thread overview]
Message-ID: <dc7bca02-5eb3-3b33-8911-a950b630f197@linaro.org> (raw)
In-Reply-To: <Yuki3jpCSJDdXcWA@sirena.org.uk>
On 02/08/2022 15:13, Mark Brown wrote:
> On Tue, Aug 02, 2022 at 10:52:25AM +0200, Krzysztof Kozlowski wrote:
>> On 01/08/2022 11:42, Naga Sureshkumar Relli wrote:
>
>>> - enum:
>>> - - microchip,mpfs-spi
>>> - - microchip,mpfs-qspi
>>> + oneOf:
>>> + - description: Microchip's Polarfire SoC SPI controller.
>>> + const: microchip,mpfs-spi
>>> + - description: Microchip's Polarfire SoC QSPI controller.
>
>> Useless descriptions - they repeat compatible. Just keep it as enum and
>> skip descriptions. What value do they bring?
>
> Someone not familiar with the full Microchip product line might not be
> aware of the expansion of mpfs, it's not blindingly obvious.
Then it should be explained in title/description of the binding, not in
compatible. This is the usual way of providing some text description,
not for each compatible by repeating the compatible text.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-03 6:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 9:42 [PATCH 0/2] Add support for Microchip QSPI controller Naga Sureshkumar Relli
2022-08-01 9:42 ` [PATCH 1/2] spi: dt-binding: add Microchip CoreQSPI compatible Naga Sureshkumar Relli
2022-08-01 10:17 ` Conor.Dooley
2022-08-01 10:52 ` naga sureshkumar
2022-08-02 8:52 ` Krzysztof Kozlowski
2022-08-02 13:13 ` Mark Brown
2022-08-03 6:11 ` Krzysztof Kozlowski [this message]
2022-08-03 6:59 ` naga sureshkumar
2022-08-03 7:48 ` Krzysztof Kozlowski
2022-08-03 13:29 ` Mark Brown
2022-08-04 11:31 ` Krzysztof Kozlowski
2022-08-04 11:35 ` Krzysztof Kozlowski
2022-08-04 12:13 ` Mark Brown
2022-08-01 9:42 ` [PATCH 2/2] spi: microchip-core-qspi: Add support for microchip fpga qspi controllers Naga Sureshkumar Relli
2022-08-01 10:40 ` Conor.Dooley
2022-08-01 11:09 ` naga sureshkumar
2022-08-01 12:33 ` Mark Brown
2022-08-01 12:56 ` Conor.Dooley
2022-08-02 8:54 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc7bca02-5eb3-3b33-8911-a950b630f197@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nagasuresh.relli@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).