From: Lukasz Luba <lukasz.luba@arm.com>
To: Randy Dunlap <rdunlap@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] PM: <linux/device.h>: fix @em_pd kernel-doc warning
Date: Mon, 7 Sep 2020 12:29:55 +0100 [thread overview]
Message-ID: <6de9dd19-3bbc-41a7-b36d-9f085eb2e548@arm.com> (raw)
In-Reply-To: <d97f40ad-3033-703a-c3cb-2843ce0f6371@infradead.org>
Hi Randy,
On 9/7/20 4:42 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kernel-doc warning in <linux/device.h>:
>
> ../include/linux/device.h:613: warning: Function parameter or member 'em_pd' not described in 'device'
>
> Fixes: 1bc138c62295 ("PM / EM: add support for other devices than CPUs in Energy Model")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Lukasz Luba <lukasz.luba@arm.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> include/linux/device.h | 1 +
> 1 file changed, 1 insertion(+)
>
> --- lnx-59-rc4.orig/include/linux/device.h
> +++ lnx-59-rc4/include/linux/device.h
> @@ -454,6 +454,7 @@ struct dev_links_info {
> * @pm_domain: Provide callbacks that are executed during system suspend,
> * hibernation, system resume and during runtime PM transitions
> * along with subsystem-level and driver-level callbacks.
> + * @em_pd: device's energy model performance domain
> * @pins: For device pin management.
> * See Documentation/driver-api/pinctl.rst for details.
> * @msi_list: Hosts MSI descriptors
>
Good catch. Thank you for the patch.
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Regards,
Lukasz Luba
next prev parent reply other threads:[~2020-09-07 11:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 3:42 [PATCH] PM: <linux/device.h>: fix @em_pd kernel-doc warning Randy Dunlap
2020-09-07 11:29 ` Lukasz Luba [this message]
2020-09-10 17:24 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6de9dd19-3bbc-41a7-b36d-9f085eb2e548@arm.com \
--to=lukasz.luba@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).