* [PATCH v2] staging: mt7621-pinctrl: Use correct pointer type argument for sizeof
@ 2020-04-20 12:41 Jason Yan
2020-04-20 13:07 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Jason Yan @ 2020-04-20 12:41 UTC (permalink / raw)
To: gregkh, matthias.bgg, nishkadg.linux, devel, linux-arm-kernel,
linux-mediatek, linux-kernel
Cc: Jason Yan
Fix the following coccicheck warning:
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:223:14-36: WARNING: Use
correct pointer type argument for sizeof
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
index d0f06790d38f..caaf9e34f1ee 100644
--- a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
+++ b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
@@ -220,7 +220,7 @@ static int rt2880_pinmux_index(struct rt2880_priv *p)
/* allocate our function and group mapping index buffers */
f = p->func = devm_kcalloc(p->dev,
p->func_count,
- sizeof(struct rt2880_pmx_func),
+ sizeof(*p->func),
GFP_KERNEL);
gpio_func.groups = devm_kcalloc(p->dev, p->group_count, sizeof(int),
GFP_KERNEL);
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: mt7621-pinctrl: Use correct pointer type argument for sizeof
2020-04-20 12:41 [PATCH v2] staging: mt7621-pinctrl: Use correct pointer type argument for sizeof Jason Yan
@ 2020-04-20 13:07 ` Greg KH
2020-04-20 13:36 ` Jason Yan
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2020-04-20 13:07 UTC (permalink / raw)
To: Jason Yan
Cc: matthias.bgg, nishkadg.linux, devel, linux-arm-kernel,
linux-mediatek, linux-kernel
On Mon, Apr 20, 2020 at 08:41:51PM +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:223:14-36: WARNING: Use
> correct pointer type argument for sizeof
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
What changed from v1? Always put that below the --- line.
Please fix up and send a v3.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: mt7621-pinctrl: Use correct pointer type argument for sizeof
2020-04-20 13:07 ` Greg KH
@ 2020-04-20 13:36 ` Jason Yan
0 siblings, 0 replies; 3+ messages in thread
From: Jason Yan @ 2020-04-20 13:36 UTC (permalink / raw)
To: Greg KH
Cc: matthias.bgg, nishkadg.linux, devel, linux-arm-kernel,
linux-mediatek, linux-kernel
在 2020/4/20 21:07, Greg KH 写道:
> On Mon, Apr 20, 2020 at 08:41:51PM +0800, Jason Yan wrote:
>> Fix the following coccicheck warning:
>>
>> drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:223:14-36: WARNING: Use
>> correct pointer type argument for sizeof
>>
>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
>> ---
>> drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> What changed from v1? Always put that below the --- line.
>
> Please fix up and send a v3.
>
OK.
> thanks,
>
> greg k-h
>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-20 13:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-20 12:41 [PATCH v2] staging: mt7621-pinctrl: Use correct pointer type argument for sizeof Jason Yan
2020-04-20 13:07 ` Greg KH
2020-04-20 13:36 ` Jason Yan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).