* [PATCH] mmc: core: Fix indentation
@ 2020-02-21 10:43 Jerome Pouiller
2020-02-21 14:36 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Jerome Pouiller @ 2020-02-21 10:43 UTC (permalink / raw)
To: linux-mmc, Ulf Hansson; +Cc: linux-kernel, Jérôme Pouiller
From: Jérôme Pouiller <jerome.pouiller@silabs.com>
sdio_single_irq_set() was indented with a mix of tabs and spaces.
Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
---
drivers/mmc/core/sdio_irq.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/mmc/core/sdio_irq.c b/drivers/mmc/core/sdio_irq.c
index 900871073bd7..fae25fc65b95 100644
--- a/drivers/mmc/core/sdio_irq.c
+++ b/drivers/mmc/core/sdio_irq.c
@@ -278,12 +278,12 @@ static void sdio_single_irq_set(struct mmc_card *card)
if ((card->host->caps & MMC_CAP_SDIO_IRQ) &&
card->host->sdio_irqs == 1)
for (i = 0; i < card->sdio_funcs; i++) {
- func = card->sdio_func[i];
- if (func && func->irq_handler) {
- card->sdio_single_irq = func;
- break;
- }
- }
+ func = card->sdio_func[i];
+ if (func && func->irq_handler) {
+ card->sdio_single_irq = func;
+ break;
+ }
+ }
}
/**
--
2.25.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: core: Fix indentation
2020-02-21 10:43 [PATCH] mmc: core: Fix indentation Jerome Pouiller
@ 2020-02-21 14:36 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2020-02-21 14:36 UTC (permalink / raw)
To: Jerome Pouiller, linux-mmc, Ulf Hansson; +Cc: linux-kernel
On Fri, 2020-02-21 at 11:43 +0100, Jerome Pouiller wrote:
> sdio_single_irq_set() was indented with a mix of tabs and spaces.
[]
> diff --git a/drivers/mmc/core/sdio_irq.c b/drivers/mmc/core/sdio_irq.c
[]
> @@ -278,12 +278,12 @@ static void sdio_single_irq_set(struct mmc_card *card)
> if ((card->host->caps & MMC_CAP_SDIO_IRQ) &&
> card->host->sdio_irqs == 1)
> for (i = 0; i < card->sdio_funcs; i++) {
> - func = card->sdio_func[i];
> - if (func && func->irq_handler) {
> - card->sdio_single_irq = func;
> - break;
> - }
> - }
> + func = card->sdio_func[i];
> + if (func && func->irq_handler) {
> + card->sdio_single_irq = func;
> + break;
> + }
> + }
> }
Perhaps it'd be better to add braces around the for loop too.
---
drivers/mmc/core/sdio_irq.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/mmc/core/sdio_irq.c b/drivers/mmc/core/sdio_irq.c
index 7ca7b9..3086ed 100644
--- a/drivers/mmc/core/sdio_irq.c
+++ b/drivers/mmc/core/sdio_irq.c
@@ -260,14 +260,15 @@ static void sdio_single_irq_set(struct mmc_card *card)
card->sdio_single_irq = NULL;
if ((card->host->caps & MMC_CAP_SDIO_IRQ) &&
- card->host->sdio_irqs == 1)
+ card->host->sdio_irqs == 1) {
for (i = 0; i < card->sdio_funcs; i++) {
- func = card->sdio_func[i];
- if (func && func->irq_handler) {
- card->sdio_single_irq = func;
- break;
- }
- }
+ func = card->sdio_func[i];
+ if (func && func->irq_handler) {
+ card->sdio_single_irq = func;
+ break;
+ }
+ }
+ }
}
/**
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-21 14:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-21 10:43 [PATCH] mmc: core: Fix indentation Jerome Pouiller
2020-02-21 14:36 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).